Commit f4ce5af7 authored by Thomas Zimmermann's avatar Thomas Zimmermann

drm/mgag200: Pin framebuffer BO during dirty update

Another explicit lock operation of a GEM VRAM BO is located in mgag200's
framebuffer update code. Instead of locking the BO, we pin it to wherever
it is.

v2:
	* update with pin flag of 0
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613073041.29350-7-tzimmermann@suse.de
parent da460a29
...@@ -26,7 +26,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, ...@@ -26,7 +26,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev,
struct drm_gem_vram_object *gbo; struct drm_gem_vram_object *gbo;
int src_offset, dst_offset; int src_offset, dst_offset;
int bpp = mfbdev->mfb.base.format->cpp[0]; int bpp = mfbdev->mfb.base.format->cpp[0];
int ret = -EBUSY; int ret;
u8 *dst; u8 *dst;
bool unmap = false; bool unmap = false;
bool store_for_later = false; bool store_for_later = false;
...@@ -36,16 +36,18 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, ...@@ -36,16 +36,18 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev,
obj = mfbdev->mfb.obj; obj = mfbdev->mfb.obj;
gbo = drm_gem_vram_of_gem(obj); gbo = drm_gem_vram_of_gem(obj);
/* Try to lock the BO. If we fail with -EBUSY then if (drm_can_sleep()) {
* the BO is being moved and we should store up the /* We pin the BO so it won't be moved during the
* damage until later. * update. The actual location, video RAM or system
* memory, is not important.
*/ */
if (drm_can_sleep()) ret = drm_gem_vram_pin(gbo, 0);
ret = drm_gem_vram_lock(gbo, true);
if (ret) { if (ret) {
if (ret != -EBUSY) if (ret != -EBUSY)
return; return;
store_for_later = true;
}
} else {
store_for_later = true; store_for_later = true;
} }
...@@ -100,7 +102,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, ...@@ -100,7 +102,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev,
drm_gem_vram_kunmap(gbo); drm_gem_vram_kunmap(gbo);
out: out:
drm_gem_vram_unlock(gbo); drm_gem_vram_unpin(gbo);
} }
static void mga_fillrect(struct fb_info *info, static void mga_fillrect(struct fb_info *info,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment