Commit f5001cea authored by WANG Cong's avatar WANG Cong Committed by David S. Miller

kcm: remove a useless copy_from_user()

struct kcm_clone only contains fd, and kcm_clone() only
writes this struct, so there is no need to copy it from user.

Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6b2af241
...@@ -1707,11 +1707,7 @@ static int kcm_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) ...@@ -1707,11 +1707,7 @@ static int kcm_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
struct kcm_clone info; struct kcm_clone info;
struct socket *newsock = NULL; struct socket *newsock = NULL;
if (copy_from_user(&info, (void __user *)arg, sizeof(info)))
return -EFAULT;
err = kcm_clone(sock, &info, &newsock); err = kcm_clone(sock, &info, &newsock);
if (!err) { if (!err) {
if (copy_to_user((void __user *)arg, &info, if (copy_to_user((void __user *)arg, &info,
sizeof(info))) { sizeof(info))) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment