Commit f5ba2d32 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller

[PKT_SCHED]: Fix datalen check in tcf_simp_init().

datalen is unsigned so it can never be less than zero,
but that's ok because the attribute passed to nla_len()
has been validated and therefore a negative return
value is impossible.
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 53083773
...@@ -115,7 +115,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est, ...@@ -115,7 +115,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
return -EINVAL; return -EINVAL;
datalen = nla_len(tb[TCA_DEF_DATA]); datalen = nla_len(tb[TCA_DEF_DATA]);
if (datalen <= 0) if (datalen == 0)
return -EINVAL; return -EINVAL;
pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info); pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment