Commit f867d2a2 authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds

[PATCH] ensure NULL deref can't possibly happen in is_exported()

If CONFIG_KALLSYMS is defined and if it should happen that is_exported() is
given a NULL 'mod' and lookup_symbol(name, __start___ksymtab,
__stop___ksymtab) returns 0, then we'll end up dereferencing a NULL
pointer.
Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5474c120
...@@ -1326,7 +1326,7 @@ int is_exported(const char *name, const struct module *mod) ...@@ -1326,7 +1326,7 @@ int is_exported(const char *name, const struct module *mod)
if (!mod && lookup_symbol(name, __start___ksymtab, __stop___ksymtab)) if (!mod && lookup_symbol(name, __start___ksymtab, __stop___ksymtab))
return 1; return 1;
else else
if (lookup_symbol(name, mod->syms, mod->syms + mod->num_syms)) if (mod && lookup_symbol(name, mod->syms, mod->syms + mod->num_syms))
return 1; return 1;
else else
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment