Commit f8b9b871 authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab

[media] e4000: various small changes

* Rename device state from 's' to 'dev'.
* Move single include to driver private header.
* Change error handling type of each function to one I tend use
nowadays.
* Remove dummy register write from init. Even Windows driver does this
multiple times remove it as I have never seen any I2C errors.
* Define I2C client pointer for each function and use it.
* Do not clean tuner ops during driver remove - not needed.
* Disable sysfs device bind / unbind. We are not allowed manually
bind / unbind device from the driver currently.
* Rename some other variables.
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 0e3a71c3
This diff is collapsed.
...@@ -21,7 +21,6 @@ ...@@ -21,7 +21,6 @@
#ifndef E4000_H #ifndef E4000_H
#define E4000_H #define E4000_H
#include <linux/kconfig.h>
#include "dvb_frontend.h" #include "dvb_frontend.h"
/* /*
......
...@@ -22,14 +22,15 @@ ...@@ -22,14 +22,15 @@
#define E4000_PRIV_H #define E4000_PRIV_H
#include "e4000.h" #include "e4000.h"
#include <linux/math64.h>
#include <media/v4l2-ctrls.h> #include <media/v4l2-ctrls.h>
#include <media/v4l2-subdev.h> #include <media/v4l2-subdev.h>
#include <linux/regmap.h> #include <linux/regmap.h>
struct e4000 { struct e4000_dev {
struct i2c_client *client; struct i2c_client *client;
struct regmap *regmap; struct regmap *regmap;
u32 clock; u32 clk;
struct dvb_frontend *fe; struct dvb_frontend *fe;
struct v4l2_subdev sd; struct v4l2_subdev sd;
bool active; bool active;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment