Commit fa027328 authored by Colin Ian King's avatar Colin Ian King Committed by Jason Gunthorpe

RDMA/hns: fix inverted logic of readl read and shift

A previous change incorrectly changed the inverted logic and logically
negated the readl rather than the shifted readl result. Fix this by
adding in missing parentheses around the expression that needs to be
logically negated.

Addresses-Coverity: ("Logically dead code")
Fixes: 669cefb6 ("RDMA/hns: Remove jiffies operation in disable interrupt context")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent bcef5b72
...@@ -378,7 +378,7 @@ static int hns_roce_set_hem(struct hns_roce_dev *hr_dev, ...@@ -378,7 +378,7 @@ static int hns_roce_set_hem(struct hns_roce_dev *hr_dev,
end = HW_SYNC_TIMEOUT_MSECS; end = HW_SYNC_TIMEOUT_MSECS;
while (end) { while (end) {
if (!readl(bt_cmd) >> BT_CMD_SYNC_SHIFT) if (!(readl(bt_cmd) >> BT_CMD_SYNC_SHIFT))
break; break;
mdelay(HW_SYNC_SLEEP_TIME_INTERVAL); mdelay(HW_SYNC_SLEEP_TIME_INTERVAL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment