Commit fc54048a authored by Thomas Zimmermann's avatar Thomas Zimmermann

drm/mgag200: Set up fbdev after registering device; remove error checks

Generic fbdev support is a DRM client. Set it up after registering
the new DRM device. Remove the error checks as the driver's probe
function should not depend on a DRM client's state.
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-7-tzimmermann@suse.de
parent c05ca218
...@@ -77,6 +77,8 @@ static int mga_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -77,6 +77,8 @@ static int mga_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (ret) if (ret)
goto err_mgag200_driver_unload; goto err_mgag200_driver_unload;
drm_fbdev_generic_setup(dev, 0);
return 0; return 0;
err_mgag200_driver_unload: err_mgag200_driver_unload:
......
...@@ -181,10 +181,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags) ...@@ -181,10 +181,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags)
dev_warn(&dev->pdev->dev, dev_warn(&dev->pdev->dev,
"Could not initialize cursors. Not doing hardware cursors.\n"); "Could not initialize cursors. Not doing hardware cursors.\n");
r = drm_fbdev_generic_setup(mdev->dev, 0);
if (r)
goto err_modeset;
return 0; return 0;
err_modeset: err_modeset:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment