Commit fe06bf3d authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller

net: tulip: Adjust indentation in {dmfe, uli526x}_init_module

Clang warns:

../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch (mode) {
        ^
../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch(mode) {
        ^
../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on these
lines. Remove them so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

While we are here, adjust the default block in dmfe_init_module to have
a proper break between the label and assignment and add a space between
the switch and opening parentheses to avoid a checkpatch warning.

Fixes: e1c3e501 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/795Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 80bfc3b4
...@@ -2214,7 +2214,7 @@ static int __init dmfe_init_module(void) ...@@ -2214,7 +2214,7 @@ static int __init dmfe_init_module(void)
if (cr6set) if (cr6set)
dmfe_cr6_user_set = cr6set; dmfe_cr6_user_set = cr6set;
switch(mode) { switch (mode) {
case DMFE_10MHF: case DMFE_10MHF:
case DMFE_100MHF: case DMFE_100MHF:
case DMFE_10MFD: case DMFE_10MFD:
...@@ -2222,7 +2222,8 @@ static int __init dmfe_init_module(void) ...@@ -2222,7 +2222,8 @@ static int __init dmfe_init_module(void)
case DMFE_1M_HPNA: case DMFE_1M_HPNA:
dmfe_media_mode = mode; dmfe_media_mode = mode;
break; break;
default:dmfe_media_mode = DMFE_AUTO; default:
dmfe_media_mode = DMFE_AUTO;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment