Commit fee64d3c authored by Jeff Dike's avatar Jeff Dike Committed by Linus Torvalds

uml: syle fixes in arch/um/os-Linux

Style fixes in arch/um/os-Linux/irq.c and arch/um/os-Linux/sigio.c:
	Updated copyrights
	trimmed includes
	added severity indicators to printks
	CodingStyle fixes
	turned an bunch of panics into printks
	call some libc functions directly instead of going through the
os_* wrappers
Signed-off-by: default avatarJeff Dike <jdike@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 260c0cb8
/* /*
* Copyright (C) 2000, 2001, 2002 Jeff Dike (jdike@karaya.com) * Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
* Licensed under the GPL * Licensed under the GPL
*/ */
#include <stdlib.h> #include <stdlib.h>
#include <unistd.h>
#include <errno.h> #include <errno.h>
#include <poll.h>
#include <signal.h> #include <signal.h>
#include <string.h> #include <string.h>
#include <sys/poll.h>
#include <sys/types.h>
#include <sys/time.h>
#include "user.h"
#include "process.h"
#include "sigio.h"
#include "irq_user.h" #include "irq_user.h"
#include "kern_constants.h"
#include "os.h" #include "os.h"
#include "process.h"
#include "um_malloc.h" #include "um_malloc.h"
#include "user.h"
/* /*
* Locked by irq_lock in arch/um/kernel/irq.c. Changed by os_create_pollfd * Locked by irq_lock in arch/um/kernel/irq.c. Changed by os_create_pollfd
...@@ -35,7 +32,7 @@ int os_waiting_for_events(struct irq_fd *active_fds) ...@@ -35,7 +32,7 @@ int os_waiting_for_events(struct irq_fd *active_fds)
if (n < 0) { if (n < 0) {
err = -errno; err = -errno;
if (errno != EINTR) if (errno != EINTR)
printk("sigio_handler: os_waiting_for_events:" printk(UM_KERN_ERR "os_waiting_for_events:"
" poll returned %d, errno = %d\n", n, errno); " poll returned %d, errno = %d\n", n, errno);
return err; return err;
} }
...@@ -94,24 +91,26 @@ void os_free_irq_by_cb(int (*test)(struct irq_fd *, void *), void *arg, ...@@ -94,24 +91,26 @@ void os_free_irq_by_cb(int (*test)(struct irq_fd *, void *), void *arg,
struct irq_fd *old_fd = *prev; struct irq_fd *old_fd = *prev;
if ((pollfds[i].fd != -1) && if ((pollfds[i].fd != -1) &&
(pollfds[i].fd != (*prev)->fd)) { (pollfds[i].fd != (*prev)->fd)) {
printk("os_free_irq_by_cb - mismatch between " printk(UM_KERN_ERR "os_free_irq_by_cb - "
"active_fds and pollfds, fd %d vs %d\n", "mismatch between active_fds and "
"pollfds, fd %d vs %d\n",
(*prev)->fd, pollfds[i].fd); (*prev)->fd, pollfds[i].fd);
goto out; goto out;
} }
pollfds_num--; pollfds_num--;
/* This moves the *whole* array after pollfds[i] /*
* This moves the *whole* array after pollfds[i]
* (though it doesn't spot as such)! * (though it doesn't spot as such)!
*/ */
memmove(&pollfds[i], &pollfds[i + 1], memmove(&pollfds[i], &pollfds[i + 1],
(pollfds_num - i) * sizeof(pollfds[0])); (pollfds_num - i) * sizeof(pollfds[0]));
if(*last_irq_ptr2 == &old_fd->next) if (*last_irq_ptr2 == &old_fd->next)
*last_irq_ptr2 = prev; *last_irq_ptr2 = prev;
*prev = (*prev)->next; *prev = (*prev)->next;
if(old_fd->type == IRQ_WRITE) if (old_fd->type == IRQ_WRITE)
ignore_sigio_fd(old_fd->fd); ignore_sigio_fd(old_fd->fd);
kfree(old_fd); kfree(old_fd);
continue; continue;
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment