- 31 Aug, 2010 35 commits
-
-
Dan Carpenter authored
i2c_smbus_read_byte_data() returns an s32 type. We need to change "rate" to signed for the error handling to work. Also I changed it to propogate the error code instead of just returning -EINVAL. Other error codes could be -EAGAIN for example. Signed-off-by:
Dan Carpenter <error27@gmail.com> Acked-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Julia Lawall authored
Adjust the error handling code so that it benefits from the call to mutex_unlock at the end of the function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @rcu exists@ position p1; expression E; @@ mutex_lock@p1(E); ... mutex_unlock(E); @exists@ position rcu.p1; expression E; @@ *mutex_lock@p1(E); ... when != mutex_unlock(E); ?*return ...; // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Acked-by:
-
Dan Carpenter authored
The first kfree(pDevice) is pointless because pDevice is NULL. The second kfree(pDevice) is a double free because pDevice is the driver's private data and that is already freed by free_netdev(netdev). Also the free_netdev() error path doesn't call usb_put_dev(). Signed-off-by:
-
Luis Bosch authored
Added spaces in for loop arguments. Signed-off-by:
Luis Bosch <luis.bosch@gmail.com> Signed-off-by:
-
Victor Rosales authored
Removed spaces between functions name and parenthesis. Signed-off-by:
Victor Rosales <victorhrosales@gmail.com> Signed-off-by:
-
Alejandro Emanuel Paredes authored
resolved checkpatch finding Signed-off-by:
Alejandro Emanuel Paredes <aleparedes@gmail.com> Signed-off-by:
-
Andres More authored
Removed custom macro used to test bits. Signed-off-by:
Andres More <more.andres@gmail.com> Signed-off-by:
-
Andres More authored
Removed int redefinition for function results. Signed-off-by:
-
Andres More authored
Removed some unused definitions of Ethernet packet types, also replaced two of them with in-kernel counterparts from include/linux/if_ether.h Signed-off-by:
-
Ivan Gomez Castellanos authored
The services_init() and services_exit() functions don't do anything, so they are removed, and as these are the only two functions defined in services.c and services.h, then these files are also removed. Signed-off-by:
Ivan Gomez Castellanos <ivan.gomez@ti.com> Signed-off-by:
-
Ivan Gomez Castellanos authored
So far, the cfg.c file is empty, and the function prototypes in cfg.h are not used in any place. So they can be removed. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, the cfg_set_object function has also to be removed. Since the driver object handle is retrieved from the drv_data structure, then the word "Registry" is replaced by "driver data" in the comments. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, the cfg_set_dev_object function has also to be removed. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, the cfg_get_object function has also to be removed. Since the driver object handle is retrieved from the drv_data structure, then the word "Registry" is replaced by "driver data" in the comments. Also, the hdrv_obj is not used in function omap34_xx_bridge_remove(), so it is removed. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, the cfg_get_exec_file function has also to be removed. This patch also avoids a possible NULL pointer dereference in function cfg_get_exec_file(), when drv_datap is checked for NULL and then pass drv_datap->base_img as argument to strlen(). Signed-off-by:
-
Ivan Gomez Castellanos authored
The cfg_get_dev_object function is only used in one place and because of its simplicity, it can be removed. The parameter *value can be left uninitialized if the strcmp() returns a nonzero value, so in the function dev_remove_device(), the hdev_obj could be used uninitialized and could be dereferenced in dev_destroy_device(). This patch fixes this issue, and also removes the dev_obj pointer which is not used. Signed-off-by:
-
Ivan Gomez Castellanos authored
The functions cfg_init() and cfg_exit() do nothing, so they are removed. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, this patch is needed. The function cfg_get_auto_start() only assigns a value to the flag tmp, and it is only called by the function api_init_complete2(). So the function cfg_get_auto_start() is not required. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, this patch is needed. ntfy.c only contained the function dsp_notifier_event(), and since this function calls sync_set_event(), then the dsp_notifier_event() is moved to the sync.c file. Signed-off-by:
-
Ivan Gomez Castellanos authored
As the services directory is going to be removed, the file sync.c is moved from services to core. Signed-off-by:
-
Andrea Gelmini authored
Signed-off-by:
Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by:
-
Andres More authored
Removed comments about who changed/added lines, they do not seem useful. Signed-off-by:
-
Kulikov Vasiliy authored
IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time. The semantic match that finds this problem is as follows: // <smpl> @@ identifier x; identifier request ~= "pci_request.*|pci_resource.*"; @@ ( * x->irq | * x->resource | * request(x, ...) ) ... *pci_enable_device(x) // </smpl> Signed-off-by:
Kulikov Vasiliy <segooon@gmail.com> Signed-off-by:
-
Andres More authored
Cleared checkpatch ERROR: spaces required around that '||' Signed-off-by:
-
Julia Lawall authored
list_for_each_entry binds its first argument to a non-null value, and thus any null test on the value of that argument is superfluous. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ iterator I; expression x; statement S; @@ I(x,...) { <... - if (x != NULL || ...) S ...> } // </smpl> Signed-off-by:
-
Jacob Smith authored
This patch fixes a whitespace issue detected by checkpatch.pl Signed-off-by:
Jacob Smith <tarinaky@gmail.com> Signed-off-by:
-
Larry Finger authored
Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Larry Finger authored
Signed-off-by:
Albert Wang <albert_wang@realtek.com.tw> Signed-off-by:
-
Larry Finger authored
When the driver received the Addba request frame from AP, a crash could occur. Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
There are some IOT issues when 802.11bgn mode is used to make a WEP connection. Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Krzysztof Halasa authored
This is a driver for SBE Inc.'s dual port T3/E3 WAN cards. Based on their original GPLed driver. The original driver tarball is now accessible at http://userweb.kernel.org/~chris/SBE_2T3_Linux_2.0c.tgz It needs at least a new generic HDLC setup code (not yet written) before moving to drivers/net/wan. Signed-off-by:
Krzysztof Hałasa <khc@pm.waw.pl> Signed-off-by:
-
Greg Kroah-Hartman authored
Future patches should fix this up. Cc: David Cross <david.cross@cypress.com> Signed-off-by: -
David Cross authored
This is a driver for the Cypress West Bridge companion chip. Its function is analogous to the North/South Bridges of PC environments applied to embedded devices, in that it expands I/O and storage capabilities of an embedded processor. The Astoria version, which this driver applies to, functions as a USB, embedded memory and SDIO controller. The kernel that this patch was applied to is linux-2.6.35, although it was tested using the android kernel 2.6.29 running on the Zoom 2 platform. In this system, it was used primarily as a sideloading accelerator enabling direct data transfers between a USB host PC and embedded memory without system overheads. Minor modifications were also made to the kernel for this patch. These include changes such as EXPORTing of fat_get_block in the kernel code. Another function, mpage_cleardirty was also added to the memory management code. This function is used to clear the dirty pages from a specific inode. This allows for direct, file based DMA. None of these changes are believed to have any negative impact on the kernel and may provide additional benefit for other developers and drivers. The driver, as submitted, was placed into the drivers/staging/westbridge folder as the directory structure it will eventually reside in is not yet defined. The driver, as placed in staging is divided into four parts: 1) gadget - this implements a gadget peripheral controller and includes IOCTLs for MTP transfers 2) block -this implements a generic block device driver to enable access to embedded memory 3) api -this is the Cypress SDK, and includes USB and Storage specific functions. In addition, it includes common code for low level routines such as message passing and common data transfer routines 4) hal - this should likely be included in the arch directory as it needs to be modified for a given platform. The directory structure in the staging area is meant to reflect the eventual location of where this code likely should be. It is platform specific. In this case, the HAL included is for the Android Zoom 2 platform. Here, West Bridge is connected to the GPMC (general purpose memory controller) of the OMAP3. Specific timing needs to be enabled to ensure reliable communication. Many thanks to Greg KH for conducting initial reviews and providing pointers. Please contact david.cross@cypress.com for questions, concerns or feedback. Signed-off-by:
David Cross <david.cross@cypress.com> Signed-off-by:
-
- 30 Aug, 2010 2 commits
-
-
Greg Kroah-Hartman authored
Now that we have a much better driver for this device (rtl8712), delete this driver as it is no longer needed. Cc: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: -
Larry Finger authored
When operating in normal bg mode, the maximum rate was fixed at 48 Mb/s. Signed-off-by:
-
- 29 Aug, 2010 3 commits
-
-
-
Linus Torvalds authored
-
-
