- 31 Aug, 2010 40 commits
-
-
Julia Lawall authored
The 1 element of the array is tested twice. Change the code so that the remaining 3 element of the array is tested instead of testing the 1 element a second time. The sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @expression@ expression E; @@ ( * E || ... || E | * E && ... && E ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Prashant P. Shah authored
This is a patch to the solo6010-core.c file that fixes the assignments in if condition style issues found by the checkpatch.pl tool. Signed-off-by:
Prashant P. Shah <pshah.mumbai@gmail.com> Signed-off-by:
-
Larry Finger authored
Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Alek Du authored
The config name is wrong in drivers/staging/Makefile... The object name is wrong in drivers/staging/mrst-touchscreen/Makefile... Signed-off-by:
Alek Du <alek.du@intel.com> Signed-off-by:
-
Arjan van de Ven authored
the touch screen driver tries to find a range of free channels (which are an array of bytes), by scanning for the "end of used channel" marker. however it tries to be WAAAAY too smart and does 32 bit logic on 8 bit quantities, and in the process completely gets it wrong (repeatedly read the same register instead of incrementing in the loop, assuming that if any of the 4 bytes in the 32 byte quantity is free, all four are free, returning the channel number divided by 4 rather than the actual first free channel number) On the setting side, the same mistakes are made by and large; changed this to just use the byte SCU write functions.... with these fixes we go from a completely non detected touchscreen to something that appears to completely get detected. (after also fixing the ordering issue that Jacobs patch should solve) Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Pavan Savoy authored
In order to support multiple ST platform devices, a new symbol 'st_get_plat_device' earlier needed to be exported by the arch/XX/brd-XX.c file which intends to add the ST platform device. On removing this dependency, now inside ST driver maintain the array of ST platform devices that would be registered. As of now let id=0, as and when we end up having such platforms where mutliple ST devices can exist, id would come from protocol drivers (BT, FM and GPS) as to on which platform device they want to register to. Signed-off-by:
Pavan Savoy <pavan_savoy@ti.com> Acked-by:
Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:
-
Sunny Aujla authored
This is a patch to the dt2817.c file that fixes up all coding style issues found by the checkpatch.pl tool Signed-off-by:
Sunny Aujla <sunnyfedora99@googlemail.com> Signed-off-by:
-
Neil Munro authored
I have cleaned both files inside the iface directory (fileo rtmp_pci.h and rtmp_usb.h). I am not sure about some of the changes I have made however my adjustments have solved all errors. There were also a few issues on my machine with ap.h on my machine, however I have since cleaned that too. Signed-off-by:
Neil Munro <neilmunro@gmail.com> Signed-off-by:
-
Stefan Weil authored
Obviously the wrong spelling was copied a lot of times. A similar patch for the non-staging part of linux is committed by Jiri Kosina. Cc: devel@driverdev.osuosl.org Signed-off-by:
Stefan Weil <weil@mail.berlios.de> Signed-off-by:
-
Ramkumar Ramachandra authored
Replace C99-style comments with C89-style comments, fix some typos, and fix whitespace to use only tabs. Signed-off-by:
Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by:
-
Julia Lawall authored
An error code is stored in a variable, but 0 is returned instead. Use the variable instead of 0. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by:
-
Gorskin Ilya authored
Staging: cx25821: clenup warnings found by checkpatch.pl tool in cx25821-audio-upstream.c and cx25821-audio.h. This is a patch to the cx25821-audio-upstream.c and cx25821-audio.h that fixes up a warnings found by checkpatch.pl tool. Signed-off-by:
Ilya Gorskin <Revent82@gmail.com> Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
Mike McCormack <mikem@ring3k.org> Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Make functions static and move their declarations to the top of the file. Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Randy Dunlap authored
Fix many sparse warnings about data or functions being static. Fix many sparse warnings about data or functions not being used (put them inside #if 0/#endif blocks). Fix sparse warnings about 0 being used for NULL. Fixed a small bit of source formatting when those lines were being modified anyway, but there is still lots of this yet to be done. Signed-off-by:
-
Dan Carpenter authored
copy_to_user() returns the number of bytes remaining to be copied, but we want to return a negative error code here. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Kulikov Vasiliy authored
Original code does not call sysfs_remove_group() on error. This can lead to NULL dereference. Signed-off-by:
Kulikov Vasiliy <segooon@gmail.com> Signed-off-by:
-
Kulikov Vasiliy authored
Original code doesn't call kfree(chip) on error. Signed-off-by:
-
Kulikov Vasiliy authored
If stub_probe() failed then do not increase interf_count. In original code sdev was leaked as its interf_count never reaches 0. Signed-off-by:
-
Jarod Wilson authored
On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote: > Speak of left over stuff, it's weird that I didn't notice this before > but gcc complains about an unitialized variable in > imon_incoming_packet(). > > drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’: > drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used > uninitialized in this function > > I don't know how to fix that, but it looks important. Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon driver had chunk_num = buf[7], and made much more extensive use of chunk_num. Simply removing chunk_num and using buf[7] should be fine. Signed-off-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Dan Carpenter authored
acpi_bus_register_driver() returns an int, not acpi_status. It returns zero on success and negative error codes on failure, but acpi_status is unsigned. We can just use "ret" here. Signed-off-by:
-
Dan Carpenter authored
In the original source it would write past the end of the array before returning the error code. Signed-off-by:
-
Dan Carpenter authored
In the original code there was some extra semicolons after the if statement: if (!channel_map[ieee->current_network.channel]); ^^^ >From the indenting it looked like that should be curly braces instead. Also I made some white space changes to stop checkpatch.pl from complaining. Signed-off-by:
-
Dan Carpenter authored
We never use control_req so I removed it. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Javier Martinez Canillas authored
Use DEFINE_PCI_DEVICE_TABLE() to make xgifb_pci_table const and marked as __devinitconst Signed-off-by:
Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by:
-
Javier Martinez Canillas authored
This is the first of a patch series that uses PCI_DEVICE() macro for pci table entries on comedi drivers and thus improving readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
