Skip to content

L
linux
Switch branch/tag
  1. 05 Jan, 2009 9 commits
    • Christoph Hellwig's avatar
      add a vfs_fsync helper · 4c728ef5
      Christoph Hellwig authored 
      Fsync currently has a fdatawrite/fdatawait pair around the method call,
and a mutex_lock/unlock of the inode mutex.  All callers of fsync have
to duplicate this, but we have a few and most of them don't quite get
it right.  This patch adds a new vfs_fsync that takes care of this.
It's a little more complicated as usual as ->fsync might get a NULL file
pointer and just a dentry from nfsd, but otherwise gets afile and we
want to take the mapping and file operations from it when it is there.

Notes on the fsync callers:

 - ecryptfs wasn't calling filemap_fdatawrite / filemap_fdatawait on the
   	lower file
 - coda wasn't calling filemap_fdatawrite / filemap_fdatawait on the host
	file, and returning 0 when ->fsync was missing
 - shm wasn't calling either filemap_fdatawrite / filemap_fdatawait nor
   taking i_mutex.  Now given that shared memory doesn't have disk
   backing not doing anything in fsync seems fine and I left it out of
   the vfs_fsync conversion for now, but in that case we might just
   not pass it through to the lower file at all but just call the no-op
   simple_sync_file directly.

[and now actually export vfs_fsync]
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      4c728ef5
    • Eric Paris's avatar
      sys_execve and sys_uselib do not call into fsnotify · 6110e3ab
      Eric Paris authored 
      sys_execve and sys_uselib do not call into fsnotify so inotify does not get
open events for these types of syscalls.  This patch simply makes the
requisite fsnotify calls.
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      6110e3ab
    • Al Viro's avatar
      zero i_uid/i_gid on inode allocation · 56ff5efa
      Al Viro authored 
      ... and don't bother in callers.  Don't bother with zeroing i_blocks,
while we are at it - it's already been zeroed.

i_mode is not worth the effort; it has no common default value.
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      56ff5efa
    • Al Viro's avatar
      inode->i_op is never NULL · acfa4380
      Al Viro authored 
      We used to have rather schizophrenic set of checks for NULL ->i_op even
though it had been eliminated years ago.  You'd need to go out of your
way to set it to NULL explicitly _and_ a bunch of code would die on
such inodes anyway.  After killing two remaining places that still
did that bogosity, all that crap can go away.
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      acfa4380
    • Al Viro's avatar
      ntfs: don't NULL i_op · 9742df33
      Al Viro authored 
      it's already set to empty table (and no, ntfs doesn't have any explicit
checks for NULL ->i_op or NULL ->i_fop)
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      9742df33
    • Al Viro's avatar
      isofs check for NULL ->i_op in root directory is dead code · 261964c6
      Al Viro authored 
      for one thing it never happens, for another we check that inode
is a directory right after that place anyway (and we'd already
checked that reading it from disk has not failed).
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      261964c6
    • Al Viro's avatar
      affs: do not zero ->i_op · c765d479
      Al Viro authored 
      it is already set to empty table and should never be NULL
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      c765d479
    • Dmitri Monakhov's avatar
      kill suid bit only for regular files · 7f5ff766
      Dmitri Monakhov authored 
      We don't have to do it because it is useless for non regular files.
In fact block device may trigger this path without dentry->d_inode->i_mutex.

(akpm: concerns were expressed (by me) about S_ISDIR inodes)
Signed-off-by: default avatarDmitri Monakhov <dmonakhov@openvz.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      7f5ff766
    • Alain Knaff's avatar
      vfs: lseek(fd, 0, SEEK_CUR) race condition · 5b6f1eb9
      Alain Knaff authored 
      This patch fixes a race condition in lseek. While it is expected that
unpredictable behaviour may result while repositioning the offset of a
file descriptor concurrently with reading/writing to the same file
descriptor, this should not happen when merely *reading* the file
descriptor's offset.

Unfortunately, the only portable way in Unix to read a file
descriptor's offset is lseek(fd, 0, SEEK_CUR); however executing this
concurrently with read/write may mess up the position.

[with fixes from akpm]
Signed-off-by: default avatarAlain Knaff <alain@knaff.lu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      5b6f1eb9
  3. 03 Jan, 2009 31 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7