- 17 Mar, 2020 26 commits
-
-
Lourdes Pedrajas authored
Remove spaces after type casting operators in order to comply codding standards. Issue found with checkpatch. Signed-off-by:
Lourdes Pedrajas <lu@pplo.net> Link: https://lore.kernel.org/r/20200315044922.14249-1-lu@pplo.netReviewed-by:
Stefano Brivio <sbrivio@redhat.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sergio Paracuellos authored
After review all the resets at the beggining the function 'mt7621_reset_port' is not needed anymore. Hence delete it and its uses. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20200313200913.24321-7-sergio.paracuellos@gmail.comSigned-off-by:
-
Sergio Paracuellos authored
R3G's LEDs fail to initialize because one of them uses GPIO8 Hence, release the GPIO resources after PCIe initialization and properly release also in driver error path. Signed-off-by:
-
Sergio Paracuellos authored
Properly update bindings documentation with added 'reset-gpios' property. Delete also 'perst-gpio' which is not being used anymore. Signed-off-by:
-
Sergio Paracuellos authored
Properly set pins for group pcie as 'gpio' function and declare gpio's in the pci node to make reset stuff properly functional. Delete no more needed general reset and previous pers gpio which is now being used in 'reset-gpios' property. Signed-off-by:
-
Sergio Paracuellos authored
Value of 'PERST_DELAY_MS' is too high and it is ok just to set up to 100 ms. Update also define name from 'PERST_DELAY_US' into 'PERST_DELAY_MS' Signed-off-by:
-
Sergio Paracuellos authored
Original driver code was using three gpio's for reset asserts and deasserts the pcis. Instead of using that a general reset control with a perst gpio was introduced and it seems it is partially working but sometimes there are some unexpected hangs on boot. This commit make use of the three original gpios using 'reset-gpios' property of the device tree and removes the reset line and perst gpio. According to the mediatek aplication note v0.1 there are three gpios used for pcie ports reset control: gpio#19, gpio#8 and gpio#7 for slots 0, 1 and 2 respectively. This schema can be used separately for mt7621A but in some boards due to pin share issue, if the PCM and I2S function are enable at the same time, there are no enough GPIO to control per-port PCIe reset. In those cases gpio#19 is enought for reset the three ports together. Because of this we just try to get the three gpios but if some of them fail we are not failing in boot process, just prints a kernel notice and take after into account if the descriptor is or not valid in order to use it. All of them are set as GPIO output low configuration. The gpio descriptor's API takes device tree property into account and invert value if the pin is configured as active low. So we also have to properly request pins from device tree and set values correct in assert and deassert functions. After this changes the order to make all assert and deassert in the 'probe' process makes more sense: * Parse device tree. * make assert of the RC's and EP's before doing anything else. * make deassert of the RC's before initializing the phy. * Init the phy. * make deassert of the EP's before initialize pci ports. * Normal PCI initialization. Signed-off-by:
-
Stefan Wahren authored
The initializer lists for the V4L2 controls are hard to read. So improve this by using designators. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Reviewed-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Link: https://lore.kernel.org/r/1584049059-6772-3-git-send-email-stefan.wahren@i2se.comSigned-off-by:
-
Stefan Wahren authored
The struct bm2835_mmal_v4l2_ctrl contains an ignore_errors flag which was always set to false. So drop the unused flag. Signed-off-by:
-
Camylla Goncalves Cantanheide authored
The variables of function setKey triggered a 'Avoid CamelCase' warning from checkpatch.pl. This patch renames these variables to correct this warning. Signed-off-by:
Camylla Goncalves Cantanheide <c.cantanheide@gmail.com> Link: https://lore.kernel.org/r/20200317085130.21213-2-c.cantanheide@gmail.comSigned-off-by:
-
Camylla Goncalves Cantanheide authored
Solves the following checkpatch.pl for a triggered function: WARNING: Prefer using '"%s...", __func__' to using 'setKey', this function's name, in a string Signed-off-by:
-
Camylla Goncalves Cantanheide authored
Solves following checkpatch.pl issue: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by:
-
Lourdes Pedrajas authored
Remove unused pointers in gb_i2c_algorithm structure and gb_i2c_probe() function, as they are not touched since 2014. Suggested-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Link: https://lore.kernel.org/r/20200312190349.7892-1-lu@pplo.netSigned-off-by:
-
Deepak R Varma authored
Put parentheses around uses of macro parameters to avoid possible precedence issues. Problem detected by checkpatch. Signed-off-by:
Deepak R Varma <mh12gx2825@gmail.com> Reviewed-by:
-
Deepak R Varma authored
An array index is being computed by mathematical calculation on the Lvalue side of the expression. This also further results in the statement exceeding 80 character statement length. A local variable can store the value of the array index computation. The variable can then be used as array index. This improves readability of the code and also address 80 character warning raised by checkpatch. Signed-off-by:
-
Deepak R Varma authored
Multiple macro definitions crossing 80 character line length makes them hard to understand. Reformatting the these lines makes the code more readable and easier to understand. Issue flagged by checkpatch script. Signed-off-by:
-
Deepak R Varma authored
A long variable name beyond 80 characters extends into the next line. Reformatting the line makes it more readable. Also adding an extra line for the next instruction following current if block helps understand it better. Signed-off-by:
-
Shreeya Patel authored
Remove if and else conditions since both are leading to the initialization of "valueDMATimeout" and "valueDMAPageCount" with the same value. Found using coccinelle script. Signed-off-by:
Shreeya Patel <shreeya.patel23498@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20200313104920.19974-1-shreeya.patel23498@gmail.comSigned-off-by:
-
Shreeya Patel authored
Remove unnecessary if and else conditions since both are leading to the initialization of "phtpriv->ampdu_enable" with the same value. Also, remove the unnecessary else-if condition since it does nothing. Signed-off-by:
-
Deepak R Varma authored
Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem detected by checkpatch. Signed-off-by:
-
Deepak R Varma authored
Remove two if# 0 directive code blocks. Problem detected by checkpatch script. Signed-off-by:
-
Deepak R Varma authored
Resolve general code indentation problems as detected by checkpatch script. Implement code reformat and re-indentation as per coding style to improve readability. Signed-off-by:
-
Deepak R Varma authored
Reformat function call arguments to comedi_check_trigger_arg_min as per coding style guideline. Problem detected by checkpatch script. Signed-off-by:
-
Deepak R Varma authored
Reformat multi-line dereferencing of function arguments &cmd->scan_begin_arg. Problem detected by checkpatch script. Signed-off-by:
-
Deepak R Varma authored
Reformat function call arguments so that the function call is clearly visible. Issue detected by checkpatch. Signed-off-by:
-
Oscar Carter authored
Replace the bit left shift operation with the BIT_ULL() macro and remove the unnecessary mask off operation against the bit_nr variable. This mask is only there for legacy reasons. Originally it was 31 (0x1f) and the bit_nr variable spread across an mc_filter array with two u32 elements. Now, this mask is not needed because its value is 0x3f and the mc_filter variable is an u64 type. In this situation, the 26 bit right shift operation against the value returned by the ether_crc function set the bit_nr variable to the following value: bit 31 to bit 6 -> All 0 (due to the bit shift operation happens over an unsigned type). bit 5 to bit 0 -> The 6 msb bits of the value returned by the ether_crc function. The purpose of the 0x3f mask against the bit_nr variable is to reset (set to 0) the 26 msb bits (bit 31 to bit 6), but these bits are yet 0. So, the mask off operation is now unnecessary. Signed-off-by:
Oscar Carter <oscar.carter@gmx.com> Link: https://lore.kernel.org/r/20200314161441.4870-1-oscar.carter@gmx.comSigned-off-by:
-
- 12 Mar, 2020 9 commits
-
-
R Veera Kumar authored
Fixes for simple typos in C comments. Found using checkpatch.pl. Signed-off-by:
R Veera Kumar <vkor@vkten.in> Link: https://lore.kernel.org/r/20200312091042.GA4246@tulip.localSigned-off-by:
-
Shreeya Patel authored
Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by:
-
Takashi Iwai authored
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by:
Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20200311092451.23933-4-tiwai@suse.deSigned-off-by:
-
Takashi Iwai authored
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by:
-
Takashi Iwai authored
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by:
-
Takashi Iwai authored
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by:
-
Ajay Singh authored
Merged the DT binding documentation of SDIO and SPI into a single file. Removed documentation for some of the properties which are not required and handled review comments received in [1] & [2]. [1]. https://lore.kernel.org/linux-wireless/20200303020230.GA15543@bogus [2]. https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogusSigned-off-by:
Ajay Singh <ajay.kathat@microchip.com> Link: https://lore.kernel.org/r/20200307085523.7320-4-ajay.kathat@microchip.comSigned-off-by:
-
Ajay Singh authored
Modified the 'clock-names' property by removing '_clk' from its name and remove '_spi/sdio' from 'compatible' string. Signed-off-by:
-
Ajay Singh authored
Make use of 'interrupts' property instead of using gpio for handling the interrupt as suggested in [1]. [1]. https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogusSigned-off-by:
-
- 11 Mar, 2020 5 commits
-
-
Carlos Henrique Lima Melara authored
Fixed WARNING: Missing a blank line after declarations in qlge_mpi.c to the following lines: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:94: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:240: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:258: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:356: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:915: WARNING: Missing a blank line after declarations FILE: drivers/staging/qlge/qlge_mpi.c:1099: Signed-off-by:
Carlos Henrique Lima Melara <charlesmelara@outlook.com> Link: https://lore.kernel.org/r/CP2PR80MB434086A44A1ED5BB662B9D70A8FC0@CP2PR80MB4340.lamprd80.prod.outlook.comSigned-off-by:
-
Andre Pinto authored
Fix checkpatch check: 'informations' may be misspelled - perhaps 'information'? in rtw_mlme_ext.c:1151. Signed-off-by:
Andre Pinto <andrealmeidap1996@gmail.com> Link: https://lore.kernel.org/r/20200311012638.18889-1-andrealmeidap1996@gmail.comSigned-off-by:
-
Lourdes Pedrajas authored
Improve line grouping for better understanding the course of action and where every comment belongs to. Signed-off-by:
-
Lourdes Pedrajas authored
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but this feature it is marked TODO in 2014 and did go untouched since 2015. Signed-off-by:
-
Sergio Paracuellos authored
The clock related code concerns me from the very beginning because there are some set ups got from legacy driver that are not documented anywhere. According to the programming guide 0x7c is 'CPE_ROSC_SEL1' register and 0x80 is 'CPU_CPE_CN'. I do think this set up is not needed at all and the proper thing to do is just enable the clock bit for each pcie port. Hence remove useless code and do the right thing which is setting up the clock bit for each port enabled. Signed-off-by:
-
