1. 14 Mar, 2018 5 commits
    • Colin Ian King's avatar
      staging: comedi: adl_pci6208: remove redundant initialization of 'val' · b8461ff7
      Colin Ian King authored
      Variable 'val' is initialized with a value that is never read, it is
      updated with a new value again after intitialization. Remove the
      redundant initialization and move the declaration and assignment into
      the scope of the for-loop.
      
      Cleans up clang warning:
      drivers/staging/comedi/drivers/adl_pci6208.c:61:15: warning: Value
      stored to 'val' during its initialization is never read
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b8461ff7
    • Sergio Paracuellos's avatar
      staging: ks7010: replace custom rotation operations in favour of the kernel ones · 8b6f0537
      Sergio Paracuellos authored
      This patch replaces custom ROR32 and ROL32 macros for the ones included in
      bitops header of the linux kernel.
      Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8b6f0537
    • Arnd Bergmann's avatar
      staging: lustre: fid: avoid false-positive uninitialized variable warning · ae91ce5d
      Arnd Bergmann authored
      One of Neil's recent cleanups apparently has led the code to get
      to a state where gcc tracks the 'seqnr' variable just enough to
      see that it is sometimes initialized in seq_client_alloc_seq(),
      but not enough that it can prove this initialization to be reliable
      before the use of that variable:
      
      drivers/staging/lustre/lustre/fid/fid_request.c: In function 'seq_client_alloc_fid':
      drivers/staging/lustre/lustre/fid/fid_request.c:245:22: error: 'seqnr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      
      The code seems to be otherwise correct, and I could not come
      up with a good way to simplify it further, so this adds a fake
      initialization to shut up that warning.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarNeilBrown <neilb@suse.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ae91ce5d
    • Arnd Bergmann's avatar
      staging: lustre: use module_name() macro for debug printf · 7a76eaf4
      Arnd Bergmann authored
      We now allow lustre to be built when CONFIG_MODULES is disabled,
      but that causes a build failure:
      
      In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:42,
                       from drivers/staging/lustre/lustre/obdclass/lu_object.c:44:
      drivers/staging/lustre/lustre/obdclass/lu_object.c: In function 'lu_context_key_degister':
      drivers/staging/lustre/lustre/obdclass/lu_object.c:1410:51: error: dereferencing pointer to incomplete type 'struct module'
      
      This particular case can be avoided by using the module_name()
      macro that was designed exactly to handle printing the name of
      a module in all configurations.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarNeilBrown <neilb@suse.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7a76eaf4
    • Greg Kroah-Hartman's avatar
      Merge tag 'iio-for-4.17b' of... · 6761f0ac
      Greg Kroah-Hartman authored
      Merge tag 'iio-for-4.17b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next
      
      Jonathan writes:
      
      Second set of new device support, features and cleanup for IIO in the 4.17 cycle
      
      The uptick in staging cleanup is partly due to GSoC Applications
      process being underway and one of Daniel's tasks being to try
      cleaning up an IIO driver to move out of staging.
      Naturally there is some normal staging cleanup progress in here
      as well.
      
      New device support
      * Microchip mcp4018
        - New driver supproting MCP4017, MCP4018 and MCP4019 digital pots.
      * On Semiconductor lv0104cs
        - New driver to support this ambient light sensor.
      
      Cleanup
      * axp20x_adc
        - remove a !! in favour of clear ternary operator.
      * ad2s1210 (staging cleanup)
        - Reorganise to avoid ending a line with [
        - Remove some unnecessary defines.
        - Remove unsed variable.
      * ad5380
        - Replace magic 0 with IIO_CHAN_INFO_RAW
      * ad5764
        - Replace magic 0 with IIO_CHA_INFO_RAW
      * ad7150 (staging cleanup)
        - Align arguements with parenthesis.
      * ad7152 (staging cleanup)
        - Align arguements.
      * ad7746 (staging cleanup)
        - Align arguements.
      * ad7816
        - Remove pointless void pointer cast.
      * ade7753
        - Replace IIO_DEV_ATTR_CH_OFF with equivalent to avoid confusing
          checkpatch (this macro didn't really help anyway).  Also drop the
          macro from the meter.h header.
      * ade7754 (staging cleanup)
        - Add names to funciton definition arguements.
        - Align arguements with open parenthesis where possible.
      * ade7758 (staging cleanup)
        - Remove __func__ from dev_dbg statements as provided by dynamic
          debug anyway.
        - Align arguements with open parenthesis where possible.
      * ade7759 (staging cleanup)
        - Replace IIO_DEV_ATTR_CH_OFF with equiavalent to avoid confusing
          checkpatch.
      * adis16201 (staging cleanup)
        - Headers in alphabetical order.
        - Blank lines before returns.
      * adis16209 (staging cleanup)
        - Headers in alphabetical order
        - Change some definition names to make them more meaningful (2 rounds
          of this).
        - Add explicit _REG prefix to register names to make them
          obviously different from fields within those registers.
        - Remove some superflous comments and group definitions better.
        - Use a switch statement to make it semantically obvious that we
          only have two options (rather than an unlimited 'else').
        - Use sign_extent32 instead of open coding.
      * adt7316 (staging cleanup)
        - Move an export next to symbol.
      * bmc150
        - drop redundant __func__ in dynamic debug.
      * ccs811
        - Rename varaible to better reflect what it does.
      * cros_ec
        - Reduce sampling frequency before suspending to avoid preventing
          suspend.
      * dummy
        - Correct whitespace in Kconfig.
        - Add extra description in Kconfig.
      * ds1803
        - Remove a VLA which we always know is 2 long.
      * hid-sensor-accel
        - Replace magic number 0 by IIO_CHAN_INFO_RAW.
      * hid-sensor-gyro
        - Replace magic number 0 by IIO_CHAN_INFO_RAW.
      * hid-sensor-light
        - Replace magic number 0 by IIO_CHAN_INFO_RAW.
      * hid-sensor-magn
        - Replace magic number 0 by IIO_CHAN_INFO_RAW.
      * lm3533
        - Replace magic number 0 by IIO_CHAN_INFO_RAW
      * mlx90632
        - Squash a smatch warning - no runtime effect.
      * stm32_dfsdm:
        - Cleanup the dt bindings.
      * sx9500
        - Add GPIO ACPI mapping table to behave correctly when firmware
          doesn't provide the mapping.
      * tsl2x7x (staging cleanup)
        - Fix the proximity sensor functionality.
        - Remove platform data provided power functions.  There are much
          better ways to do this these days.
        - Introduce some common functions to avoid various repititions.
        - Stop using mutex_trylock when mutex_lock and wait a bit is fine.
        - Improve error handling in various places.
        - Drop some 'Camel case' (which wasn't actually strickly camel case
          but was a bit odd.
        - Drop some _available sysfs attributes for things that don't exist
          (for particular supported parts).
      6761f0ac
  2. 12 Mar, 2018 2 commits
  3. 10 Mar, 2018 20 commits
  4. 08 Mar, 2018 10 commits
  5. 07 Mar, 2018 3 commits