• Marko Mäkelä's avatar
    MDEV-15326/MDEV-16136 dead code removal · 25af2a18
    Marko Mäkelä authored
    Revert part of fa2a74e0.
    
    trx_reference(): Remove, and merge the relevant part to the only caller
    trx_rw_is_active(). If the statements trx = NULL; were ever executed,
    the function would have dereferenced a NULL pointer and crashed in
    trx_mutex_exit(trx). Hence, those statements must have been unreachable,
    and they can be replaced with debug assertions.
    
    trx_rw_is_active(): Avoid unnecessary acquisition and release of trx->mutex
    when do_ref_count=false.
    
    lock_trx_release_locks(): Do not reset trx->id=0. Had the statement been
    necessary, we would have experienced crashes in trx_reference().
    25af2a18
trx0sys.ic 12.5 KB