• Alfranio Correia's avatar
    WL#4828 and BUG#45747 · 5280dc82
    Alfranio Correia authored
    NOTE: Backporting the patch to next-mr.
    
    WL#4828 Augment DBUG_ENTER/DBUG_EXIT to crash MySQL in different functions
    -------
    
    The assessment of the replication code in the presence of faults is extremely
    import to increase reliability. In particular, one needs to know if servers
    will either correctly recovery or print out appropriate error messages thus
    avoiding unexpected problems in a production environment.
    
    In order to accomplish this, the current patch refactories the debug macros
    already provided in the source code and introduces three new macros that
    allows to inject faults, specifically crashes, while entering or exiting a
    function or method. For instance, to crash a server while returning from
    the init_slave function (see module sql/slave.cc), one needs to do what
    follows:
    
    1 - Modify the source replacing DBUG_RETURN by DBUG_CRASH_RETURN;
    
      DBUG_CRASH_RETURN(0);
    
    2 - Use the debug variable to activate dbug instructions:
    
      SET SESSION debug="+d,init_slave_crash_return";
    
    The new macros are briefly described below:
    
    DBUG_CRASH_ENTER (function) is equivalent to DBUG_ENTER which registers the
    beginning of a function but in addition to it allows for crashing the server
    while entering the function if the appropriate dbug instruction is activate.
    In this case, the dbug instruction should be "+d,function_crash_enter".
    
    DBUG_CRASH_RETURN (value) is equivalent to DBUG_RETURN which notifies the
    end of a function but in addition to it allows for crashing the server
    while returning from the function if the appropriate dbug instruction is
    activate. In this case, the dbug instruction should be
    "+d,function_crash_return". Note that "function" should be the same string
    used by either the DBUG_ENTER or DBUG_CRASH_ENTER.
    
    DBUG_CRASH_VOID_RETURN (value) is equivalent to DBUG_VOID_RETURN which
    notifies the end of a function but in addition to it allows for crashing
    the server while returning from the function if the appropriate dbug
    instruction is activate. In this case, the dbug instruction should be
    "+d,function_crash_return". Note that "function" should be the same string
    used by either the DBUG_ENTER or DBUG_CRASH_ENTER.
    
    To inject other faults, for instance, wrong return values, one should rely
    on the macros already available. The current patch also removes a set of
    macros that were either not being used or were redundant as other macros
    could be used to provide the same feature. In the future, we also consider
    dynamic instrumentation of the code.
    
    
    BUG#45747 DBUG_CRASH_* is not setting the strict option
    ---------
          
    When combining DBUG_CRASH_* with "--debug=d:t:i:A,file" the server crashes
    due to a call to the abort function in the DBUG_CRASH_* macro althought the
    appropriate keyword has not been set.
    5280dc82
dbug.c 62.1 KB