Commit 1bb7a314 authored by Sergey Petrunya's avatar Sergey Petrunya

Fix buildbot failure in previous fix (BUG#861147):

- convert_subq_to_jtbm() should always restore the used arena.
parent a1407197
...@@ -858,14 +858,14 @@ bool convert_join_subqueries_to_semijoins(JOIN *join) ...@@ -858,14 +858,14 @@ bool convert_join_subqueries_to_semijoins(JOIN *join)
in_subq->unit->first_select()->join->table_count >= MAX_TABLES) in_subq->unit->first_select()->join->table_count >= MAX_TABLES)
break; break;
if (convert_subq_to_sj(join, in_subq)) if (convert_subq_to_sj(join, in_subq))
DBUG_RETURN(TRUE); goto restore_arena_and_fail;
} }
else else
{ {
if (join->table_count + 1 >= MAX_TABLES) if (join->table_count + 1 >= MAX_TABLES)
break; break;
if (convert_subq_to_jtbm(join, in_subq, &remove_item)) if (convert_subq_to_jtbm(join, in_subq, &remove_item))
DBUG_RETURN(TRUE); goto restore_arena_and_fail;
} }
if (remove_item) if (remove_item)
{ {
...@@ -874,7 +874,7 @@ bool convert_join_subqueries_to_semijoins(JOIN *join) ...@@ -874,7 +874,7 @@ bool convert_join_subqueries_to_semijoins(JOIN *join)
Item *replace_me= in_subq->original_item(); Item *replace_me= in_subq->original_item();
if (replace_where_subcondition(join, tree, replace_me, new Item_int(1), if (replace_where_subcondition(join, tree, replace_me, new Item_int(1),
FALSE)) FALSE))
DBUG_RETURN(TRUE); /* purecov: inspected */ goto restore_arena_and_fail;
} }
} }
//skip_conversion: //skip_conversion:
...@@ -951,6 +951,11 @@ bool convert_join_subqueries_to_semijoins(JOIN *join) ...@@ -951,6 +951,11 @@ bool convert_join_subqueries_to_semijoins(JOIN *join)
thd->restore_active_arena(arena, &backup); thd->restore_active_arena(arena, &backup);
join->select_lex->sj_subselects.empty(); join->select_lex->sj_subselects.empty();
DBUG_RETURN(FALSE); DBUG_RETURN(FALSE);
restore_arena_and_fail:
if (arena)
thd->restore_active_arena(arena, &backup);
DBUG_RETURN(TRUE);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment