Commit 33131c9e authored by unknown's avatar unknown

calloc replaced with alloc in st_select_lex_node 'new' operator (SCRUM?)


sql/sql_lex.cc:
  initialization of all need field
sql/sql_lex.h:
  calloc replaced with alloc
sql/sql_parse.cc:
  no need full initialization here
sql/sql_yacc.yy:
  removed initialization which will be done in init_qiery method
parent 64d48cd6
......@@ -999,6 +999,8 @@ int yylex(void *arg, void *yythd)
void st_select_lex_node::init_query()
{
options= 0;
linkage= UNSPECIFIED_TYPE;
no_table_names_allowed= uncacheable= dependent= 0;
ref_pointer_array= 0;
}
......@@ -1016,8 +1018,8 @@ void st_select_lex_node::init_select()
void st_select_lex_unit::init_query()
{
linkage= GLOBAL_OPTIONS_TYPE;
st_select_lex_node::init_query();
linkage= GLOBAL_OPTIONS_TYPE;
global_parameters= this;
select_limit_cnt= HA_POS_ERROR;
offset_limit_cnt= 0;
......@@ -1031,11 +1033,10 @@ void st_select_lex_unit::init_query()
void st_select_lex::init_query()
{
st_select_lex_node::init_query();
table_list.elements= 0;
table_list.first= 0;
table_list.next= (byte**) &table_list.first;
table_list.empty();
item_list.empty();
join= 0;
where= 0;
olap= UNSPECIFIED_OLAP_TYPE;
having_fix_field= 0;
with_wild= 0;
......@@ -1044,11 +1045,15 @@ void st_select_lex::init_query()
void st_select_lex::init_select()
{
st_select_lex_node::init_select();
group_list.elements= 0;
group_list.first= 0;
group_list.next= (byte**) &group_list.first;
group_list.empty();
type= db= db1= table1= db2= table2= 0;
having= 0;
group_list.empty();
use_index_ptr= ignore_index_ptr= 0;
table_join_options= 0;
in_sum_expr= with_wild= 0;
options= 0;
where= having= 0;
braces= 0;
when_list.empty();
expr_list.empty();
interval_list.empty();
......
......@@ -221,8 +221,7 @@ class st_select_lex_node {
static void *operator new(size_t size)
{
// TODO: Change to alloc() and explicitely clear elements in constructors
return (void*) sql_calloc((uint) size);
return (void*) sql_alloc((uint) size);
}
static void operator delete(void *ptr,size_t size) {}
st_select_lex_node(): linkage(UNSPECIFIED_TYPE) {}
......
......@@ -3316,7 +3316,7 @@ void mysql_init_multi_delete(LEX *lex)
lex->select_lex.select_limit= lex->unit.select_limit_cnt=
HA_POS_ERROR;
lex->auxilliary_table_list= lex->select_lex.table_list;
lex->select_lex.init_query();
lex->select_lex.table_list.empty();
}
......
......@@ -3361,7 +3361,6 @@ delete:
{
LEX *lex= Lex;
lex->sql_command= SQLCOM_DELETE;
lex->select_lex.options= 0;
lex->lock_option= lex->thd->update_lock_default;
lex->select_lex.init_order();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment