Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
417669f9
Commit
417669f9
authored
Nov 12, 2007
by
svoj@mysql.com/june.mysql.com
Browse files
Options
Browse Files
Download
Plain Diff
Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.0
into mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-4.0
parents
2bced229
d06e2f92
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
28 additions
and
1 deletion
+28
-1
mysql-test/r/symlink.result
mysql-test/r/symlink.result
+6
-0
mysql-test/t/symlink.test
mysql-test/t/symlink.test
+12
-0
mysys/my_symlink2.c
mysys/my_symlink2.c
+10
-1
No files found.
mysql-test/r/symlink.result
View file @
417669f9
...
...
@@ -84,3 +84,9 @@ t1 CREATE TABLE `t1` (
`b` int(11) default NULL
) TYPE=MyISAM
drop table t1;
CREATE TABLE t1(a INT)
DATA DIRECTORY='TEST_DIR/var/master-data/mysql'
INDEX DIRECTORY='TEST_DIR/var/master-data/mysql';
RENAME TABLE t1 TO user;
Can't create/write to file 'TEST_DIR/var/master-data/mysql/user.MYI' (Errcode: 17)
DROP TABLE t1;
mysql-test/t/symlink.test
View file @
417669f9
...
...
@@ -112,3 +112,15 @@ eval alter table t1 index directory="$MYSQL_TEST_DIR/var/log";
enable_query_log
;
show
create
table
t1
;
drop
table
t1
;
#
# BUG#32111 - Security Breach via DATA/INDEX DIRECORY and RENAME TABLE
#
--
replace_result
$MYSQL_TEST_DIR
TEST_DIR
eval
CREATE
TABLE
t1
(
a
INT
)
DATA
DIRECTORY
=
'$MYSQL_TEST_DIR/var/master-data/mysql'
INDEX
DIRECTORY
=
'$MYSQL_TEST_DIR/var/master-data/mysql'
;
--
replace_result
$MYSQL_TEST_DIR
TEST_DIR
--
error
1
RENAME
TABLE
t1
TO
user
;
DROP
TABLE
t1
;
mysys/my_symlink2.c
View file @
417669f9
...
...
@@ -120,6 +120,7 @@ int my_rename_with_symlink(const char *from, const char *to, myf MyFlags)
int
was_symlink
=
(
!
my_disable_symlinks
&&
!
my_readlink
(
link_name
,
from
,
MYF
(
0
)));
int
result
=
0
;
int
name_is_different
;
DBUG_ENTER
(
"my_rename_with_symlink"
);
if
(
!
was_symlink
)
...
...
@@ -128,6 +129,14 @@ int my_rename_with_symlink(const char *from, const char *to, myf MyFlags)
/* Change filename that symlink pointed to */
strmov
(
tmp_name
,
to
);
fn_same
(
tmp_name
,
link_name
,
1
);
/* Copy dir */
name_is_different
=
strcmp
(
link_name
,
tmp_name
);
if
(
name_is_different
&&
!
access
(
tmp_name
,
F_OK
))
{
my_errno
=
EEXIST
;
if
(
MyFlags
&
MY_WME
)
my_error
(
EE_CANTCREATEFILE
,
MYF
(
0
),
tmp_name
,
EEXIST
);
DBUG_RETURN
(
1
);
}
/* Create new symlink */
if
(
my_symlink
(
tmp_name
,
to
,
MyFlags
))
...
...
@@ -139,7 +148,7 @@ int my_rename_with_symlink(const char *from, const char *to, myf MyFlags)
the same basename and different directories.
*/
if
(
strcmp
(
link_name
,
tmp_name
)
&&
my_rename
(
link_name
,
tmp_name
,
MyFlags
))
if
(
name_is_different
&&
my_rename
(
link_name
,
tmp_name
,
MyFlags
))
{
int
save_errno
=
my_errno
;
my_delete
(
to
,
MyFlags
);
/* Remove created symlink */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment