Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
61864021
Commit
61864021
authored
May 24, 2010
by
Sergey Petrunya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Code cleanup, remove junk comments
parent
3f595889
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
22 deletions
+1
-22
sql/item_subselect.cc
sql/item_subselect.cc
+0
-3
sql/opt_subselect.cc
sql/opt_subselect.cc
+1
-1
sql/sql_select.cc
sql/sql_select.cc
+0
-18
No files found.
sql/item_subselect.cc
View file @
61864021
...
@@ -727,9 +727,6 @@ Item_singlerow_subselect::select_transformer(JOIN *join)
...
@@ -727,9 +727,6 @@ Item_singlerow_subselect::select_transformer(JOIN *join)
void
Item_singlerow_subselect
::
store
(
uint
i
,
Item
*
item
)
void
Item_singlerow_subselect
::
store
(
uint
i
,
Item
*
item
)
{
{
row
[
i
]
->
store
(
item
);
row
[
i
]
->
store
(
item
);
//psergey-merge: can do without that: row[i]->cache_value();
//psergey-backport-timours: ^ really, without that ^
//psergey-try-merge-again:
row
[
i
]
->
cache_value
();
row
[
i
]
->
cache_value
();
}
}
...
...
sql/opt_subselect.cc
View file @
61864021
...
@@ -1159,7 +1159,7 @@ static bool convert_subq_to_jtbm(JOIN *parent_join,
...
@@ -1159,7 +1159,7 @@ static bool convert_subq_to_jtbm(JOIN *parent_join,
parent_join
->
select_lex
->
where
=
parent_join
->
conds
;
parent_join
->
select_lex
->
where
=
parent_join
->
conds
;
}
}
/* Don't unlink the child
, the subquery is still there and used
*/
/* Don't unlink the child
subselect, as the subquery will be used.
*/
DBUG_RETURN
(
FALSE
);
DBUG_RETURN
(
FALSE
);
}
}
...
...
sql/sql_select.cc
View file @
61864021
...
@@ -4743,18 +4743,6 @@ best_access_path(JOIN *join,
...
@@ -4743,18 +4743,6 @@ best_access_path(JOIN *join,
}
}
else
else
{
{
#if 0
/* Estimate cost of reading table. */
if (jtbm_subselect) //psergey-jtbm-todo: why the difference?
tmp= s->read_time;
else
tmp= s->table->file->scan_time();
//psergey-debug:
if (!jtbm_subselect && fabs(s->read_time - s->table->file->scan_time()) > 1.0)
{
fprintf(stderr, "Q:%s\n", thd->query());
}
#endif
tmp
=
s
->
read_time
;
tmp
=
s
->
read_time
;
if
((
s
->
table
->
map
&
join
->
outer_join
)
||
disable_jbuf
)
// Can't use join cache
if
((
s
->
table
->
map
&
join
->
outer_join
)
||
disable_jbuf
)
// Can't use join cache
{
{
...
@@ -9909,16 +9897,10 @@ static uint reset_nj_counters(JOIN *join, List<TABLE_LIST> *join_list)
...
@@ -9909,16 +9897,10 @@ static uint reset_nj_counters(JOIN *join, List<TABLE_LIST> *join_list)
if
((
nested_join
=
table
->
nested_join
))
if
((
nested_join
=
table
->
nested_join
))
{
{
nested_join
->
counter
=
0
;
nested_join
->
counter
=
0
;
//nested_join->n_tables= my_count_bits(nested_join->used_tables &
// ~join->eliminated_tables);
nested_join
->
n_tables
=
reset_nj_counters
(
join
,
&
nested_join
->
join_list
);
nested_join
->
n_tables
=
reset_nj_counters
(
join
,
&
nested_join
->
join_list
);
if
(
!
nested_join
->
n_tables
)
if
(
!
nested_join
->
n_tables
)
is_eliminated_nest
=
TRUE
;
is_eliminated_nest
=
TRUE
;
}
}
//if (!table->table || (table->table->map & ~join->eliminated_tables))
//psergey-merge10^
//if (!table->table && (table->table->map & ~join->eliminated_tables))
//psergey-merge11^
if
((
!
table
->
table
&&
!
is_eliminated_nest
)
||
if
((
!
table
->
table
&&
!
is_eliminated_nest
)
||
(
table
->
table
&&
(
table
->
table
->
map
&
~
join
->
eliminated_tables
)))
(
table
->
table
&&
(
table
->
table
->
map
&
~
join
->
eliminated_tables
)))
n
++
;
n
++
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment