Commit 704ef98d authored by Marko Mäkelä's avatar Marko Mäkelä

Merge 10.2 into 10.3

parents 49680497 bcc26dce
...@@ -3975,32 +3975,32 @@ sub run_testcase ($$) { ...@@ -3975,32 +3975,32 @@ sub run_testcase ($$) {
} }
my $test= $tinfo->{suite}->start_test($tinfo); my $test= $tinfo->{suite}->start_test($tinfo);
# Set to a list of processes we have to keep waiting (expectedly died servers) # Set only when we have to keep waiting after expectedly died server
my %keep_waiting_proc = (); my $keep_waiting_proc = 0;
my $print_timeout= start_timer($print_freq * 60); my $print_timeout= start_timer($print_freq * 60);
while (1) while (1)
{ {
my $proc; my $proc;
if (scalar(keys(%keep_waiting_proc)) > 0) if ($keep_waiting_proc)
{ {
# Any other process exited? # Any other process exited?
$proc = My::SafeProcess->check_any(); $proc = My::SafeProcess->check_any();
if ($proc) if ($proc)
{ {
mtr_verbose ("Found exited process $proc"); mtr_verbose ("Found exited process $proc");
$keep_waiting_proc{$proc} = 1;
} }
else else
{ {
$proc = $keep_waiting_proc;
# Also check if timer has expired, if so cancel waiting # Also check if timer has expired, if so cancel waiting
if ( has_expired($test_timeout) ) if ( has_expired($test_timeout) )
{ {
%keep_waiting_proc = (); $keep_waiting_proc = 0;
} }
} }
} }
if (scalar(keys(%keep_waiting_proc)) == 0) if (! $keep_waiting_proc)
{ {
if($test_timeout > $print_timeout) if($test_timeout > $print_timeout)
{ {
...@@ -4017,19 +4017,19 @@ sub run_testcase ($$) { ...@@ -4017,19 +4017,19 @@ sub run_testcase ($$) {
else else
{ {
$proc= My::SafeProcess->wait_any_timeout($test_timeout); $proc= My::SafeProcess->wait_any_timeout($test_timeout);
$keep_waiting_proc{$proc} = 1;
} }
} }
if (scalar(keys(%keep_waiting_proc)) == 0) # Will be restored if we need to keep waiting
$keep_waiting_proc = 0;
unless ( defined $proc )
{ {
mtr_error("wait_any failed"); mtr_error("wait_any failed");
} }
mtr_verbose("Got " . join(",", keys(%keep_waiting_proc))); mtr_verbose("Got $proc");
mark_time_used('test'); mark_time_used('test');
my $expected_exit = 1;
foreach $proc (keys(%keep_waiting_proc)) {
# ---------------------------------------------------- # ----------------------------------------------------
# Was it the test program that exited # Was it the test program that exited
# ---------------------------------------------------- # ----------------------------------------------------
...@@ -4143,22 +4143,11 @@ sub run_testcase ($$) { ...@@ -4143,22 +4143,11 @@ sub run_testcase ($$) {
# Check if it was an expected crash # Check if it was an expected crash
# ---------------------------------------------------- # ----------------------------------------------------
my $check_crash = check_expected_crash_and_restart($proc); my $check_crash = check_expected_crash_and_restart($proc);
if ($check_crash == 0) # unexpected exit/crash of $proc if ($check_crash)
{ {
$expected_exit = 0; # Keep waiting if it returned 2, if 1 don't wait or stop waiting.
last; $keep_waiting_proc = 0 if $check_crash == 1;
} $keep_waiting_proc = $proc if $check_crash == 2;
elsif ($check_crash == 1) # $proc was started again by check_expected_crash_and_restart()
{
delete $keep_waiting_proc{$proc};
}
elsif ($check_crash == 2) # we must keep waiting
{
# do nothing
}
}
if ($expected_exit) {
next; next;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment