#4222 merge 37514 to main refs[t:4222]

git-svn-id: file:///svn/toku/tokudb@37516 c7de825b-a66e-492c-adef-691d508d4ae1

Makefile

@@ -38,6 +38,9 @@ build: $(patsubst %,%.dir, $(BUILDDIRS))
 %.local:
 	cd $(patsubst %.local, %,$@) && $(MAKE) local
 
+%.check:
+	cd $(patsubst %.check, %,$@) && $(MAKE) check
+
 release: linux.local newbrt.local src.local release.local
 
 CHECKS = $(patsubst %,%.checkdir,$(SRCDIRS))

linux/linux.c

@@ -19,27 +19,18 @@
 #include "toku_portability.h"
 #include "toku_os.h"
 #include "toku_time.h"
-
-static int
-toku_mallopt_init(void) {
-    int r = mallopt(M_MMAP_THRESHOLD, 1024*64); // 64K and larger should be malloced with mmap().
-    return r;
-}
+#include "memory.h"
 
 int
 toku_portability_init(void) {
-    int r = 0;
-    if (r==0) {
-        int success = toku_mallopt_init(); //mallopt returns 1 on success, 0 on error
-        assert(success);
-    }
+    int r = toku_memory_startup();
     return r;
 }
 
 int
 toku_portability_destroy(void) {
-    int r = 0;
-    return r;
+    toku_memory_shutdown();
+    return 0;
 }
 
 int

linux/memory.c

@@ -18,24 +18,46 @@ static realloc_fun_t t_xrealloc = 0;
 
 static MEMORY_STATUS_S status;
 
-//TODO 4222  Replace this hard-coded constant with supplied by mallocator.
-//           Perhaps make this work with libc as well.
-static const size_t mmap_limit = 4 * 1024 * 1024;
+int
+toku_memory_startup(void) {
+    int result = 0;
+   
+    // initialize libc malloc
+    size_t mmap_threshold = 64 * 1024; // 64K and larger should be malloced with mmap().
+    int success = mallopt(M_MMAP_THRESHOLD, mmap_threshold);
+    if (success) {
+        status.mallocator_version = "libc";
+        status.mmap_threshold = mmap_threshold;
+    } else
+        result = EINVAL;
 
-void 
-toku_memory_get_status(MEMORY_STATUS s) {
-    if (status.mallocator_version == NULL) {
-        // mallctl in jemalloc can be used to get the version string
+    // jemalloc has a mallctl function, while libc malloc does not.  we can check if jemalloc 
+    // is loaded by checking if the mallctl function can be found.  if it can, we call it 
+    // to get version and mmap threshold configuration.
     typedef int (*mallctl_fun_t)(const char *, void *, size_t *, void *, size_t);
     mallctl_fun_t mallctl_f;
     mallctl_f = (mallctl_fun_t) dlsym(NULL, "mallctl");
-        if (mallctl_f) {
+    if (mallctl_f) { // jemalloc is loaded
         size_t version_length = sizeof status.mallocator_version;
-            int r = mallctl_f("version", &status.mallocator_version, &version_length, NULL, 0);
-            assert(r == 0);
-        } else
-            status.mallocator_version = "libc";
+        result = mallctl_f("version", &status.mallocator_version, &version_length, NULL, 0);
+        if (result == 0) {
+            size_t lg_chunk; // log2 of the mmap threshold
+            size_t lg_chunk_length = sizeof lg_chunk;
+            result  = mallctl_f("lg_chunk", &lg_chunk, &lg_chunk_length, NULL, 0);
+            if (result == 0)
+                status.mmap_threshold = 1 << lg_chunk;
         }
+    }
+
+    return result;
+}
+
+void
+toku_memory_shutdown(void) {
+}
+
+void 
+toku_memory_get_status(MEMORY_STATUS s) {
     *s = status;
 }
 
@@ -56,16 +78,15 @@ set_max(uint64_t sum_used, uint64_t sum_freed) {
     }
 }
 
-
-
-size_t toku_memory_footprint(void * p, size_t touched) {
+size_t 
+toku_memory_footprint(void * p, size_t touched) {
     static size_t pagesize = 0;
     size_t rval = 0;
     if (!pagesize)
 	pagesize = sysconf(_SC_PAGESIZE);
     if (p) {
-	size_t usable = malloc_usable_size(p);
-	if (usable >= mmap_limit) {
+	size_t usable = my_malloc_usable_size(p);
+	if (usable >= status.mmap_threshold) {
             int num_pages = (touched + pagesize) / pagesize;
             rval = num_pages * pagesize;
 	}
@@ -76,8 +97,8 @@ size_t toku_memory_footprint(void * p, size_t touched) {
     return rval;
 }
 
-
-void *toku_malloc(size_t size) {
+void *
+toku_malloc(size_t size) {
     void *p = t_malloc ? t_malloc(size) : os_malloc(size);
     if (p) {
         size_t used = my_malloc_usable_size(p);
@@ -184,7 +205,7 @@ toku_xrealloc(void *v, size_t size) {
 
 size_t 
 toku_malloc_usable_size(void *p) {
-    return p == NULL ? 0 : malloc_usable_size(p);
+    return my_malloc_usable_size(p);
 }
 
 void *

newbrt/valgrind.suppressions

@@ -120,18 +120,12 @@
    Memcheck:Leak
    fun:calloc
    fun:_dlerror_run
-   fun:dlsym
+   obj:/lib64/libdl-2.5.so
 }
 {
    dlsym_on_centos
    Memcheck:Leak
    fun:malloc
    fun:_dl_signal_error
-   fun:_dl_signal_cerror
-   fun:_dl_lookup_symbol_x
-   fun:do_sym
-   fun:dlsym_doit
-   fun:_dl_catch_error
-   fun:_dlerror_run
-   fun:dlsym
+   obj:/lib64/ld-2.5.so
 }

toku_include/memory.h

@@ -13,6 +13,9 @@ extern "C" {
 /* Tokutek memory allocation functions and macros.
  * These are functions for malloc and free */
 
+int toku_memory_startup(void);
+void toku_memory_shutdown(void);
+
 /* Generally: errno is set to 0 or a value to indicate problems. */
 
 /* Everything should call toku_malloc() instead of malloc(), and toku_calloc() instead of calloc() */
@@ -105,6 +108,7 @@ typedef struct memory_status {
     uint64_t freed;           // number of bytes freed;
     uint64_t max_in_use;      // maximum memory footprint (used - freed), approximate (not worth threadsafety overhead for exact)
     const char *mallocator_version;
+    uint64_t mmap_threshold;
 } MEMORY_STATUS_S, *MEMORY_STATUS;
 
 void toku_memory_get_status(MEMORY_STATUS s);