COM_TABLE_DUMP and COM_BINLOG_DUMP are no longer erroneously logged

to the slow query log.
parent 8a0516ad
mwagner@evoq.mwagner.org mwagner@evoq.mwagner.org
tfr@coyote.emotion.ee tfr@coyote.emotion.ee
jcole@tetra.spaceapes.com
...@@ -561,6 +561,9 @@ bool do_command(THD *thd) ...@@ -561,6 +561,9 @@ bool do_command(THD *thd)
bool error=0; bool error=0;
NET *net; NET *net;
enum enum_server_command command; enum enum_server_command command;
// commands which will always take a long time should be marked with
// this so that they will not get logged to the slow query log
bool slow_command=FALSE;
DBUG_ENTER("do_command"); DBUG_ENTER("do_command");
net= &thd->net; net= &thd->net;
...@@ -604,6 +607,7 @@ bool do_command(THD *thd) ...@@ -604,6 +607,7 @@ bool do_command(THD *thd)
break; break;
case COM_TABLE_DUMP: case COM_TABLE_DUMP:
{ {
slow_command = TRUE;
char* data = packet + 1; char* data = packet + 1;
uint db_len = *data; uint db_len = *data;
uint tbl_len = *(data + db_len + 1); uint tbl_len = *(data + db_len + 1);
...@@ -744,6 +748,7 @@ bool do_command(THD *thd) ...@@ -744,6 +748,7 @@ bool do_command(THD *thd)
} }
case COM_BINLOG_DUMP: case COM_BINLOG_DUMP:
{ {
slow_command = TRUE;
if(check_access(thd, FILE_ACL, any_db)) if(check_access(thd, FILE_ACL, any_db))
break; break;
mysql_log.write(thd,command, 0); mysql_log.write(thd,command, 0);
...@@ -848,16 +853,18 @@ bool do_command(THD *thd) ...@@ -848,16 +853,18 @@ bool do_command(THD *thd)
thd->proc_info="closing tables"; thd->proc_info="closing tables";
close_thread_tables(thd); /* Free tables */ close_thread_tables(thd); /* Free tables */
} }
thd->proc_info="cleaning up";
if (thd->fatal_error) if (thd->fatal_error)
send_error(net,0); // End of memory ? send_error(net,0); // End of memory ?
time_t start_of_query=thd->start_time; time_t start_of_query=thd->start_time;
thd->end_time(); // Set start time thd->end_time(); // Set start time
/* If not reading from backup and if the query took too long */ /* If not reading from backup and if the query took too long */
if (!thd->user_time) if (!slow_command && !thd->user_time) // do not log 'slow_command' queries
{ {
thd->proc_info="logging slow query";
if ((ulong) (thd->start_time - thd->time_after_lock) > long_query_time || if ((ulong) (thd->start_time - thd->time_after_lock) > long_query_time ||
((thd->lex.options & ((thd->lex.options &
(QUERY_NO_INDEX_USED | QUERY_NO_GOOD_INDEX_USED)) && (QUERY_NO_INDEX_USED | QUERY_NO_GOOD_INDEX_USED)) &&
...@@ -867,7 +874,7 @@ bool do_command(THD *thd) ...@@ -867,7 +874,7 @@ bool do_command(THD *thd)
mysql_slow_log.write(thd, thd->query, thd->query_length, start_of_query); mysql_slow_log.write(thd, thd->query, thd->query_length, start_of_query);
} }
} }
thd->proc_info="cleaning up2"; thd->proc_info="cleaning up";
VOID(pthread_mutex_lock(&LOCK_thread_count)); // For process list VOID(pthread_mutex_lock(&LOCK_thread_count)); // For process list
thd->proc_info=0; thd->proc_info=0;
thd->command=COM_SLEEP; thd->command=COM_SLEEP;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment