Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
a197c6bb
Commit
a197c6bb
authored
Mar 18, 2016
by
Igor Babaev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prohibit using window functions of some types with
window frames in full accordance with the SQL standard.
parent
761590dc
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
63 additions
and
0 deletions
+63
-0
mysql-test/r/win.result
mysql-test/r/win.result
+19
-0
mysql-test/t/win.test
mysql-test/t/win.test
+21
-0
sql/item_windowfunc.cc
sql/item_windowfunc.cc
+6
-0
sql/item_windowfunc.h
sql/item_windowfunc.h
+15
-0
sql/share/errmsg-utf8.txt
sql/share/errmsg-utf8.txt
+2
-0
No files found.
mysql-test/r/win.result
View file @
a197c6bb
...
@@ -451,6 +451,25 @@ count(*) over (w2 rows between 2 following and current row) as CNT
...
@@ -451,6 +451,25 @@ count(*) over (w2 rows between 2 following and current row) as CNT
from t1
from t1
window w1 as (partition by c), w2 as (w1 order by pk);
window w1 as (partition by c), w2 as (w1 order by pk);
ERROR HY000: Unacceptable combination of window frame bound specifications
ERROR HY000: Unacceptable combination of window frame bound specifications
select
pk, c,
row_number() over (partition by c order by pk
range between unbounded preceding and current row) as r
from t1;
ERROR HY000: Window frame is not allowed with 'row_number'
select
pk, c,
rank() over w1 as r
from t1
window w1 as (partition by c order by pk
rows between 2 preceding and 2 following);
ERROR HY000: Window frame is not allowed with 'rank'
select
pk, c,
dense_rank() over (partition by c order by pk
rows between 1 preceding and 1 following) as r
from t1;
ERROR HY000: Window frame is not allowed with 'dense_rank'
drop table t0,t1;
drop table t0,t1;
#
#
# MDEV-9634: Window function produces incorrect value
# MDEV-9634: Window function produces incorrect value
...
...
mysql-test/t/win.test
View file @
a197c6bb
...
@@ -289,6 +289,27 @@ select
...
@@ -289,6 +289,27 @@ select
from
t1
from
t1
window
w1
as
(
partition
by
c
),
w2
as
(
w1
order
by
pk
);
window
w1
as
(
partition
by
c
),
w2
as
(
w1
order
by
pk
);
--
error
ER_NOT_ALLOWED_WINDOW_FRAME
select
pk
,
c
,
row_number
()
over
(
partition
by
c
order
by
pk
range
between
unbounded
preceding
and
current
row
)
as
r
from
t1
;
--
error
ER_NOT_ALLOWED_WINDOW_FRAME
select
pk
,
c
,
rank
()
over
w1
as
r
from
t1
window
w1
as
(
partition
by
c
order
by
pk
rows
between
2
preceding
and
2
following
);
--
error
ER_NOT_ALLOWED_WINDOW_FRAME
select
pk
,
c
,
dense_rank
()
over
(
partition
by
c
order
by
pk
rows
between
1
preceding
and
1
following
)
as
r
from
t1
;
drop
table
t0
,
t1
;
drop
table
t0
,
t1
;
...
...
sql/item_windowfunc.cc
View file @
a197c6bb
...
@@ -53,6 +53,12 @@ Item_window_func::fix_fields(THD *thd, Item **ref)
...
@@ -53,6 +53,12 @@ Item_window_func::fix_fields(THD *thd, Item **ref)
if
(
window_name
&&
resolve_window_name
(
thd
))
if
(
window_name
&&
resolve_window_name
(
thd
))
return
true
;
return
true
;
if
(
window_spec
->
window_frame
&&
is_frame_prohibited
())
{
my_error
(
ER_NOT_ALLOWED_WINDOW_FRAME
,
MYF
(
0
),
window_func
->
func_name
());
return
true
;
}
/*
/*
TODO: why the last parameter is 'ref' in this call? What if window_func
TODO: why the last parameter is 'ref' in this call? What if window_func
decides to substitute itself for something else and does *ref=.... ?
decides to substitute itself for something else and does *ref=.... ?
...
...
sql/item_windowfunc.h
View file @
a197c6bb
...
@@ -436,6 +436,20 @@ class Item_window_func : public Item_result_field
...
@@ -436,6 +436,20 @@ class Item_window_func : public Item_result_field
force_return_blank
(
true
),
force_return_blank
(
true
),
read_value_from_result_field
(
false
)
{}
read_value_from_result_field
(
false
)
{}
bool
is_frame_prohibited
()
{
switch
(
window_func
->
sum_func
())
{
case
Item_sum
:
:
ROW_NUMBER_FUNC
:
case
Item_sum
:
:
RANK_FUNC
:
case
Item_sum
:
:
DENSE_RANK_FUNC
:
case
Item_sum
:
:
PERCENT_RANK_FUNC
:
case
Item_sum
:
:
CUME_DIST_FUNC
:
return
true
;
default:
return
false
;
}
}
/*
/*
Computation functions.
Computation functions.
TODO: consoder merging these with class Group_bound_tracker.
TODO: consoder merging these with class Group_bound_tracker.
...
@@ -581,6 +595,7 @@ class Item_window_func : public Item_result_field
...
@@ -581,6 +595,7 @@ class Item_window_func : public Item_result_field
bool
fix_fields
(
THD
*
thd
,
Item
**
ref
);
bool
fix_fields
(
THD
*
thd
,
Item
**
ref
);
bool
resolve_window_name
(
THD
*
thd
);
bool
resolve_window_name
(
THD
*
thd
);
};
};
#endif
/* ITEM_WINDOWFUNC_INCLUDED */
#endif
/* ITEM_WINDOWFUNC_INCLUDED */
sql/share/errmsg-utf8.txt
View file @
a197c6bb
...
@@ -7148,6 +7148,8 @@ ER_WINDOW_FRAME_IN_REFERENCED_WINDOW_SPEC
...
@@ -7148,6 +7148,8 @@ ER_WINDOW_FRAME_IN_REFERENCED_WINDOW_SPEC
eng "Referenced window specification '%s' cannot contain window frame"
eng "Referenced window specification '%s' cannot contain window frame"
ER_BAD_COMBINATION_OF_WINDOW_FRAME_BOUND_SPECS
ER_BAD_COMBINATION_OF_WINDOW_FRAME_BOUND_SPECS
eng "Unacceptable combination of window frame bound specifications"
eng "Unacceptable combination of window frame bound specifications"
ER_NOT_ALLOWED_WINDOW_FRAME
eng "Window frame is not allowed with '%s'"
ER_RANGE_FRAME_NEEDS_SIMPLE_ORDERBY
ER_RANGE_FRAME_NEEDS_SIMPLE_ORDERBY
eng "RANGE-type frame requires ORDER BY clause with single sort key"
eng "RANGE-type frame requires ORDER BY clause with single sort key"
ER_WRONG_TYPE_FOR_ROWS_FRAME
ER_WRONG_TYPE_FOR_ROWS_FRAME
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment