Commit a7a0c533 authored by Marko Mäkelä's avatar Marko Mäkelä

Follow-up to MDEV-15855: Remove bogus debug assertions

During a table-rebuilding operation, the function table_name_parse()
can encounter a table name that starts with #sql. Here is an example
of a failure:

CURRENT_TEST: gcol.innodb_virtual_basic
mysqltest: At line 1204: query 'alter table t drop column d ' failed:
2013: Lost connection to MySQL server during query

Let us just remove these bogus debug assertions.

If the final renaming phase during ALTER TABLE never fails, it
should not do any harm to skip the purge. If it does fail, then
we might end up 'leaking' some delete-marked records in the
indexes on virtual columns of the original table, and these
garbage records would keep consuming space until the indexes are
dropped or the table is successfully rebuilt.
parent 730f6c91
...@@ -21661,7 +21661,6 @@ static TABLE* innodb_acquire_mdl(THD* thd, dict_table_t* table) ...@@ -21661,7 +21661,6 @@ static TABLE* innodb_acquire_mdl(THD* thd, dict_table_t* table)
if (!table_name_parse(table->name, db_buf, tbl_buf, if (!table_name_parse(table->name, db_buf, tbl_buf,
db_buf_len, tbl_buf_len)) { db_buf_len, tbl_buf_len)) {
ut_ad(!"invalid table name");
return NULL; return NULL;
} }
...@@ -21697,7 +21696,6 @@ static TABLE* innodb_acquire_mdl(THD* thd, dict_table_t* table) ...@@ -21697,7 +21696,6 @@ static TABLE* innodb_acquire_mdl(THD* thd, dict_table_t* table)
if (!table_name_parse(table->name, db_buf1, tbl_buf1, if (!table_name_parse(table->name, db_buf1, tbl_buf1,
db_buf1_len, tbl_buf1_len)) { db_buf1_len, tbl_buf1_len)) {
ut_ad(!"invalid table name");
goto release_fail; goto release_fail;
} }
...@@ -21745,7 +21743,6 @@ static TABLE* innodb_find_table_for_vc(THD* thd, dict_table_t* table) ...@@ -21745,7 +21743,6 @@ static TABLE* innodb_find_table_for_vc(THD* thd, dict_table_t* table)
if (!table_name_parse(table->name, db_buf, tbl_buf, if (!table_name_parse(table->name, db_buf, tbl_buf,
db_buf_len, tbl_buf_len)) { db_buf_len, tbl_buf_len)) {
ut_ad(!"invalid table name");
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment