Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
adf4e7a8
Commit
adf4e7a8
authored
Aug 20, 2004
by
unknown
Browse files
Options
Browse Files
Download
Plain Diff
merged
sql/lock.cc: Auto merged sql/mysql_priv.h: Auto merged sql/sql_db.cc: Auto merged
parents
91df1608
4f0e2da3
Changes
9
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
161 additions
and
27 deletions
+161
-27
mysql-test/r/flush_block_commit.result
mysql-test/r/flush_block_commit.result
+23
-0
mysql-test/t/flush_block_commit-master.opt
mysql-test/t/flush_block_commit-master.opt
+1
-0
mysql-test/t/flush_block_commit.test
mysql-test/t/flush_block_commit.test
+49
-0
sql/handler.cc
sql/handler.cc
+30
-14
sql/lock.cc
sql/lock.cc
+47
-7
sql/mysql_priv.h
sql/mysql_priv.h
+2
-1
sql/sql_class.h
sql/sql_class.h
+2
-2
sql/sql_db.cc
sql/sql_db.cc
+2
-2
sql/sql_parse.cc
sql/sql_parse.cc
+5
-1
No files found.
mysql-test/r/flush_block_commit.result
0 → 100644
View file @
adf4e7a8
drop table if exists t1;
create table t1 (a int) type=innodb;
begin;
insert into t1 values(1);
flush tables with read lock;
select * from t1;
a
commit;
select * from t1;
a
unlock tables;
begin;
select * from t1 for update;
a
1
begin;
select * from t1 for update;
flush tables with read lock;
commit;
a
1
unlock tables;
drop table t1;
mysql-test/t/flush_block_commit-master.opt
0 → 100644
View file @
adf4e7a8
--innodb_lock_wait_timeout=5
mysql-test/t/flush_block_commit.test
0 → 100644
View file @
adf4e7a8
# Let's see if FLUSH TABLES WITH READ LOCK blocks COMMIT of existing
# transactions.
# We verify that we did not introduce a deadlock.
--
source
include
/
have_innodb
.
inc
connect
(
con1
,
localhost
,
root
,,);
connect
(
con2
,
localhost
,
root
,,);
connect
(
con3
,
localhost
,
root
,,);
connection
con1
;
drop
table
if
exists
t1
;
create
table
t1
(
a
int
)
type
=
innodb
;
# blocks COMMIT ?
begin
;
insert
into
t1
values
(
1
);
connection
con2
;
flush
tables
with
read
lock
;
select
*
from
t1
;
connection
con1
;
send
commit
;
# blocked by con2
sleep
1
;
connection
con2
;
select
*
from
t1
;
# verify con1 was blocked and data did not move
unlock
tables
;
connection
con1
;
reap
;
# No deadlock ?
connection
con1
;
begin
;
select
*
from
t1
for
update
;
connection
con2
;
begin
;
send
select
*
from
t1
for
update
;
# blocked by con1
sleep
1
;
connection
con3
;
send
flush
tables
with
read
lock
;
# blocked by con2
connection
con1
;
commit
;
# should not be blocked by con3
connection
con2
;
reap
;
connection
con3
;
reap
;
unlock
tables
;
connection
con1
;
drop
table
t1
;
sql/handler.cc
View file @
adf4e7a8
...
@@ -477,11 +477,24 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
...
@@ -477,11 +477,24 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
if
(
opt_using_transactions
)
if
(
opt_using_transactions
)
{
{
bool
operation_done
=
0
;
bool
operation_done
=
0
;
bool
transaction_commited
=
0
;
bool
operation_done
=
0
,
need_start_waiters
=
0
;
/*
Update the binary log if we have cached some queri
es */
/*
If transaction has done some updates to tabl
es */
if
(
trans
==
&
thd
->
transaction
.
all
&&
mysql_bin_log
.
is_open
()
&&
if
(
trans
==
&
thd
->
transaction
.
all
&&
my_b_tell
(
&
thd
->
transaction
.
trans_log
))
my_b_tell
(
&
thd
->
transaction
.
trans_log
))
{
if
(
error
=
wait_if_global_read_lock
(
thd
,
0
,
0
))
{
/*
Note that ROLLBACK [TO SAVEPOINT] does not have this test; it's
because ROLLBACK never updates data, so needn't wait on the lock.
*/
my_error
(
ER_ERROR_DURING_COMMIT
,
MYF
(
0
),
error
);
error
=
1
;
}
else
need_start_waiters
=
1
;
if
(
mysql_bin_log
.
is_open
())
{
{
mysql_bin_log
.
write
(
thd
,
&
thd
->
transaction
.
trans_log
,
1
);
mysql_bin_log
.
write
(
thd
,
&
thd
->
transaction
.
trans_log
,
1
);
statistic_increment
(
binlog_cache_use
,
&
LOCK_status
);
statistic_increment
(
binlog_cache_use
,
&
LOCK_status
);
...
@@ -498,6 +511,7 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
...
@@ -498,6 +511,7 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
WRITE_CACHE
,
(
my_off_t
)
0
,
0
,
1
);
WRITE_CACHE
,
(
my_off_t
)
0
,
0
,
1
);
thd
->
transaction
.
trans_log
.
end_of_file
=
max_binlog_cache_size
;
thd
->
transaction
.
trans_log
.
end_of_file
=
max_binlog_cache_size
;
}
}
}
#ifdef HAVE_NDBCLUSTER_DB
#ifdef HAVE_NDBCLUSTER_DB
if
(
trans
->
ndb_tid
)
if
(
trans
->
ndb_tid
)
{
{
...
@@ -551,6 +565,8 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
...
@@ -551,6 +565,8 @@ int ha_commit_trans(THD *thd, THD_TRANS* trans)
statistic_increment
(
ha_commit_count
,
&
LOCK_status
);
statistic_increment
(
ha_commit_count
,
&
LOCK_status
);
thd
->
transaction
.
cleanup
();
thd
->
transaction
.
cleanup
();
}
}
if
(
need_start_waiters
)
start_waiting_global_read_lock
(
thd
);
}
}
#endif // using transactions
#endif // using transactions
DBUG_RETURN
(
error
);
DBUG_RETURN
(
error
);
...
...
sql/lock.cc
View file @
adf4e7a8
...
@@ -99,7 +99,7 @@ MYSQL_LOCK *mysql_lock_tables(THD *thd,TABLE **tables,uint count)
...
@@ -99,7 +99,7 @@ MYSQL_LOCK *mysql_lock_tables(THD *thd,TABLE **tables,uint count)
Someone has issued LOCK ALL TABLES FOR READ and we want a write lock
Someone has issued LOCK ALL TABLES FOR READ and we want a write lock
Wait until the lock is gone
Wait until the lock is gone
*/
*/
if
(
wait_if_global_read_lock
(
thd
,
1
))
if
(
wait_if_global_read_lock
(
thd
,
1
,
1
))
{
{
my_free
((
gptr
)
sql_lock
,
MYF
(
0
));
my_free
((
gptr
)
sql_lock
,
MYF
(
0
));
sql_lock
=
0
;
sql_lock
=
0
;
...
@@ -474,7 +474,7 @@ int lock_and_wait_for_table_name(THD *thd, TABLE_LIST *table_list)
...
@@ -474,7 +474,7 @@ int lock_and_wait_for_table_name(THD *thd, TABLE_LIST *table_list)
int
error
=
-
1
;
int
error
=
-
1
;
DBUG_ENTER
(
"lock_and_wait_for_table_name"
);
DBUG_ENTER
(
"lock_and_wait_for_table_name"
);
if
(
wait_if_global_read_lock
(
thd
,
0
))
if
(
wait_if_global_read_lock
(
thd
,
0
,
1
))
DBUG_RETURN
(
1
);
DBUG_RETURN
(
1
);
VOID
(
pthread_mutex_lock
(
&
LOCK_open
));
VOID
(
pthread_mutex_lock
(
&
LOCK_open
));
if
((
lock_retcode
=
lock_table_name
(
thd
,
table_list
))
<
0
)
if
((
lock_retcode
=
lock_table_name
(
thd
,
table_list
))
<
0
)
...
@@ -707,14 +707,23 @@ static void print_lock_error(int error)
...
@@ -707,14 +707,23 @@ static void print_lock_error(int error)
The global locks are handled through the global variables:
The global locks are handled through the global variables:
global_read_lock
global_read_lock
global_read_lock_blocks_commit
waiting_for_read_lock
waiting_for_read_lock
protect_against_global_read_lock
protect_against_global_read_lock
Taking the global read lock is TWO steps (2nd step is optional; without
it, COMMIT of existing transactions will be allowed):
lock_global_read_lock() THEN make_global_read_lock_block_commit().
****************************************************************************/
****************************************************************************/
volatile
uint
global_read_lock
=
0
;
volatile
uint
global_read_lock
=
0
;
volatile
uint
global_read_lock_blocks_commit
=
0
;
static
volatile
uint
protect_against_global_read_lock
=
0
;
static
volatile
uint
protect_against_global_read_lock
=
0
;
static
volatile
uint
waiting_for_read_lock
=
0
;
static
volatile
uint
waiting_for_read_lock
=
0
;
#define GOT_GLOBAL_READ_LOCK 1
#define MADE_GLOBAL_READ_LOCK_BLOCK_COMMIT 2
bool
lock_global_read_lock
(
THD
*
thd
)
bool
lock_global_read_lock
(
THD
*
thd
)
{
{
DBUG_ENTER
(
"lock_global_read_lock"
);
DBUG_ENTER
(
"lock_global_read_lock"
);
...
@@ -737,27 +746,40 @@ bool lock_global_read_lock(THD *thd)
...
@@ -737,27 +746,40 @@ bool lock_global_read_lock(THD *thd)
thd
->
exit_cond
(
old_message
);
thd
->
exit_cond
(
old_message
);
DBUG_RETURN
(
1
);
DBUG_RETURN
(
1
);
}
}
thd
->
global_read_lock
=
1
;
thd
->
global_read_lock
=
GOT_GLOBAL_READ_LOCK
;
global_read_lock
++
;
global_read_lock
++
;
thd
->
exit_cond
(
old_message
);
thd
->
exit_cond
(
old_message
);
}
}
/*
We DON'T set global_read_lock_blocks_commit now, it will be set after
tables are flushed (as the present function serves for FLUSH TABLES WITH
READ LOCK only). Doing things in this order is necessary to avoid
deadlocks (we must allow COMMIT until all tables are closed; we should not
forbid it before, or we can have a 3-thread deadlock if 2 do SELECT FOR
UPDATE and one does FLUSH TABLES WITH READ LOCK).
*/
DBUG_RETURN
(
0
);
DBUG_RETURN
(
0
);
}
}
void
unlock_global_read_lock
(
THD
*
thd
)
void
unlock_global_read_lock
(
THD
*
thd
)
{
{
uint
tmp
;
uint
tmp
;
thd
->
global_read_lock
=
0
;
pthread_mutex_lock
(
&
LOCK_open
);
pthread_mutex_lock
(
&
LOCK_open
);
tmp
=
--
global_read_lock
;
tmp
=
--
global_read_lock
;
if
(
thd
->
global_read_lock
==
MADE_GLOBAL_READ_LOCK_BLOCK_COMMIT
)
--
global_read_lock_blocks_commit
;
pthread_mutex_unlock
(
&
LOCK_open
);
pthread_mutex_unlock
(
&
LOCK_open
);
/* Send the signal outside the mutex to avoid a context switch */
/* Send the signal outside the mutex to avoid a context switch */
if
(
!
tmp
)
if
(
!
tmp
)
pthread_cond_broadcast
(
&
COND_refresh
);
pthread_cond_broadcast
(
&
COND_refresh
);
thd
->
global_read_lock
=
0
;
}
}
#define must_wait (global_read_lock && \
(is_not_commit || \
global_read_lock_blocks_commit))
bool
wait_if_global_read_lock
(
THD
*
thd
,
bool
abort_on_refresh
)
bool
wait_if_global_read_lock
(
THD
*
thd
,
bool
abort_on_refresh
,
bool
is_not_commit
)
{
{
const
char
*
old_message
;
const
char
*
old_message
;
bool
result
=
0
,
need_exit_cond
;
bool
result
=
0
,
need_exit_cond
;
...
@@ -765,7 +787,7 @@ bool wait_if_global_read_lock(THD *thd, bool abort_on_refresh)
...
@@ -765,7 +787,7 @@ bool wait_if_global_read_lock(THD *thd, bool abort_on_refresh)
LINT_INIT
(
old_message
);
LINT_INIT
(
old_message
);
(
void
)
pthread_mutex_lock
(
&
LOCK_open
);
(
void
)
pthread_mutex_lock
(
&
LOCK_open
);
if
(
need_exit_cond
=
(
bool
)
global_read_lock
)
if
(
need_exit_cond
=
must_wait
)
{
{
if
(
thd
->
global_read_lock
)
// This thread had the read locks
if
(
thd
->
global_read_lock
)
// This thread had the read locks
{
{
...
@@ -775,7 +797,7 @@ bool wait_if_global_read_lock(THD *thd, bool abort_on_refresh)
...
@@ -775,7 +797,7 @@ bool wait_if_global_read_lock(THD *thd, bool abort_on_refresh)
}
}
old_message
=
thd
->
enter_cond
(
&
COND_refresh
,
&
LOCK_open
,
old_message
=
thd
->
enter_cond
(
&
COND_refresh
,
&
LOCK_open
,
"Waiting for release of readlock"
);
"Waiting for release of readlock"
);
while
(
global_read_lock
&&
!
thd
->
killed
&&
while
(
must_wait
&&
!
thd
->
killed
&&
(
!
abort_on_refresh
||
thd
->
version
==
refresh_version
))
(
!
abort_on_refresh
||
thd
->
version
==
refresh_version
))
(
void
)
pthread_cond_wait
(
&
COND_refresh
,
&
LOCK_open
);
(
void
)
pthread_cond_wait
(
&
COND_refresh
,
&
LOCK_open
);
if
(
thd
->
killed
)
if
(
thd
->
killed
)
...
@@ -802,3 +824,21 @@ void start_waiting_global_read_lock(THD *thd)
...
@@ -802,3 +824,21 @@ void start_waiting_global_read_lock(THD *thd)
pthread_cond_broadcast
(
&
COND_refresh
);
pthread_cond_broadcast
(
&
COND_refresh
);
DBUG_VOID_RETURN
;
DBUG_VOID_RETURN
;
}
}
void
make_global_read_lock_block_commit
(
THD
*
thd
)
{
/*
If we didn't succeed lock_global_read_lock(), or if we already suceeded
make_global_read_lock_block_commit(), do nothing.
*/
if
(
thd
->
global_read_lock
!=
GOT_GLOBAL_READ_LOCK
)
return
;
pthread_mutex_lock
(
&
LOCK_open
);
/* increment this BEFORE waiting on cond (otherwise race cond) */
global_read_lock_blocks_commit
++
;
while
(
protect_against_global_read_lock
)
pthread_cond_wait
(
&
COND_refresh
,
&
LOCK_open
);
pthread_mutex_unlock
(
&
LOCK_open
);
thd
->
global_read_lock
=
MADE_GLOBAL_READ_LOCK_BLOCK_COMMIT
;
}
sql/mysql_priv.h
View file @
adf4e7a8
...
@@ -955,8 +955,9 @@ void mysql_lock_abort_for_thread(THD *thd, TABLE *table);
...
@@ -955,8 +955,9 @@ void mysql_lock_abort_for_thread(THD *thd, TABLE *table);
MYSQL_LOCK
*
mysql_lock_merge
(
MYSQL_LOCK
*
a
,
MYSQL_LOCK
*
b
);
MYSQL_LOCK
*
mysql_lock_merge
(
MYSQL_LOCK
*
a
,
MYSQL_LOCK
*
b
);
bool
lock_global_read_lock
(
THD
*
thd
);
bool
lock_global_read_lock
(
THD
*
thd
);
void
unlock_global_read_lock
(
THD
*
thd
);
void
unlock_global_read_lock
(
THD
*
thd
);
bool
wait_if_global_read_lock
(
THD
*
thd
,
bool
abort_on_refresh
);
bool
wait_if_global_read_lock
(
THD
*
thd
,
bool
abort_on_refresh
,
bool
is_not_commit
);
void
start_waiting_global_read_lock
(
THD
*
thd
);
void
start_waiting_global_read_lock
(
THD
*
thd
);
void
make_global_read_lock_block_commit
(
THD
*
thd
);
/* Lock based on name */
/* Lock based on name */
int
lock_and_wait_for_table_name
(
THD
*
thd
,
TABLE_LIST
*
table_list
);
int
lock_and_wait_for_table_name
(
THD
*
thd
,
TABLE_LIST
*
table_list
);
...
...
sql/sql_class.h
View file @
adf4e7a8
...
@@ -812,7 +812,7 @@ class THD :public ilink,
...
@@ -812,7 +812,7 @@ class THD :public ilink,
ulong
row_count
;
// Row counter, mainly for errors and warnings
ulong
row_count
;
// Row counter, mainly for errors and warnings
long
dbug_thread_id
;
long
dbug_thread_id
;
pthread_t
real_id
;
pthread_t
real_id
;
uint
current_tablenr
,
tmp_table
;
uint
current_tablenr
,
tmp_table
,
global_read_lock
;
uint
server_status
,
open_options
,
system_thread
;
uint
server_status
,
open_options
,
system_thread
;
uint32
db_length
;
uint32
db_length
;
uint
select_number
;
//number of select (used for EXPLAIN)
uint
select_number
;
//number of select (used for EXPLAIN)
...
@@ -831,7 +831,7 @@ class THD :public ilink,
...
@@ -831,7 +831,7 @@ class THD :public ilink,
bool
no_errors
,
password
,
is_fatal_error
;
bool
no_errors
,
password
,
is_fatal_error
;
bool
query_start_used
,
last_insert_id_used
,
insert_id_used
,
rand_used
;
bool
query_start_used
,
last_insert_id_used
,
insert_id_used
,
rand_used
;
bool
time_zone_used
;
bool
time_zone_used
;
bool
in_lock_tables
,
global_read_lock
;
bool
in_lock_tables
;
bool
query_error
,
bootstrap
,
cleanup_done
;
bool
query_error
,
bootstrap
,
cleanup_done
;
bool
tmp_table_used
;
bool
tmp_table_used
;
bool
charset_is_system_charset
,
charset_is_collation_connection
;
bool
charset_is_system_charset
,
charset_is_collation_connection
;
...
...
sql/sql_db.cc
View file @
adf4e7a8
...
@@ -396,7 +396,7 @@ int mysql_create_db(THD *thd, char *db, HA_CREATE_INFO *create_info,
...
@@ -396,7 +396,7 @@ int mysql_create_db(THD *thd, char *db, HA_CREATE_INFO *create_info,
VOID
(
pthread_mutex_lock
(
&
LOCK_mysql_create_db
));
VOID
(
pthread_mutex_lock
(
&
LOCK_mysql_create_db
));
// do not create database if another thread is holding read lock
// do not create database if another thread is holding read lock
if
(
wait_if_global_read_lock
(
thd
,
0
))
if
(
wait_if_global_read_lock
(
thd
,
0
,
1
))
{
{
error
=
-
1
;
error
=
-
1
;
goto
exit2
;
goto
exit2
;
...
@@ -565,7 +565,7 @@ int mysql_rm_db(THD *thd,char *db,bool if_exists, bool silent)
...
@@ -565,7 +565,7 @@ int mysql_rm_db(THD *thd,char *db,bool if_exists, bool silent)
VOID
(
pthread_mutex_lock
(
&
LOCK_mysql_create_db
));
VOID
(
pthread_mutex_lock
(
&
LOCK_mysql_create_db
));
// do not drop database if another thread is holding read lock
// do not drop database if another thread is holding read lock
if
(
wait_if_global_read_lock
(
thd
,
0
))
if
(
wait_if_global_read_lock
(
thd
,
0
,
1
))
{
{
error
=
-
1
;
error
=
-
1
;
goto
exit2
;
goto
exit2
;
...
...
sql/sql_parse.cc
View file @
adf4e7a8
...
@@ -4815,9 +4815,13 @@ bool reload_acl_and_cache(THD *thd, ulong options, TABLE_LIST *tables,
...
@@ -4815,9 +4815,13 @@ bool reload_acl_and_cache(THD *thd, ulong options, TABLE_LIST *tables,
tmp_write_to_binlog
=
0
;
tmp_write_to_binlog
=
0
;
if
(
lock_global_read_lock
(
thd
))
if
(
lock_global_read_lock
(
thd
))
return
1
;
return
1
;
result
=
close_cached_tables
(
thd
,(
options
&
REFRESH_FAST
)
?
0
:
1
,
tables
);
make_global_read_lock_block_commit
(
thd
);
}
}
my_dbopt_cleanup
();
else
result
=
close_cached_tables
(
thd
,(
options
&
REFRESH_FAST
)
?
0
:
1
,
tables
);
result
=
close_cached_tables
(
thd
,(
options
&
REFRESH_FAST
)
?
0
:
1
,
tables
);
my_dbopt_cleanup
();
}
}
if
(
options
&
REFRESH_HOSTS
)
if
(
options
&
REFRESH_HOSTS
)
hostname_cache_refresh
();
hostname_cache_refresh
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment