Commit de9963b7 authored by Jan Lindström's avatar Jan Lindström

After reivew fixes.

parent 41cd80fe
...@@ -4513,7 +4513,7 @@ buf_page_check_corrupt( ...@@ -4513,7 +4513,7 @@ buf_page_check_corrupt(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"%s: Block in space_id " ULINTPF " in file %s corrupted.", "%s: Block in space_id " ULINTPF " in file %s corrupted.",
page_type == FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED ? "Maybe corruption" : "Corruption", page_type == FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED ? "Maybe corruption" : "Corruption",
space_id, space ? space->name : "NULL"); space_id, space->name ? space->name : "NULL");
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Based on page type %s (" ULINTPF ")", "Based on page type %s (" ULINTPF ")",
fil_get_page_type_name(page_type), page_type); fil_get_page_type_name(page_type), page_type);
...@@ -4523,7 +4523,7 @@ buf_page_check_corrupt( ...@@ -4523,7 +4523,7 @@ buf_page_check_corrupt(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Block in space_id " ULINTPF " in file %s encrypted.", "Block in space_id " ULINTPF " in file %s encrypted.",
space_id, space ? space->name : "NULL"); space_id, space->name ? space->name : "NULL");
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"However key management plugin or used key_version %u is not found or" "However key management plugin or used key_version %u is not found or"
" used encryption algorithm or method does not match.", " used encryption algorithm or method does not match.",
...@@ -4669,7 +4669,7 @@ buf_page_io_complete( ...@@ -4669,7 +4669,7 @@ buf_page_io_complete(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Space %u file %s read of page %u.", "Space %u file %s read of page %u.",
bpage->space, bpage->space,
space ? space->name : "NULL", space->name ? space->name : "NULL",
bpage->offset); bpage->offset);
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"You may have to recover" "You may have to recover"
...@@ -4894,7 +4894,7 @@ buf_all_freed_instance( ...@@ -4894,7 +4894,7 @@ buf_all_freed_instance(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Page space_id %u name %s.", "Page space_id %u name %s.",
block->page.space, block->page.space,
(space && space->name) ? space->name : "NULL"); space->name ? space->name : "NULL");
ut_error; ut_error;
} }
} }
......
...@@ -489,7 +489,6 @@ buf_dblwr_process() ...@@ -489,7 +489,6 @@ buf_dblwr_process()
for (std::list<byte*>::iterator i = recv_dblwr.pages.begin(); for (std::list<byte*>::iterator i = recv_dblwr.pages.begin();
i != recv_dblwr.pages.end(); ++i, ++page_no_dblwr ) { i != recv_dblwr.pages.end(); ++i, ++page_no_dblwr ) {
fil_space_t* space=NULL;
page = *i; page = *i;
page_no = mach_read_from_4(page + FIL_PAGE_OFFSET); page_no = mach_read_from_4(page + FIL_PAGE_OFFSET);
space_id = mach_read_from_4(page + FIL_PAGE_SPACE_ID); space_id = mach_read_from_4(page + FIL_PAGE_SPACE_ID);
...@@ -509,7 +508,7 @@ buf_dblwr_process() ...@@ -509,7 +508,7 @@ buf_dblwr_process()
continue; continue;
} }
space = fil_space_found_by_id(space_id); fil_space_t* space = fil_space_found_by_id(space_id);
ulint zip_size = fil_space_get_zip_size(space_id); ulint zip_size = fil_space_get_zip_size(space_id);
ut_ad(!buf_page_is_zeroes(page, zip_size)); ut_ad(!buf_page_is_zeroes(page, zip_size));
......
...@@ -4614,7 +4614,7 @@ buf_page_check_corrupt( ...@@ -4614,7 +4614,7 @@ buf_page_check_corrupt(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"%s: Block in space_id " ULINTPF " in file %s corrupted.", "%s: Block in space_id " ULINTPF " in file %s corrupted.",
page_type == FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED ? "Maybe corruption" : "Corruption", page_type == FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED ? "Maybe corruption" : "Corruption",
space_id, space ? space->name : "NULL"); space_id, space->name ? space->name : "NULL");
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Based on page type %s (" ULINTPF ")", "Based on page type %s (" ULINTPF ")",
fil_get_page_type_name(page_type), page_type); fil_get_page_type_name(page_type), page_type);
...@@ -4624,7 +4624,7 @@ buf_page_check_corrupt( ...@@ -4624,7 +4624,7 @@ buf_page_check_corrupt(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Block in space_id " ULINTPF " in file %s encrypted.", "Block in space_id " ULINTPF " in file %s encrypted.",
space_id, space ? space->name : "NULL"); space_id, space->name ? space->name : "NULL");
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"However key management plugin or used key_version %u is not found or" "However key management plugin or used key_version %u is not found or"
" used encryption algorithm or method does not match.", " used encryption algorithm or method does not match.",
...@@ -4775,7 +4775,7 @@ buf_page_io_complete( ...@@ -4775,7 +4775,7 @@ buf_page_io_complete(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Space %u file %s read of page %u.", "Space %u file %s read of page %u.",
bpage->space, bpage->space,
space ? space->name : "NULL", space->name ? space->name : "NULL",
bpage->offset); bpage->offset);
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"You may have to recover" "You may have to recover"
...@@ -5040,7 +5040,7 @@ buf_all_freed_instance( ...@@ -5040,7 +5040,7 @@ buf_all_freed_instance(
ib_logf(IB_LOG_LEVEL_ERROR, ib_logf(IB_LOG_LEVEL_ERROR,
"Page space_id %u name %s.", "Page space_id %u name %s.",
block->page.space, block->page.space,
(space && space->name) ? space->name : "NULL"); space->name ? space->name : "NULL");
ut_error; ut_error;
} }
} }
......
...@@ -489,7 +489,6 @@ buf_dblwr_process() ...@@ -489,7 +489,6 @@ buf_dblwr_process()
for (std::list<byte*>::iterator i = recv_dblwr.pages.begin(); for (std::list<byte*>::iterator i = recv_dblwr.pages.begin();
i != recv_dblwr.pages.end(); ++i, ++page_no_dblwr ) { i != recv_dblwr.pages.end(); ++i, ++page_no_dblwr ) {
fil_space_t* space=NULL;
page = *i; page = *i;
page_no = mach_read_from_4(page + FIL_PAGE_OFFSET); page_no = mach_read_from_4(page + FIL_PAGE_OFFSET);
space_id = mach_read_from_4(page + FIL_PAGE_SPACE_ID); space_id = mach_read_from_4(page + FIL_PAGE_SPACE_ID);
...@@ -509,7 +508,7 @@ buf_dblwr_process() ...@@ -509,7 +508,7 @@ buf_dblwr_process()
continue; continue;
} }
space = fil_space_found_by_id(space_id); fil_space_t* space = fil_space_found_by_id(space_id);
ulint zip_size = fil_space_get_zip_size(space_id); ulint zip_size = fil_space_get_zip_size(space_id);
ut_ad(!buf_page_is_zeroes(page, zip_size)); ut_ad(!buf_page_is_zeroes(page, zip_size));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment