Commit ea53f9af authored by Marko Mäkelä's avatar Marko Mäkelä

Merge from mysql-5.1-innodb:

  ------------------------------------------------------------
  revno: 3478.1.3
  revision-id: marko.makela@oracle.com-20100525123748-pmpehbg29oyhc1ns
  parent: marko.makela@oracle.com-20100524114349-5kaw52sz0yh4szkb
  committer: Marko Mäkelä <marko.makela@oracle.com>
  branch nick: 5.1-innodb
  timestamp: Tue 2010-05-25 15:37:48 +0300
  message:
    Suppress bogus Valgrind warnings about buf_buddy_relocate()
    accessing uninitialized memory in Valgrind-instrumented builds.
parent 2b47efb6
...@@ -740,3 +740,8 @@ ...@@ -740,3 +740,8 @@
fun:pthread_create* fun:pthread_create*
} }
{
buf_buddy_relocate peeking (space,page) in potentially free blocks
Memcheck:Addr1
fun:buf_buddy_relocate
}
...@@ -446,12 +446,15 @@ buf_buddy_relocate( ...@@ -446,12 +446,15 @@ buf_buddy_relocate(
pool), so there is nothing wrong about this. The pool), so there is nothing wrong about this. The
mach_read_from_4() calls here will only trigger bogus mach_read_from_4() calls here will only trigger bogus
Valgrind memcheck warnings in UNIV_DEBUG_VALGRIND builds. */ Valgrind memcheck warnings in UNIV_DEBUG_VALGRIND builds. */
bpage = buf_page_hash_get( ulint space = mach_read_from_4(
buf_pool, (const byte*) src + FIL_PAGE_ARCH_LOG_NO_OR_SPACE_ID);
mach_read_from_4((const byte*) src ulint page_no = mach_read_from_4(
+ FIL_PAGE_ARCH_LOG_NO_OR_SPACE_ID), (const byte*) src + FIL_PAGE_OFFSET);
mach_read_from_4((const byte*) src /* Suppress Valgrind warnings about conditional jump
+ FIL_PAGE_OFFSET)); on uninitialized value. */
UNIV_MEM_VALID(&space, sizeof space);
UNIV_MEM_VALID(&page_no, sizeof page_no);
bpage = buf_page_hash_get(buf_pool, space, page_no);
if (!bpage || bpage->zip.data != src) { if (!bpage || bpage->zip.data != src) {
/* The block has probably been freshly /* The block has probably been freshly
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment