Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
ed5d675c
Commit
ed5d675c
authored
Dec 22, 2020
by
Aleksey Midenkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-24364 Alter rename table does not remove PFS share
Add missed PSI_CALL_drop_table_share().
parent
113f1868
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
0 deletions
+23
-0
mysql-test/suite/perfschema/r/misc.result
mysql-test/suite/perfschema/r/misc.result
+10
-0
mysql-test/suite/perfschema/t/misc.test
mysql-test/suite/perfschema/t/misc.test
+11
-0
sql/sql_table.cc
sql/sql_table.cc
+2
-0
No files found.
mysql-test/suite/perfschema/r/misc.result
View file @
ed5d675c
...
@@ -164,3 +164,13 @@ Warnings:
...
@@ -164,3 +164,13 @@ Warnings:
Note 1051 Unknown table 'test.t0'
Note 1051 Unknown table 'test.t0'
FLUSH TABLE t0;
FLUSH TABLE t0;
DROP TABLE t0;
DROP TABLE t0;
#
# MDEV-24364 Alter rename table does not remove PFS share
#
create or replace table yt4 (x int) engine innodb;
alter table yt4 rename to t1, algorithm=copy;
drop tables t1;
select object_type, object_schema, object_name
from performance_schema.objects_summary_global_by_type
where object_schema="test";
object_type object_schema object_name
mysql-test/suite/perfschema/t/misc.test
View file @
ed5d675c
...
@@ -287,3 +287,14 @@ enable_query_log;
...
@@ -287,3 +287,14 @@ enable_query_log;
# an unexpected refcount.
# an unexpected refcount.
FLUSH
TABLE
t0
;
FLUSH
TABLE
t0
;
DROP
TABLE
t0
;
DROP
TABLE
t0
;
--
echo
#
--
echo
# MDEV-24364 Alter rename table does not remove PFS share
--
echo
#
create
or
replace
table
yt4
(
x
int
)
engine
innodb
;
alter
table
yt4
rename
to
t1
,
algorithm
=
copy
;
drop
tables
t1
;
select
object_type
,
object_schema
,
object_name
from
performance_schema
.
objects_summary_global_by_type
where
object_schema
=
"test"
;
sql/sql_table.cc
View file @
ed5d675c
...
@@ -10956,6 +10956,8 @@ do_continue:;
...
@@ -10956,6 +10956,8 @@ do_continue:;
{
{
/* The original table is the backup */
/* The original table is the backup */
backup_name
=
alter_ctx
.
table_name
;
backup_name
=
alter_ctx
.
table_name
;
PSI_CALL_drop_table_share
(
0
,
alter_ctx
.
db
.
str
,
(
int
)
alter_ctx
.
db
.
length
,
alter_ctx
.
table_name
.
str
,
(
int
)
alter_ctx
.
table_name
.
length
);
}
}
// Rename the new table to the correct name.
// Rename the new table to the correct name.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment