1. 14 Apr, 2021 4 commits
  2. 13 Apr, 2021 2 commits
  3. 12 Apr, 2021 8 commits
    • Dmitriy Karpovskiy's avatar
      MDEV-24135: Print warnings in XML, save test retries in XML, save the... · f776fa96
      Dmitriy Karpovskiy authored
      MDEV-24135: Print warnings in XML, save test retries in XML, save the combinations in XML, replace the special symbols in the XML comment
      f776fa96
    • Oleksandr Byelkin's avatar
      MDEV-25182 Complex query in Store procedure corrupts results · 68e0defc
      Oleksandr Byelkin authored
      At the second execution of the PS
      1. mark_as_dependent() is called with the same parameters as at the first
         execution (select#4 and select#3)
      2. as outer_select (select#3) has been already merged at the first
         execution of PS it cannot be reached using the outer_select() function
         anymore (and so can not stop iteration).
      3. as a result all selects towards the top level select including the
         select for 'ca' are marked as uncacheable.
      4. Marked uncacheable it executed incorrectly triggering filling its
         temporary table several times and using freed memory at the end.
      
      To avoid the problem we use name resolution context to go "up".
      
      NOTE: problem also exists in 10.2 but has no visible effect on execution.
      That is why the problem is fixed in 10.2.
      
      The patch also add debug logging of important procedures and
      better specify parameters types of st_select_lex::mark_as_dependent.
      68e0defc
    • Dmitry Shulga's avatar
      MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning... · f8bf2a01
      Dmitry Shulga authored
      MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning in case it is executed in PS (prepared statement) mode
      
      The EXPLAIN EXTENDED statement run as a prepared statement can produce extra
      warning comparing with a case when EXPLAIN EXTENDED statement is run as
      a regular statement. For example, the following test case
        CREATE TABLE t1 (c int);
        CREATE TABLE t2 (d int);
        EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1;
      
      produces the extra warning
        "Field or reference 'c' of SELECT #2 was resolved in SELECT #1"
      in case the above mentioned "EXPLAIN EXTENDED" statement is executed
      in PS mode, that is by submitting the following statements:
         PREPARE stmt FROM "EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1";
         EXECUTE stmt;
      
      The reason of the extra warning emittion is in a way items
      are handled (being fixed) during execution of the JOIN::prepare() method.
      The method Item_field::fix_fields() calls the find_field_in_tables()
      function in case a field hasn't been associated yet with the item.
      Implementation of the find_field_in_tables() function first checks whether
      a table containing the required field was already opened and cached.
      It is done by checking the data member item->cached_table. This data member
      is set on handling the PRERARE FROM statement and checked on executing
      the EXECUTE statement. If the data member item->cached_table is set
      the find_field_in_tables() function invoked and the
      mark_select_range_as_dependent() function called if the field
      is an outer referencee. The mark_select_range_as_dependent() function
      calls the mark_as_dependent() function that finally invokes
      the push_warning_printf() function that produces extra warning.
      
      To fix the issue, calling of push_warning_printf() is elimited in case
      it was run indirectly in result of hanlding already opened table from
      the Item_field::fix_fields() method.
      f8bf2a01
    • Julius Goryavsky's avatar
      MDEV-21484: galera_sst_mariabackup_encrypt_with_key test failed · e95cdc45
      Julius Goryavsky authored
      This commit removes the mtr test galera_sst_mariabackup_encrypt_with_key
      from the list of disabled tests because the problem with it has already
      been fixed.
      e95cdc45
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-24971 InnoDB access freed virtual column after rollback of secondary index · cf2c6b7f
      Thirunarayanan Balathandayuthapani authored
      Problem:
      ========
       InnoDB fails to clean the index stub if it fails to add the
      virtual index which contains new virtual column. But it clears
      the newly virtual column from index in clear_added_indexes()
      during inplace_alter_table. On commit, InnoDB evicts and
      reload the table. In case of rollback, it doesn't happen.
      InnoDB clears the ABORTED index while opening the table
      or doing the DDL. In the mean time, InnoDB can access
      the dropped virtual index columns while creating prebuilt
      or rollback of concurrent DML.
      
      Solution:
      ==========
      (1) InnoDB should maintain newly added virtual column while
      rollbacking the newly added virtual index.
      (2) InnoDB must not defer the index removal
      if the alter table is executed with LOCK=EXCLUSIVE.
      (3) For LOCK=SHARED, InnoDB should check whether the table
      has any other transaction lock other than alter transaction
      before deferring the index stub.
      
      Replaced has_new_v_col with dict_add_vcol_info in dict_index_t to
      indicate whether the index has any new virtual column.
      
      dict_index_t::has_new_v_col(): Returns whether the index has
      newly added virtual column, it doesn't say which columns are
      newly added virtual column
      
      ha_innobase_inplace_ctx::is_new_vcol(): Return whether the
      given column is added as a part of the current alter.
      
      ha_innobase_inplace_ctx::clean_new_vcol_index(): Copy the newly
      added virtual column to new_vcol_info in dict_index_t. Replace
      the column in the index fields with virtual column stored
      in new_vcol_info.
      
      dict_index_t::assign_new_v_col(): Store the number of virtual
      column added in index as a part of alter table.
      
      dict_index_t::get_n_new_vcol(): Get the number of newly added
      virtual column
      
      dict_index_t::assign_drop_v_col(): Allocate the memory for
      adding new virtual column in new_vcol_info.
      
      dict_index_t::add_drop_v_col(): Add the newly added virtual
      column in new_vcol_info.
      
      dict_table_t::has_lock_for_other_trx(): Whether the table has
      any other transaction lock than given transaction.
      
      row_merge_drop_indexes(): Add parameter alter_trx and check
      whether the table has any other lock than alter transaction.
      cf2c6b7f
    • Marko Mäkelä's avatar
      MDEV-18802 Assertion table->stat_initialized failed in dict_stats_update_if_needed() · ea2d44d0
      Marko Mäkelä authored
      When a table has been evicted from dict_sys and reloaded internally by
      InnoDB for FOREIGN KEY processing, statistics may not be initialized,
      but nevertheless row_update_cascade_for_mysql() could invoke
      dict_stats_update_if_needed(). In that case, we cannot really update
      the statistics. For tables that have STATS_PERSISTENT=1 and
      STATS_AUTO_RECALC=1, ANALYZE TABLE might have to be executed later.
      
      dict_stats_update_if_needed(): Replace the assertion with
      a conditional early return.
      ea2d44d0
    • Marko Mäkelä's avatar
      MDEV-24434 Assertion trx->in_rw_trx_list... in trx_sys_any_active_transactions() · 75dd7a04
      Marko Mäkelä authored
      trx_sys_any_active_transactions(): Remove a bogus debug assertion.
      In trx_commit_in_memory() and trx_erase_lists(), we will remove
      the transaction from trx_sys->rw_trx_list and set the state to
      TRX_STATE_COMMITTED_IN_MEMORY.
      75dd7a04
    • Otto Kekäläinen's avatar
      Deb: Stop depending on empty transitional package dh-systemd · 058d93d4
      Otto Kekäläinen authored
      MariaDB Server still supports Ubuntu 16.04 "Xenial" until it goes EOL
      in April 30, 2021. Thus we need to include a customization for backwards
      compatibility.
      
      This change is intended to be applied for all MariaDB versions still
      supported, i.e. 10.2 to 10.6.
      058d93d4
  4. 11 Apr, 2021 5 commits
  5. 09 Apr, 2021 2 commits
  6. 08 Apr, 2021 1 commit
  7. 07 Apr, 2021 1 commit
  8. 06 Apr, 2021 2 commits
  9. 03 Apr, 2021 1 commit
  10. 01 Apr, 2021 3 commits
    • Julius Goryavsky's avatar
      MDEV-25321: mariabackup failed if password is passed via environment variable · fb9d1519
      Julius Goryavsky authored
      The mariabackup interface currently supports passing a password
      through an explicit command line variable, but does not support
      passing a password through the MYSQL_PWD environment variable.
      At the same time, the Galera SST script for mariabackup uses
      the environment variable to pass the password, which leads
      (in some cases) to an unsuccessful launch of mariabackup and
      to the inability to start the cluster. This patch fixes this
      issue. It does not need a separate test, as the problem is
      visible in general testing on buildbot.
      fb9d1519
    • Srinidhi Kaushik's avatar
      MDEV-24197: Add "innodb_force_recovery" for "mariabackup --prepare" · 5bc5ecce
      Srinidhi Kaushik authored
      During the prepare phase of restoring backups, "mariabackup" does
      not seem to allow (or recognize) the option "innodb_force_recovery"
      for the embedded InnoDB server instance that it starts.
      
      If page corruption observed during page recovery, the prepare step
      fails. While this is indeed the correct behavior ideally, allowing
      this option to be set in case of emergencies might be useful when
      the current backup is the only copy available. Some error messages
      during "--prepare" suggest to set "innodb_force_recovery" to 1:
      
        [ERROR] InnoDB: Set innodb_force_recovery=1 to ignore corruption.
      
      For backwards compatibility, "mariabackup --innobackupex --apply-log"
      should also have this option.
      Signed-off-by: default avatarSrinidhi Kaushik <shrinidhi.kaushik@gmail.com>
      5bc5ecce
    • mkaruza's avatar
      MDEV-25047: SIGSEGV in mach_read_from_n_little_endian · f93e087d
      mkaruza authored
      Virtual column fields are not found in prebuilt data type, so we should
      match InnoDB fields with `get_innobase_type_from_mysql_type` method.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      f93e087d
  11. 31 Mar, 2021 3 commits
  12. 30 Mar, 2021 8 commits
    • David CARLIER's avatar
      99945d77
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEX · b771ab24
      Thirunarayanan Balathandayuthapani authored
      - Aborting of fulltext index creation fails to remove the
      index from sys indexes table. When we try to reload the
      table definition, InnoDB fails with index count mismatch
      error. InnoDB should remove the index from sys indexes while
      rollbacking the secondary index creation.
      b771ab24
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-15527 page_compressed compressed page partially during import tablespace · 108ba4c3
      Thirunarayanan Balathandayuthapani authored
      - Post push to address 32-bit build failure.
      108ba4c3
    • Marko Mäkelä's avatar
      Add missing have_perfschema.inc · 7c423c26
      Marko Mäkelä authored
      7c423c26
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-15527 page_compressed compressed page partially during import tablespace · c468d5cb
      Thirunarayanan Balathandayuthapani authored
      - Importing table operation fails to punch the hole in
      the filesystem when page compressed table is involved.
      To achieve that, InnoDB firstly punches the hole for
      the IOBuffer size(1MB). After that, InnoDB should write
      page by page when page compression is involved.
      c468d5cb
    • Jan Lindström's avatar
      Add supression for warning. · dfda1c92
      Jan Lindström authored
      dfda1c92
    • Jan Lindström's avatar
      MDEV-24923 : Port selected Galera conflict resolution changes from 10.6 · d217a925
      Jan Lindström authored
      Add condition on trx->state == TRX_STATE_COMMITTED_IN_MEMORY in order to
      avoid unnecessary work. If a transaction has already been committed or
      rolled back, it will release its locks in lock_release() and let
      the waiting thread(s) continue execution.
      
      Let BF wait on lock_rec_has_to_wait and if necessary other BF
      is replayed.
      
      wsrep_trx_order_before
        If BF is not even replicated yet then they are ordered
        correctly.
      
      bg_wsrep_kill_trx
        Make sure victim_trx is found and check also its state. If
        state is TRX_STATE_COMMITTED_IN_MEMORY transaction is
        already committed or rolled back and will release it locks
        soon.
      
      wsrep_assert_no_bf_bf_wait
        Transaction requesting new record lock should be TRX_STATE_ACTIVE
        Conflicting transaction can be in states TRX_STATE_ACTIVE,
        TRX_STATE_COMMITTED_IN_MEMORY or in TRX_STATE_PREPARED.
        If conflicting transaction is already committed in memory or
        prepared we should wait. When transaction is committed in memory we
        held trx mutex, but not lock_sys->mutex. Therefore, we
        could end here before transaction has time to do lock_release()
        that is protected with lock_sys->mutex.
      
      lock_rec_has_to_wait
        We very well can let bf to wait normally as other BF will be
        replayed in case of conflict. For debug builds we will do
        additional sanity checks to catch unsupported bf wait if any.
      
      wsrep_kill_victim
        Check is victim already in TRX_STATE_COMMITTED_IN_MEMORY state and
        if it is we can return.
      
      lock_rec_dequeue_from_page
      lock_rec_unlock
        Remove unnecessary wsrep_assert_no_bf_bf_wait function calls.
        We can very well let BF wait here.
      d217a925
    • Daniel Black's avatar
      remove broken tests/grant.pl · c4427332
      Daniel Black authored
      c4427332