1. 29 May, 2006 1 commit
    • evgen@moonbone.local's avatar
      Fixed bug#18360: Incorrect type coercion in IN() results in false comparison · 641f852d
      evgen@moonbone.local authored
      The IN() function uses agg_cmp_type() to aggregate all types of its arguments
      to find out some common type for comparisons. In this particular case the 
      char() and the int was aggregated to double because char() can contain values
      like '1.5'. But all strings which do not start from a digit are converted to
      0. thus 'a' and 'z' become equal. 
      This behaviour is reasonable when all function arguments are constants. But 
      when there is a field or an expression this can lead to false comparisons. In
      this case it makes more sense to coerce constants to the type of the field
      argument.
      
      The agg_cmp_type() function now aggregates types of constant and non-constant
      items separately. If some non-constant items will be found then their
      aggregated type will be returned. Thus after the aggregation constants will be
      coerced to the aggregated type. 
      641f852d
  2. 27 Apr, 2006 1 commit
  3. 26 Apr, 2006 8 commits
  4. 25 Apr, 2006 4 commits
  5. 24 Apr, 2006 5 commits
  6. 23 Apr, 2006 3 commits
  7. 21 Apr, 2006 5 commits
  8. 20 Apr, 2006 3 commits
  9. 19 Apr, 2006 6 commits
    • igor@rurik.mysql.com's avatar
      Temporarily commented out a query from the test case for bug 14169 to make it... · 67458961
      igor@rurik.mysql.com authored
      Temporarily commented out a query from the test case for bug 14169 to make it pass with --ps-protocol.
      67458961
    • igor@rurik.mysql.com's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1 · 881b55d5
      igor@rurik.mysql.com authored
      into  rurik.mysql.com:/home/igor/dev/mysql-4.1-2
      881b55d5
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · f89daa2f
      evgen@moonbone.local authored
      into moonbone.local:/work/14169-bug-4.1-mysql
      f89daa2f
    • evgen@moonbone.local's avatar
      func_gconcat.result: · 8b4eae6e
      evgen@moonbone.local authored
        Corrected test case for the bug#14169 to make it pass in --ps-protocol mode.
      8b4eae6e
    • svoj@april.(none)'s avatar
      Bug#18544 - LOCK TABLES timeout causes MyISAM table corruption · 806cd415
      svoj@april.(none) authored
      After a locking error the open table(s) were not fully
      cleaned up for reuse. But they were put into the open table
      cache even before the lock was tried. The next statement
      reused the table(s) with a wrong lock type set up. This
      tricked MyISAM into believing that it don't need to update
      the table statistics. Hence CHECK TABLE reported a mismatch
      of record count and table size.
      
      Fortunately nothing worse has been detected yet. The effect
      of the test case was that the insert worked on a read locked
      table. (!)
      
      I added a new function that clears the lock type from all
      tables that were prepared for a lock. I call this function
      when a lock failes.
      
      No test case. One test would add 50 seconds to the
      test suite. Another test requires file mode modifications.
      I added a test script to the bug report. It contains three
      cases for failing locks. All could reproduce a table
      corruption. All are fixed by this patch.
      
      This bug was not lock timeout specific.
      806cd415
    • igor@rurik.mysql.com's avatar
      Fixed bug #19079. · 950214ab
      igor@rurik.mysql.com authored
      The bug caused a reported index corruption in the cases when
      key_cache_block_size was not a multiple of myisam_block_size,
      e.g. when key_cache_block_size=1536 while myisam_block_size=1024.
      950214ab
  10. 18 Apr, 2006 4 commits