1. 25 Nov, 2016 1 commit
    • Otto Kekäläinen's avatar
      Deb: skip invoke-rc.d mysql stop if no mysql process is running at all · 89236a8a
      Otto Kekäläinen authored
      Quite often in upgrades on systemd systems dpkg emitted an error like:
      
        Failed to stop mysql.service: Unit mysql.service not loaded.
        invoke-rc.d: initscript mysql, action "stop" failed.
        invoke-rc.d returned 5
        There is a MySQL server running, but we failed in our attempts to stop it.
        Stop it yourself and try again!
        dpkg: error processing archive /var/cache/apt/archives/mariadb-server-10.2
      
      This is because the mariadb/mysql.service file is not loaded during
      the upgrade/unpack stage of dpkg in certain situations. With this simple
      check we can easily skip the shutdown step when it is really not needed,
      which is for sure the case if no mysqld process at all is running on the
      entire system.
      89236a8a
  2. 24 Nov, 2016 1 commit
    • Lawrin Novitsky's avatar
      Made all capability bit constants to be ULL. All new MariaDB · e726ae6b
      Lawrin Novitsky authored
      capabilities(in upper 32bits) were sent as 0 on 32bit Windows. They were
      reset because CLIENT_SSL, CLIENT_COMPRESS and CLIENT_SSL_VERIFY_SERVER_CERT were defined as UL
      Plus MARIADB_CLIENT_STMT_BULK_OPERATIONS was defined as 1UL << 34, and that is undefined operation.
      e726ae6b
  3. 23 Nov, 2016 1 commit
    • Igor Babaev's avatar
      Fixed bug mdev-11315. · f4d6f26a
      Igor Babaev authored
      There were no implementations for the virtual functions
      exclusive_dependence_on_table_processor and
      exclusive_dependence_on_table_processor. As a result
      the procedure pushdown_cond_for_derived erroneously
      detected some conditions with outer references as pushable
      into materialized view / derived table.
      f4d6f26a
  4. 22 Nov, 2016 1 commit
  5. 21 Nov, 2016 7 commits
    • Nirbhay Choubey's avatar
      MDEV-10792: Assertion `thd->mdl_context.is_lock_owner .. · 4a27ab23
      Nirbhay Choubey authored
      .. (MDL_key::TABLE, table->db, table->table_name, MDL_SHARED)'
      failed in mysql_rm_table_no_locks
      
      Reset error flag after temporary table has been
      successfully dropped.
      4a27ab23
    • Nirbhay Choubey's avatar
      MDEV-10442: "Address already in use" on restart · ebe06190
      Nirbhay Choubey authored
      SST processes should inherit mysqld's process group.
      ebe06190
    • Nirbhay Choubey's avatar
      44ccb8f2
    • Bernard Spil's avatar
      Implement native/base process checks for FreeBSD · cf1b0c1a
      Bernard Spil authored
        - Make rsync process checks OS-dependent
        - Use (BSD) netstat on FreeBSD (not lsof)
      cf1b0c1a
    • Bernard Spil's avatar
      POSIX-ify wsrep scripts · f16ead51
      Bernard Spil authored
        - Replace #!/bin/bash with #!/bin/sh
        - Split username:password using POSIX compat %% and ##
        - Don't use array for FILTERS
        - Replace == tests with POSIX-compat =
      f16ead51
    • Igor Babaev's avatar
      Fixed bug mdev-11081. · 665045f9
      Igor Babaev authored
      The idea of this fix was taken from the patch by Roy Lyseng
      for mysql-5.6 bug iBug#14740889: "Wrong result for aggregate
      functions when executing query through cursor".
      
      Here's Roy's comment for his patch:
      "
      The problem was that a grouped query did not behave properly when
      executed using a cursor. On further inspection, the query used one
      intermediate temporary table for the grouping.
      Then, Select_materialize::send_result_set_metadata created a temporary
      table for storing the query result. Notice that get_unit_column_types()
      is used to retrieve column meta-data for the query. The items contained
      in this list are later modified so that their result_field points to
      the row buffer of the materialized temporary table for the cursor.
      But prior to this, these result_field objects have been prepared for
      use in the grouping operation, by JOIN::make_tmp_tables_info(), hence
      the grouping operation operates on wrong column buffers.
      
      The problem is solved by using the list JOIN::fields when copying data
      to the materialized table. This list is set by JOIN::make_tmp_tables_info()
      and points to the columns of the last intermediate temporary table of
      the executed query. For a UNION, it points to the temporary table
      that is the result of the UNION query.
      
      Notice that we have to assign a value to ::fields early in JOIN::optimize()
      in case the optimization shortcuts due to a const plan detection.
      
      A more optimal solution might be to avoid creating the final temporary
      table when the query result is already stored in a temporary table.
      "
      The patch does not contain a test case, but the description of the
      problem corresponds exactly what could be observed in the test
      case for mdev-11081.
      665045f9
    • Kristian Nielsen's avatar
  6. 20 Nov, 2016 8 commits
    • Sergei Petrunia's avatar
      Update the testcase for MDEV-10330 · 58532f36
      Sergei Petrunia authored
      Instead of restart_mysqld.inc, truncate the P_S tables that are used
      by the test. We don't want to query some irrelevant data.
      58532f36
    • Kristian Nielsen's avatar
      Fix use of `require` in mysql-test-run. · f77bd5fa
      Kristian Nielsen authored
      The motivation for this is that Perl is moving towards not having
      current directory ./ in @INC by default. This is causing
      mysql-test-run.pl to fail in latest Debian Unstable:
      
        https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html
      
      However, we have `use "lib"`, there is no need for current directory
      in @INC, except for a gross hack. In mtr_cases.pm, there is a
      `require "mtr_misc.pl"`, which hides mtr_misc.pl away in mtr_cases
      namespace. And things only work because mysql-test-run.pl loads it
      with a different name, `require "lib/mtr_misc.pl"`! (Perl will
      `require` only once for each unique filename).
      
      Fix this by only using `require` in main program, and referencing
      functions with :: scope from other namespaces. For multi-use in
      different namespaces, proper `use` modules should be used.
      Signed-off-by: default avatarKristian Nielsen <knielsen@knielsen-hq.org>
      f77bd5fa
    • Otto Kekäläinen's avatar
      Deb: provide the libmysqlclient shim packages that exist in Debian/Ubuntu · d49cffa1
      Otto Kekäläinen authored
      This way all 3rd party apps configured to build against any MySQL or
      MariaDB version will pick up the libmariadb3-dev package instead.
      d49cffa1
    • Otto Kekäläinen's avatar
      Deb: make libmariadb3 to provide the libmariadbclient.so.18 link · dcfe6cb8
      Otto Kekäläinen authored
      In Debian many existing applications in Debian/Ubuntu have been built
      while libmariadbclient-dev or libmariadbclient-dev-compat was installed.
      
      To satisfy installation dependencies, the package name libmariadbclient18
      must be provided, and at runtime a shared library must by the name
      libmariadbclient.so.18.
      
      Provide these to remain backwards compatible.
      dcfe6cb8
    • Otto Kekäläinen's avatar
      Deb: rename client library packages to reflect its contents · 2bcc16c1
      Otto Kekäläinen authored
      The new library name libmariadb3 matches the libmariadb.so.3 filename.
      Packages that want to build against MariaDB Connector C have as
      build-dependency libmariadb-dev and as run-time dependency libmariadb3.
      
      Make the package provide libmariadbclient18 for backwards compatibility,
      though compatibility is not always assured. There library did change
      to a whole new generation after all, even though ABI compatibility has
      been a design goal.
      
      Also do the equivalent change for the -dev package. Packages that
      explicitly want to use the MariaDB Connector C should mark it as
      their build-depends.
      
      Also provide an empty libmariadbclient18 metapackage to facilitate
      upgrades from old MariaDB installs, just like there is an empty
      libmysqlclient18 package. Create more of these in the future as needed.
      2bcc16c1
    • Otto Kekäläinen's avatar
      Deb: provide the default-mysql-* packages that exist in Debian/Ubuntu · 54bd67a4
      Otto Kekäläinen authored
      Since Debian 9 (Stretch) and Ubuntu 16.10 (Yakkety) the following
      packages have existed:
      * virtual-mysql-client
      * virtual-mysql-client-core
      * virtual-mysql-server
      * virtual-mysql-server-core
      * virtual-libmysqlclient-dev
      
      They are metapackages that in Debian depend on MariaDB and in
      Ubuntu currently on MySQL. We need to provide them and point
      them to MariaDB so that systems that have the mariadb.org
      repositories enabled automatically get everything MariaDB
      and not MySQL.
      
      This change makes the packaging provide the four first ones,
      and later commits will fix the client library issues.
      54bd67a4
    • Otto Kekäläinen's avatar
      df8ba7a3
    • Otto Kekäläinen's avatar
  7. 19 Nov, 2016 2 commits
  8. 18 Nov, 2016 4 commits
  9. 17 Nov, 2016 5 commits
    • Sergey Vojtovich's avatar
      Update libmariadb · 84fd0bc4
      Sergey Vojtovich authored
      84fd0bc4
    • Sergey Vojtovich's avatar
      Mark spider tests big · e1caf318
      Sergey Vojtovich authored
      Due to high memory reqirements spider tests fail often on automated testing
      VM's due to rather limited resource allocation.
      
      For example with 10.2 spider needs at least 200M * 8 mysqld instances = 1.6Gb
      RAM per mtr instance. With --parallel=4 it needs 6.4Gb, while appropriate hosts
      have just 3Gb.
      e1caf318
    • Daniel Black's avatar
      MDEV-5725: mysqld embedded libraries into libmariadbd19 Deb package · 7072ca1f
      Daniel Black authored
      libmariadbd19 was intended to be added as the package that
      included the libmysqld shared library. This was missing
      from the debian control file.
      
      The libmariadbd-dev package requires libmariadbd19 to provide
      the shared library.
      
      The shared libraries for embedded mysql will go into the libmariadbd18
      package rather than the libmariadbd-dev development package.
      
      /usr/bin/mariadb_config is a executable that assists embedded developers
      to use the correctly correct header and library files during their
      development.
      Signed-off-by: default avatarDaniel Black <daniel.black@au.ibm.com>
      7072ca1f
    • Daniel Black's avatar
      MDEV-5725: Don't install private mysql header files · 2387c91b
      Daniel Black authored
      Previously private/*.h where included in the package. These represent internal
      mysqld structures that aren't guarenteed to provide a stable ABI.
      
      There aren't intended to be used by embedded mysqld applications so
      they have been removed.
      Signed-off-by: default avatarDaniel Black <daniel.black@au.ibm.com>
      2387c91b
    • Igor Babaev's avatar
      Fixed bug mdev-11103. · 691214ae
      Igor Babaev authored
      The class Item_func_nop_all missed an implementation
      of the virtual method get_copy.
      As a result if the condition that can be pushed into
      into a materialized view / derived table contained
      an ANY subselect then the pushdown condition was built
      incorrectly.
      691214ae
  10. 16 Nov, 2016 6 commits
  11. 15 Nov, 2016 4 commits
    • Igor Babaev's avatar
      Made the result output deterministic. · 0b869814
      Igor Babaev authored
      0b869814
    • Igor Babaev's avatar
      Fixed bug mdev-11072. · 68e7d92c
      Igor Babaev authored
      In a general case the conditions with outer fields cannot
      be pushed into materialized views / derived tables.
      However if the outer field in the condition refers to a
      single row table then the condition may be pushable.
      In this case a special care should be taken for outer
      fields when pushing the condition into a materialized view /
      derived table.
      68e7d92c
    • Alexey Botchkov's avatar
      MDEV-9143 JSON_xxx functions. · ebe5ebba
      Alexey Botchkov authored
              The rest of mysql/json functions implemented.
              CAST AS JSON implemented.
      ebe5ebba
    • Sergey Vojtovich's avatar
      InnoDB cleanups · 1122c1f0
      Sergey Vojtovich authored
      - added missing backslash
      - removed duplicate definition of UT_LOW_PRIORITY_CPU/UT_RESUME_PRIORITY_CPU
      - removed duplicate UT_RESUME_PRIORITY_CPU call
      1122c1f0