- 22 Sep, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 17 Sep, 2015 1 commit
-
-
Nirbhay Choubey authored
Problem: When mysqld starts as a galera node, it creates 2 system threads (applier & rollbacker) using start_wsrep_THD(). These threads are created before plugin initialization (plugin_init()) for SST methods like rsync and xtrabackup. The threads' initialization itself can proceed in parallel to mysqld's main thread of execution. As a result, the thread initialization code (start_wsrep_THD()) can end up accessing some un/partially initialized structures (like maria_hton, in this particular case) resulting in segfault. Solution: Fixed by calling THD::init_for_queries() (which accesses maria_hton) only after the plugins have been initialized.
-
- 15 Sep, 2015 2 commits
-
-
Nirbhay Choubey authored
* Merge fix for issue #127 from mysql-wsrep (commit : a0ba0d7) * Also, cherry-picked a similar fix for OpenSUSE (commit : 7790cb1)
-
Nirbhay Choubey authored
Add 'bootstrap' to debian init script.
-
- 09 Sep, 2015 11 commits
-
-
Nirbhay Choubey authored
-
Philip Stoev authored
-
Philip Stoev authored
-
Alexey Yurchenko authored
-
Alexey Yurchenko authored
-
Alexey Yurchenko authored
- errno handling in wsp::env::append() method, where error could be returned by mistake - return code of sst_prepare_other() when pthread_create() fails - it was returning positive error code which by convention is treated as success.
-
Alexey Yurchenko authored
-
Philip Stoev authored
-
Alexey Yurchenko authored
Synced xtrabackup SST fixes from Percona tree (as of PXC 5.6.24-25.11 release). This fixes/adresses the following LP bugs: - LP1380697: wsrep_sst_xtrabackup-v2 doesn't stop when mysql is SIGKILLed. (full fix for this (as engineeered by Percona) requires Linux-specific patch that we don't carry, but keep xtrabackup scripts as close as possible) - LP1399134: Log the innobackupex/SST logs in SST to syslog if possible. (fixed) - LP1405668: Race condition between donor and joiner in PXB SST. (fixed) - LP1405985: Fail early if xtrabackup_checkkpoints is missing. (fixed) - LP1407599: wsrep_sst_xtrabackup-v2 script causes innobackupex to print a false positive stack trace into the log. (fixed) - LP1441762: IST Fails with SST script error. (fixed) - LP1451670: Fail when move-back fails in xtrabackup SST. (fixed)
-
Alexey Yurchenko authored
1. Passes wsrep_sst_auth_value to SST scripts via WSREP_SST_OPT_AUTH envronmental variable, so it never appears on the command line 2. In mysqldump and xtrabackup* SST scripts which rely on MySQL authentication, instead of passing password on the command line, SST script sets MYSQL_PWD environment variable, so that password also never appears on the mysqldump/innobackupex command line.
-
Alexey Yurchenko authored
-
- 22 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
Do not replicate commands from check-warnings.test to other nodes in the cluster.
-
- 21 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
When wsrep is enabled, for any update on innodb tables, the corresponding keys are appended to galera's transaction writeset (wsrep_append_keys()). However, for LOAD DATA, this got skipped if binary logging was disabled or it was non-ROW based. As a result, while the updates from LOAD DATA on non-partitioned tables replicated fine as wsrep implicitly enables binary logging (if not enabled, explicitly), the same did not work on partitioned tables as for partitioned tables the binary logging gets disabled temporarily (ha_partition::write_row()). Fixed by removing the unwanted conditions from the check. Also backported some changes from 10.0-galera to make sure wsrep_load_data_splitting affects LOAD DATA commands only.
-
- 20 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 18 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 14 Aug, 2015 2 commits
-
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
In galera cluster, when myisam replication is enabled (wsrep_replicate_myisam=ON), DML statements are replicated in open_tables(). However, in case of prepared statements, for an INSERT, open_tables() gets invoked twice. Once for COM_STMT_PREPARE (to validate and prepare INSERT) and later for COM_STMT_EXECUTE. As a result, the command gets replicated twice. Same happens for REPLACE, UPDATE and DELETE commands. Fixed by adding a check to not replicate during 'prepare' phase. Also changed the order of conditions to make it more efficient. Lastly, in order to support wsrep_dirty_reads, made changes to allow COM_STMT_XXX commands to continue past initial check even when wsrep is not ready.
-
- 12 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
RENAME TABLE, unlike other DDLs, was getting replicated before the access check was performed. As a result, the command could get get replicated and thus executed on other nodes, even if it fails on the originating node due to permission issues. Fixed by moving the logic to check user privileges before replicating the command.
-
- 07 Aug, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 04 Aug, 2015 1 commit
-
-
Sergei Golubchik authored
-
- 03 Aug, 2015 1 commit
-
-
Sergei Petrunia authored
THD::>save_prep_leaf_list was set to true by multi-table update statements with mergeable selects and never reset. Make every statement reset it at start.
-
- 01 Aug, 2015 3 commits
-
-
Sergei Golubchik authored
5.5.44-37.3
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 31 Jul, 2015 10 commits
-
-
Sergei Golubchik authored
Correct fix for this bug. The problem was that Item_func_group_concat() was calling setup_order(), passing args as the second argument, ref_pointer_array. While ref_pointer_array should have free space at the end, as setup_order() can append elements to it. In this particular case args[] elements were overwritten when setup_order() was pushing new elements into ref_pointer_array.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Cherry-pick from 10.0: commit 126523d1 Author: Sergei Golubchik <serg@mariadb.org> Date: Mon Feb 23 20:53:41 2015 +0100 MDEV-6703 Add "mysqlbinlog --binlog-row-event-max-size" support
-
Sergei Golubchik authored
Alternative fix that doesn't cause view.test crash in --ps: Remember when Item_ref was fixed right in the constructor and did not have a full Item_ref::fix_fields() call. Later in PS/SP, after Item_ref::cleanup, we use this knowledge to avoid doing full fix_fields() for items that were never supposed to be fix_field'ed. Simplify the test case.
-
Sergei Golubchik authored
-
Sergey Vojtovich authored
Let mysql_upgrade return zero exit status when installation is up to date.
-
Jan Lindström authored
-
Sergey Vojtovich authored
execution of PS GROUP_CONCAT() with ORDER BY column position may crash server on PS reexecution. The problem was that arguments array of GROUP_CONCAT() was adjusted to point to temporary elements (resolved ORDER BY fields) during first execution. This patch expands rev. 08763096 to restore original arguments array as well.
-
Jan Lindström authored
There is several different ways to incorrectly define foreign key constraint. In many cases earlier MariaDB versions the error messages produced by these cases are not very clear and helpful. This patch improves the warning messages produced by foreign key parsing.
-
Jan Lindström authored
Added better error message that will be printed when foreign key constraint name in create table is not unique in database.
-
- 29 Jul, 2015 1 commit
-
-
Sergey Vojtovich authored
GET_LOCK() silently accepted negative values and NULL for timeout. Fixed GET_LOCK() to issue a warning and return NULL in such cases.
-
- 25 Jul, 2015 1 commit
-
-
Monty authored
Fixed memory loss detected on P8. This can happen when we call after_flush but never call after_rollback() or after_commit(). The old code used pthread_setspecific() to store temporary data used by the thread. This is not safe when used with thread pool, as the thread may change for the transaction. The fix is to save the data in THD, which is guaranteed to be properly freed. I also fixed the code so that we don't do a malloc() for every transaction.
-