1. 11 Jan, 2018 1 commit
    • Marko Mäkelä's avatar
      MDEV-14916 InnoDB reports warning for "Purge reached the head of the history list" · bdcd7f79
      Marko Mäkelä authored
      The warning was originally added in
      commit c6766305
      (MySQL 4.1.12, 5.0.3) to trace claimed undo log corruption that
      was analyzed in https://lists.mysql.com/mysql/176250
      on November 9, 2004.
      
      Originally, the limit was 20,000 undo log headers or transactions,
      but in commit 9d6d1902
      in MySQL 5.5.11 it was increased to 2,000,000.
      
      The message can be triggered when the progress of purge is prevented
      by a long-running transaction (or just an idle transaction whose
      read view was started a long time ago), by running many transactions
      that UPDATE or DELETE some records, then starting another transaction
      with a read view, and finally by executing more than 2,000,000
      transactions that UPDATE or DELETE records in InnoDB tables. Finally,
      when the oldest long-running transaction is completed, purge would
      run up to the next-oldest transaction, and there would still be more
      than 2,000,000 transactions to purge.
      
      Because the message can be triggered when the database is obviously
      not corrupted, it should be removed. Heavy users of InnoDB should be
      monitoring the "History list length" in SHOW ENGINE INNODB STATUS;
      there is no need to spam the error log.
      bdcd7f79
  2. 10 Jan, 2018 3 commits
  3. 03 Jan, 2018 1 commit
  4. 02 Jan, 2018 2 commits
    • Marko Mäkelä's avatar
      Follow-up to MDEV-14799: Remove bogus debug assertions · 20fab71b
      Marko Mäkelä authored
      trx_undo_rec_get_partial_row(): When the PRIMARY KEY includes a
      column prefix of an externally stored column, the already parsed
      part of the undo log record may contain a reference to
      an off-page column. This is the case in the bug58912 test in
      innodb.innodb.
      20fab71b
    • Marko Mäkelä's avatar
      MDEV-14799 After UPDATE of indexed columns, old values will not be purged from secondary indexes · d384ead0
      Marko Mäkelä authored
      This is a regression caused by MDEV-14051 'Undo log record is too big.'
      
      Purge in the secondary index is wrongly skipped in
      row_purge_upd_exist_or_extern() because node->row only does not contain all
      indexed columns.
      
      trx_undo_rec_get_partial_row(): Add the parameter for node->update
      so that the updated columns will be copied from the initial part
      of the undo log record.
      d384ead0
  5. 27 Dec, 2017 2 commits
  6. 20 Dec, 2017 1 commit
    • Varun Gupta's avatar
      MDEV-12350: Heap corruption, overrun buffer, ASAN errors, server crash in my_fill_8bit / filesort · 924db8b4
      Varun Gupta authored
      In the function make_sortkey a tmp buffer was defined and in the absence of
      param->tmp_buffer, tmp buffer used the sort_keys buffer. sort_keys buffer
      has a length defined in sort_field->length, while param->tmp_buffer is
      stored in param->rec_length. Make sure to use the appropriate length
      based on which buffer we are using otherwise we'll overflow.
      
      Also added a type cast to size_t during the calculation of the sort keys
      buffer size to avoid an oveflow if the buffer size exceeds 32 bits.
      924db8b4
  7. 19 Dec, 2017 1 commit
  8. 16 Dec, 2017 1 commit
  9. 08 Dec, 2017 1 commit
  10. 06 Dec, 2017 1 commit
  11. 05 Dec, 2017 1 commit
  12. 30 Nov, 2017 1 commit
  13. 20 Nov, 2017 1 commit
  14. 16 Nov, 2017 2 commits
  15. 11 Nov, 2017 1 commit
    • Igor Babaev's avatar
      Fixed bug MDEV-14368 Improper error for a grouping query that · b5cb4ae4
      Igor Babaev authored
      uses alias in HAVING when sql_mode = 'ONLY_FULL_GROUP_BY'
      
      This patch corrects the patch for bug#18739: non-standard
      HAVING extension was allowed in strict ANSI sql mode
      added in 2006 by commit 4b7c4cd2.
      As a result of incompleteness of the fix in the above commit
      if a query with GROUP BY contained an aggregate function with an
      alias and this alias was used in the HAVING clause of the query
      the server reported an error when sql_mode was set to
      'ONLY_FULL_GROUP_BY'.
      b5cb4ae4
  16. 10 Nov, 2017 1 commit
  17. 03 Nov, 2017 2 commits
  18. 26 Oct, 2017 1 commit
  19. 24 Oct, 2017 1 commit
    • Marko Mäkelä's avatar
      MDEV-14051 'Undo log record is too big.' error occurring in very narrow range of string lengths · 439a7c99
      Marko Mäkelä authored
      InnoDB was writing unnecessary information to the
      update undo log records. Most notably, if an indexed column is updated,
      the old value of the column would be logged twice: first as part of
      the update vector, and then another time because it is an indexed column.
      
      Because the InnoDB undo log record must fit in a single page,
      this would cause unnecessary failure of certain updates.
      
      Even after this fix, InnoDB still seems to be unnecessarily logging
      indexed column values for non-updated columns. It seems that non-updated
      secondary index columns only need to be logged when a PRIMARY KEY
      column is updated. To reduce risk, we are not fixing this remaining flaw
      in GA versions.
      
      trx_undo_page_report_modify(): Log updated indexed columns only once.
      439a7c99
  20. 18 Oct, 2017 1 commit
  21. 17 Oct, 2017 8 commits
    • Sergei Golubchik's avatar
      Bug#26361149 MYSQL SERVER CRASHES AT: COL IN(IFNULL(CONST, COL), NAME_CONST('NAME', NULL)) · b000e169
      Sergei Golubchik authored
      based on:
      
      commit f7316aa0
      Author: Ajo Robert <ajo.robert@oracle.com>
      Date:   Thu Aug 24 17:03:21 2017 +0530
      
          Bug#26361149  MYSQL SERVER CRASHES AT: COL IN(IFNULL(CONST,
                                 COL), NAME_CONST('NAME', NULL))
      
          Backport of Bug#19143243 fix.
      
          NAME_CONST item can return NULL_ITEM type in case of incorrect arguments.
          NULL_ITEM has special processing in Item_func_in function.
          In Item_func_in::fix_length_and_dec an array of possible comparators is
          created. Since NAME_CONST function has NULL_ITEM type, corresponding
          array element is empty. Then NAME_CONST is wrapped to ITEM_CACHE.
          ITEM_CACHE can not return proper type(NULL_ITEM) in Item_func_in::val_int(),
          so the NULL_ITEM is attempted compared with an empty comparator.
          The fix is to disable the caching of Item_name_const item.
      b000e169
    • Sergei Golubchik's avatar
      Merge branch 'mysql/5.5' into 5.5 · df5f25fa
      Sergei Golubchik authored
      df5f25fa
    • Sergei Golubchik's avatar
      MDEV-13937 Aria engine: Internal Error 160 after partition handling · b036b6b5
      Sergei Golubchik authored
      Partition wasn't setting HA_OPTION_PACK_RECORD on ALTER TABLE
      if the row format was PAGE.
      
      (so one bit in the null bitmap was reserved for a deleted bit -
      see make_empty_rec - and all actual null bits were one off)
      b036b6b5
    • Sergei Golubchik's avatar
      MDEV-14056 DROP TEMPORARY TABLE IF EXISTS causes error 1290 with read_only option · 19a702a8
      Sergei Golubchik authored
      if it's a DROP TABLE, we cannot detect whether a table is
      temporary by looking in thd->temporary_tables - because the
      table might simply not exist at all.
      19a702a8
    • Sergei Golubchik's avatar
      MDEV-13912 Can't refer the same column twice in one ALTER TABLE · 42171639
      Sergei Golubchik authored
      backport ce6c0e58
      
      MDEV-8960: Can't refer the same column twice in one ALTER TABLE
      
      Problem was that if column was created in alter table when
      it was refered again it was not tried to find from list
      of current columns.
      
      mysql_prepare_alter_table:
        There is two cases
          (1) If alter table adds a new column and then later alter
              changes the field definition, there was no check from
      	list of new columns, instead an incorrect error was given.
          (2) If alter table adds a new column and then later alter
              changes the default, there was no check from list of
      	new columns, instead an incorrect error was given.
      42171639
    • Sergei Golubchik's avatar
      MDEV-13440 mysql_install_db fails with hard-coded langdir · 93144b9e
      Sergei Golubchik authored
      always search in compile-time specified paths
      INSTALL_BINDIR, INSTALL_SBINDIR, INSTALL_MYSQLSHAREDIR. User
      can set them to arbitrary values, it's not enough to search only
      in their usual values of bin, sbin and libexec, share and share/mysql.
      93144b9e
    • Sergei Golubchik's avatar
      cleanup mysql_install_db · 52516706
      Sergei Golubchik authored
      1. detect resolveip location, don' assume it's in $basedir/bin
      2. don't guess $scriptdir to (incorrectly) construct the $0 path
      3. rename find_in_basedir -> find_in_dirs, don't prepend $basedir
         automatically. This allows to use identical path lists in
         find_in_dirs and in cannot_find_file.
      4. move search path lists to CMakeLists.txt to avoid specifying the
         same path list twice (in find_in_dirs and in cannot_find_file).
      52516706
    • Sergei Golubchik's avatar
      MDEV-13459 Warnings, when compiling with gcc-7.x · d76f5774
      Sergei Golubchik authored
      mostly caused by -Wimplicit-fallthrough
      d76f5774
  22. 13 Oct, 2017 6 commits