- 17 Sep, 2020 3 commits
-
-
Marko Mäkelä authored
Change buffering will occasionally happen if other pages are not flushed quickly enough.
-
Marko Mäkelä authored
Since commit 8ccb3caa it should be more efficient to use page_id_t rather than two separate variables for tablespace identifier and page number. lock_rec_fold(): Replaced with page_id_t::fold(). lock_rec_hash(): Replaced with lock_sys.hash(page_id). lock_rec_expl_exist_on_page(), lock_rec_get_first_on_page_addr(), lock_rec_get_first_on_page(): Replaced with lock_sys.get_first().
-
Marko Mäkelä authored
The InnoDB buffer block page descriptor is caching a value buf_block_t::lock_hash_val that should be quick to compute in the first place, as suggested by commit 14be8143. lock_rec_fold(): Define as page_id_t::fold() instead of ut_fold_ulint_pair().
-
- 14 Sep, 2020 2 commits
-
-
Sergei Golubchik authored
WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX} means that this path already exists, which is not necessarily the case for make install. Create it `mkdir -p` style.
-
Jan Lindström authored
MDEV-23591 : galera_3nodes.GCF-354 MTR failed: 1047: WSREP has not yet prepared node for application use Stabilize test.
-
- 11 Sep, 2020 1 commit
-
-
Erol Guven authored
-
- 10 Sep, 2020 3 commits
-
-
Sergei Golubchik authored
* use the environment variable HA_S3_SO, not a literal ha_s3 in cnf files * make ConfigFactory to support empty option values * update no_s3.result after MDEV-11412
-
Sergei Golubchik authored
and remove a couple of useless MY_TEST's
-
Sergei Golubchik authored
MDEV-23492 performance_schema_digests_size changing from default to 5000 when enabling performance_schema max allowed value limit should be larger than any auto-sized value
-
- 09 Sep, 2020 14 commits
-
-
Marko Mäkelä authored
-
Jan Lindström authored
MDEV-23608 : galera_sr.GCF-597 MTR failed: query 'ROLLBACK' succeeded - should have failed with errno 1213 Added wait_condition to wait correct streaming state.
-
Jan Lindström authored
MDEV-23611 : galera_sr.galera_sr_kill_query MTR failed: 15 instead of 0 on "SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;" Add wait_condition to stabilize test.
-
Jan Lindström authored
MDEV-23613 : galera_sr.galera_sr_kill_slave MTR failed: query 'LOCK TABLE t2 WRITE' failed: 1146: Table 'test.t2' doesn't exist Remove unnecessary sleeps from test and replace them with proper wait_conditions.
-
Marko Mäkelä authored
-
Jan Lindström authored
MDEV-23592 : galera_3nodes.inconsistency_shutdown MTR failed: Could not open '../galera/include/galera_have_debug_sync.inc' for reading, errno: 2 Correct include path.
-
Jan Lindström authored
Add wait_condition to make sure table is there.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Only starting with MariaDB Server 10.4 we may depend on C++11.
-
Marko Mäkelä authored
dict_foreign_qualify_index(): Reject corrupted or garbage indexes. For index stubs that are created on virtual columns, no dict_field_t::col would be assign. Instead, the entire table definition would be reloaded on a successful operation.
-
Marko Mäkelä authored
Before commit 05fa4558 (MDEV-22110) we have slot->type == MTR_MEMO_MODIFY that are unrelated to incrementing the buffer-fix count. FindBlock::operator(): In debug builds, skip MTR_MEMO_MODIFY entries. Also, simplify the code a little. This fixes an infinite loop in the tests innodb.innodb_defragment and innodb.innodb_wl6326_big.
-
Thirunarayanan Balathandayuthapani authored
buf_page_create() is invoked when page is initialized. So that previous contents of the page ignored. In few cases, it calls buf_page_get_gen() is called to fetch the page from buffer pool. It should take x-latch on the page. If other thread uses the block or block io state is different from BUF_IO_NONE then release the mutex and check the state and buffer fix count again. For compressed page, use the existing free block from LRU list to create new page. Retry to fetch the compressed page if it is in flush list fseg_create(), fseg_create_general(): Introduce block as a parameter where segment header is placed. It is used to avoid repetitive x-latch on the same page Change the assert to check whether the page has SX latch and X latch in all callee function of buf_page_create() mtr_t::get_fix_count(): Get the buffer fix count of the given block added by the mtr FindBlock is added to find the buffer fix count of the given block acquired by the mini-transaction
-
- 08 Sep, 2020 6 commits
-
-
Sergei Petrunia authored
-
Sergei Petrunia authored
-
Daniel Black authored
To ensure that S3 is using its access and secret key in the right way, make these different in the test suite.
-
Daniel Black authored
added plugin-maturity = alpha to s3 mtr cnf files and a missing plugin-load-add=ha_s3 in the slave configuration.
-
Sergei Petrunia authored
Add @@s3_port and @@s3_use_http. One can set these to access the local MinIO, for example.
-
Jan Lindström authored
Drop trigger handling was missing from wsrep_can_run_in_toi in 10.5 for some reason.
-
- 07 Sep, 2020 8 commits
-
-
Aleksey Midenkov authored
Related to 7c2ba9e9: ha_table_exists() is replaced by dd_frm_type(). ha_table_exists() checked the existence of share and that succeeded to enter the execution branch of ha_delete_table() where tdc_remove_table() was called. Now it is skipped because dd_frm_type() returns TABLE_TYPE_UNKNOWN. Fix it by calling tdc_remove_table() in this case as well.
-
Andrei Elkin authored
A mtr failure in rpl.rpl_mariadb_slave_capability mismatch: -slave-relay-bin.000005 # Query # # BEGIN +slave-relay-bin.000005 # Query # # set foreign_key_checks=1, check_constraint_checks=1; BEGIN was fixed by {{80544a58}}, and without any check for {{flags_inited}} which is a pattern in the sources. This ticket therefore merely makes sure through an assert that a relation between the two remain in {{Query_log_event::pack_info}}.
-
Marko Mäkelä authored
An unsafe optimization was introduced by commit 2347ffd8 (MDEV-20301) which is based on mysql/mysql-server@3f3136188f1bd383f77f97823cf6ebd72d5e4d7e or mysql/mysql-server@647a3814a91c3d3bffc70ddff5513398e3f37bd4 in MySQL 8.0.12 or MySQL 8.0.13 (which in turn is based on the contribution in MySQL Bug #84958). Row_sel_get_clust_rec_for_mysql::operator(): In addition to checking that the pointer to the record matches, also check the latest modification of the page (FIL_PAGE_LSN) as well as the page identifier. Only if all three match, it is safe to reuse cached_old_vers. Row_sel_get_clust_rec_for_mysql::check_eq(): Assert that the PRIMARY KEY of the cached old version of the record corresponds to the latest version. We got a test case where CHECK TABLE, UPDATE and purge would be hammering on the same table (with only 6 rows) and a pointer that was originally pointing to a record pk=2 would match a cached_clust_rec that was pointing to a record pk=1. In the diagnosed `rr replay` trace, we would wrongly return an old cached version of the pk=1 record, instead of retrieving the correct version of the pk=2 record. Because of this, CHECK TABLE would fail to count one of the records in a secondary index, and report failure. This bug appears to affect MVCC reads via secondary indexes only. The purge of history in secondary indexes uses a different code path, and so do checks for implicit record locks.
-
Vladislav Vaintroub authored
Fix DBUG_ASSERT
-
Kentoku SHIBA authored
MDEV-7098 spider/bg.spider_fixes failed in buildbot with safe_mutex: Trying to unlock mutex conn->mta_conn_mutex that wasn't locked at storage/spider/spd_db_conn.cc, line 671
-
Kentoku SHIBA authored
MDEV-7098 spider/bg.spider_fixes failed in buildbot with safe_mutex: Trying to unlock mutex conn->mta_conn_mutex that wasn't locked at storage/spider/spd_db_conn.cc, line 671
-
Kentoku SHIBA authored
MDEV-7098 spider/bg.spider_fixes failed in buildbot with safe_mutex: Trying to unlock mutex conn->mta_conn_mutex that wasn't locked at storage/spider/spd_db_conn.cc, line 671
-
Kentoku SHIBA authored
MDEV-7098 spider/bg.spider_fixes failed in buildbot with safe_mutex: Trying to unlock mutex conn->mta_conn_mutex that wasn't locked at storage/spider/spd_db_conn.cc, line 671
-
- 04 Sep, 2020 3 commits
-
-
Vladislav Vaintroub authored
Removed some inine assembly, replaced by code from https://github.com/intel/soft-crc Also,replace GCC inline assembly for cpuid in ut0crc32 with __cpuid, to fix "PIC register clobbered by 'ebx' in 'asm'. This enables fast CRC32C on 32bit Intel processors with GCC.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-