1. 28 Nov, 2022 7 commits
  2. 25 Nov, 2022 3 commits
    • Brandon Nesterenko's avatar
      MDEV-29607: binlog.binlog_checkpoint fails in buildbot with result content mismatch · 812443c2
      Brandon Nesterenko authored
      Problem:
      ========
      There is a race condition in binlog.binlog_checkpoint between the
      binlog background thread creating a binlog checkpoint event, and the
      connection thread binlogging a query event for creating a table.
      Because the test outputs the events for validation, the order
      between these two events can be different, resulting in a failed
      test.
      
      Solution:
      ========
      Instead of outputting the binlog events, use assert_grep to validate
      the content of the binlog is correct.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      812443c2
    • Daniel Black's avatar
      Query cache: removed unused THD from few functions · 7919b143
      Daniel Black authored
      A few query cache functions don't use THD pointer
      so its removed from their interface.
      7919b143
    • Daniel Black's avatar
      MDEV-29760: DROP DATABASE hangs when particular query cache is present · 7141c260
      Daniel Black authored
      Fix the regression introduced in
      dfb41fdd.
      
      In the restructure of mysql_rm_table_no_locks the early condition
      of !frm_error that enabled non_tmp_table_deleted, and hence the
      query cache invalidation, was removed.
      
      The query_cache_invalidate1(thd, dbnorm) called after
      mysql_rm_table_no_locks depends on the query cache removal
      (for unexamined reasons).
      
      Under DROP DATABASE, in mysql_rm_table_no_locks, dont_log_query
      is true preventing the late setting of non_tmp_table_deleted
      (which retained one of its purposes as a replication deletion
      of temporary tables, but not query cache invalidation).
      
      The non_temp_tables_count however can still be used to invalidate
      the query cache.
      7141c260
  3. 24 Nov, 2022 5 commits
  4. 23 Nov, 2022 2 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 6d40274f
      Marko Mäkelä authored
      6d40274f
    • Marko Mäkelä's avatar
      MDEV-30009 InnoDB shutdown hangs when the change buffer is corrupted · 165564d3
      Marko Mäkelä authored
      The InnoDB change buffer (ibuf.index, stored in the system tablespace)
      and the change buffer bitmaps in persistent tablespaces could get out
      of sync with each other: According to the bitmap, no changes exist for
      a page, while there actually exist buffered entries in ibuf.index.
      
      InnoDB performs lazy deletion of buffered changes. When a secondary
      index leaf page is freed (possibly as part of DROP INDEX), any
      buffered changes will not be deleted. Instead, they would be deleted
      on a subsequent buf_page_create_low().
      
      One scenario where InnoDB failed to delete buffered changes is
      as follows:
      1. Some changes were buffered for a secondary index leaf page.
      2. The index page had been freed.
      3. ibuf_read_merge_pages() invoked ibuf_merge_or_delete_for_page(),
      which noticed that the page had been freed, and reset the change buffer
      bits, but did not delete the records from ibuf.index.
      4. The index page was reallocated for something else.
      5. The index page was removed from the buffer pool.
      6. Some changes were buffered for the newly created page.
      7. Finally, the buffered changes from both 1. and 6. were merged.
      8. The index is corrupted.
      
      An alternative outcome is:
      4. Shutdown with innodb_fast_shutdown=0 gets into an infinite loop.
      
      An alternative scenario is:
      3. ibuf_set_bitmap_for_bulk_load() reset the IBUF_BITMAP_BUFFERED bit
      but did not delete the ibuf.index records for that page number.
      
      The shutdown hang was already once fixed in
      commit d7a24017, refactored for
      10.5 in commit 77e8a311 and
      disabled in commit 310dff5d
      due to corruption.
      
      We will fix this as follows:
      
      ibuf_delete_recs(): Delete all ibuf.index entries for the specified page.
      
      ibuf_merge_or_delete_for_page(): When the change buffer bitmap bits
      were set and the page had been freed, and the page does not belong
      to ibuf.index itself, invoke ibuf_delete_recs(). This prevents the
      corruption from occurring when a DML operation is allocating a
      previously freed page for which changes had been buffered.
      
      ibuf_set_bitmap_for_bulk_load(): When the change buffer bitmap bits
      were set, invoke ibuf_delete_recs(). This prevents the corruption
      from occurring when CREATE INDEX is reusing a previously freed page.
      
      ibuf_read_merge_pages(): On slow shutdown, remove the orphan records
      by invoking ibuf_delete_recs(). This fixes the hang when the change
      buffer had become corrupted. We also remove the dops[] accounting,
      because nothing can monitor it during shutdown. We invoke
      ibuf_delete_recs() if:
      (a) buf_page_get_gen() failed to load the page or merge changes
      (b) the page is not a valid index leaf page
      (c) the page number is out of tablespace bounds
      
      srv_shutdown(): Invoke ibuf_max_size_update(0) to ensure that
      the race condition that motivated us to disable the code in
      ibuf_read_merge_pages() in commit 310dff5d
      is no longer possible. That is, during slow shutdown, both the
      rollback of transactions and the purge of history will return
      early from ibuf_insert_low().
      
      ibuf_merge_space(), ibuf_delete_for_discarded_space(): Cleanup:
      Do not allocate a memory heap.
      
      This was implemented by Thirunarayanan Balathandayuthapani
      and tested with innodb_change_buffering_debug=1 by Matthias Leich.
      165564d3
  5. 22 Nov, 2022 3 commits
  6. 21 Nov, 2022 8 commits
  7. 20 Nov, 2022 4 commits
  8. 17 Nov, 2022 4 commits
    • Marko Mäkelä's avatar
      Merge 10.6 into 10.7 · d5332086
      Marko Mäkelä authored
      d5332086
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 9aea7d83
      Marko Mäkelä authored
      9aea7d83
    • Marko Mäkelä's avatar
      MDEV-29982 fixup: Relax the test · 41028d70
      Marko Mäkelä authored
      The log overwrite warnings are not being reliably emitted in all
      debug-instrumented environments. It may be related to the
      scheduling of some InnoDB internal activity, such as the purging
      of committed transaction history.
      41028d70
    • Marko Mäkelä's avatar
      MDEV-29603 btr_cur_open_at_index_side() is missing some consistency checks · 24fe5347
      Marko Mäkelä authored
      btr_cur_t: Zero-initialize all fields in the default constructor.
      
      btr_cur_t::index: Remove; it duplicated page_cur.index.
      
      Many functions: Remove arguments that were duplicating
      page_cur_t::index and page_cur_t::block.
      
      page_cur_open_level(), btr_pcur_open_level(): Replaces
      btr_cur_open_at_index_side() for dict_stats_analyze_index().
      At the end, release all latches except the dict_index_t::lock
      and the buf_page_t::lock on the requested page.
      
      dict_stats_analyze_index(): Rely on mtr_t::rollback_to_savepoint()
      to release all uninteresting page latches.
      
      btr_search_guess_on_hash(): Simplify the logic, and invoke
      mtr_t::rollback_to_savepoint().
      
      We will use plain C++ std::vector<mtr_memo_slot_t> for mtr_t::m_memo.
      In this way, we can avoid setting mtr_memo_slot_t::object to nullptr
      and instead just remove garbage from m_memo.
      
      mtr_t::rollback_to_savepoint(): Shrink the vector. We will be needing this
      in dict_stats_analyze_index(), where we will release page latches and
      only retain the index->lock in mtr_t::m_memo.
      
      mtr_t::release_last_page(): Release the last acquired page latch.
      Replaces btr_leaf_page_release().
      
      mtr_t::release(const buf_block_t&): Release a single page latch.
      Used in btr_pcur_move_backward_from_page().
      
      mtr_t::memo_release(): Replaced with mtr_t::release().
      
      mtr_t::upgrade_buffer_fix(): Acquire a latch for a buffer-fixed page.
      This replaces the double bookkeeping in btr_cur_t::open_leaf().
      
      Reviewed by: Vladislav Lesin
      24fe5347
  9. 16 Nov, 2022 4 commits