From b47715f9ed78051328ea54eebd76bd5efd3651d1 Mon Sep 17 00:00:00 2001 From: Kirill Smelkov <kirr@nexedi.com> Date: Fri, 29 Dec 2017 21:41:03 +0300 Subject: [PATCH] . --- go/NOTES-go | 2 +- go/zodb/storage/fs1/filestorage.go | 1 + go/zodb/storage/fs1/filestorage_test.go | 2 -- go/zodb/str.go | 2 -- 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/go/NOTES-go b/go/NOTES-go index addc0a2d..cfe8082c 100644 --- a/go/NOTES-go +++ b/go/NOTES-go @@ -1,4 +1,3 @@ -? Load vs "deleted" -> err or data=nil ? -> stor.Conn flag ? IStorage.Load -> per storage connection ? random access -> mmap @@ -17,6 +16,7 @@ findrunnable runqsteal ? runqgrab schedule <- top entry +868c8b37 (runtime: only sleep before stealing work from a running P) -> stopm() // stop and restart m after waiting for work notesleep(m.park) diff --git a/go/zodb/storage/fs1/filestorage.go b/go/zodb/storage/fs1/filestorage.go index 9d2ab3bb..462bd6a4 100644 --- a/go/zodb/storage/fs1/filestorage.go +++ b/go/zodb/storage/fs1/filestorage.go @@ -127,6 +127,7 @@ var dhPool = sync.Pool{New: func() interface{} { return &DataHeader{} }} func DataHeaderAlloc() *DataHeader { return dhPool.Get().(*DataHeader) } + // Free puts dh back into DataHeader freelist. // // Caller must not use dh after call to Free. diff --git a/go/zodb/storage/fs1/filestorage_test.go b/go/zodb/storage/fs1/filestorage_test.go index 8e11f222..0d15b0b0 100644 --- a/go/zodb/storage/fs1/filestorage_test.go +++ b/go/zodb/storage/fs1/filestorage_test.go @@ -31,8 +31,6 @@ import ( "lab.nexedi.com/kirr/go123/exc" ) -// XXX -> testDbEntry ? - // one database transaction record type dbEntry struct { Header TxnHeader diff --git a/go/zodb/str.go b/go/zodb/str.go index 46da4268..aec2f22c 100644 --- a/go/zodb/str.go +++ b/go/zodb/str.go @@ -52,12 +52,10 @@ func (oid Oid) String() string { } func (tid Tid) XFmtString(b []byte) []byte { - // XXX also print "tid:" prefix ? return xfmt.AppendHex016(b, uint64(tid)) } func (oid Oid) XFmtString(b []byte) []byte { - // XXX also print "oid:" prefix ? return xfmt.AppendHex016(b, uint64(oid)) } -- 2.30.9