Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
N
neoppod
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
1
Issues
1
List
Boards
Labels
Milestones
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
neoppod
Commits
cb144fdb
Commit
cb144fdb
authored
Jul 27, 2016
by
Julien Muchembled
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reenable checkTransactionalUndoIterator
parent
38583af9
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
28 additions
and
11 deletions
+28
-11
ZODB.patch
ZODB.patch
+14
-1
ZODB3.patch
ZODB3.patch
+14
-1
neo/tests/zodb/testUndo.py
neo/tests/zodb/testUndo.py
+0
-9
No files found.
ZODB.patch
View file @
cb144fdb
...
@@ -113,7 +113,7 @@ index f0a2b72..5305807 100644
...
@@ -113,7 +113,7 @@ index f0a2b72..5305807 100644
oids.extend(oid for (oid, _) in vote_result or ())
oids.extend(oid for (oid, _) in vote_result or ())
self.assertEqual(len(oids), len(expected_oids), repr(oids))
self.assertEqual(len(oids), len(expected_oids), repr(oids))
diff --git a/src/ZODB/tests/TransactionalUndoStorage.py b/src/ZODB/tests/TransactionalUndoStorage.py
diff --git a/src/ZODB/tests/TransactionalUndoStorage.py b/src/ZODB/tests/TransactionalUndoStorage.py
index 0ee68b2..
1c88720
100644
index 0ee68b2..
4dab889
100644
--- a/src/ZODB/tests/TransactionalUndoStorage.py
--- a/src/ZODB/tests/TransactionalUndoStorage.py
+++ b/src/ZODB/tests/TransactionalUndoStorage.py
+++ b/src/ZODB/tests/TransactionalUndoStorage.py
@@ -73,6 +73,12 @@
def _transaction_vote(self, trans):
@@ -73,6 +73,12 @@
def _transaction_vote(self, trans):
...
@@ -217,3 +217,16 @@ index 0ee68b2..1c88720 100644
...
@@ -217,3 +217,16 @@ index 0ee68b2..1c88720 100644
revid1 = self._transaction_newserial(oid1)
revid1 = self._transaction_newserial(oid1)
revid2 = self._transaction_newserial(oid2)
revid2 = self._transaction_newserial(oid2)
eq(revid1, revid2)
eq(revid1, revid2)
@@ -685,9 +693,9 @@
def undo(i):
tid = p64(i + 1)
eq(txn.tid, tid)
- L1 = [(rec.oid, rec.tid, rec.data_txn) for rec in txn]
- L2 = [(oid, revid, None) for _tid, oid, revid in orig
- if _tid == tid]
+ L1 = {(rec.oid, rec.tid, rec.data_txn) for rec in txn}
+ L2 = {(oid, revid, None) for _tid, oid, revid in orig
+ if _tid == tid}
eq(L1, L2)
ZODB3.patch
View file @
cb144fdb
...
@@ -113,7 +113,7 @@ index 9737ec4..43f29ed 100644
...
@@ -113,7 +113,7 @@ index 9737ec4..43f29ed 100644
oids.extend(oid for (oid, _) in vote_result or ())
oids.extend(oid for (oid, _) in vote_result or ())
self.assertEqual(len(oids), len(expected_oids), repr(oids))
self.assertEqual(len(oids), len(expected_oids), repr(oids))
diff --git a/src/ZODB/tests/TransactionalUndoStorage.py b/src/ZODB/tests/TransactionalUndoStorage.py
diff --git a/src/ZODB/tests/TransactionalUndoStorage.py b/src/ZODB/tests/TransactionalUndoStorage.py
index 72adac2..
698e288
100644
index 72adac2..
203736a
100644
--- a/src/ZODB/tests/TransactionalUndoStorage.py
--- a/src/ZODB/tests/TransactionalUndoStorage.py
+++ b/src/ZODB/tests/TransactionalUndoStorage.py
+++ b/src/ZODB/tests/TransactionalUndoStorage.py
@@ -76,6 +76,12 @@
def _transaction_vote(self, trans):
@@ -76,6 +76,12 @@
def _transaction_vote(self, trans):
...
@@ -220,3 +220,16 @@ index 72adac2..698e288 100644
...
@@ -220,3 +220,16 @@ index 72adac2..698e288 100644
revid1 = self._transaction_newserial(oid1)
revid1 = self._transaction_newserial(oid1)
revid2 = self._transaction_newserial(oid2)
revid2 = self._transaction_newserial(oid2)
eq(revid1, revid2)
eq(revid1, revid2)
@@ -683,9 +691,9 @@
def undo(i):
tid = p64(i + 1)
eq(txn.tid, tid)
- L1 = [(rec.oid, rec.tid, rec.data_txn) for rec in txn]
- L2 = [(oid, revid, None) for _tid, oid, revid in orig
- if _tid == tid]
+ L1 = {(rec.oid, rec.tid, rec.data_txn) for rec in txn}
+ L2 = {(oid, revid, None) for _tid, oid, revid in orig
+ if _tid == tid}
eq(L1, L2)
neo/tests/zodb/testUndo.py
View file @
cb144fdb
...
@@ -28,15 +28,6 @@ class UndoTests(ZODBTestCase, StorageTestBase, TransactionalUndoStorage,
...
@@ -28,15 +28,6 @@ class UndoTests(ZODBTestCase, StorageTestBase, TransactionalUndoStorage,
checkTransactionalUndoAfterPack
=
expectedFailure
()(
checkTransactionalUndoAfterPack
=
expectedFailure
()(
TransactionalUndoStorage
.
checkTransactionalUndoAfterPack
)
TransactionalUndoStorage
.
checkTransactionalUndoAfterPack
)
# Don't run this test. It cannot run with pipelined store, and is not executed
# on Zeo - but because Zeo doesn't have an iterator, while Neo has.
# Note that it is possible to run this test on Neo with a simple fix:
# instead of expecting "store" to return object's serial, it should
# just load it after commit, and keep its serial.
# When iterator is fully implemented in Neo, a fork of that test should be
# done with above fix.
del
TransactionalUndoStorage
.
checkTransactionalUndoIterator
if
__name__
==
"__main__"
:
if
__name__
==
"__main__"
:
suite
=
unittest
.
makeSuite
(
UndoTests
,
'check'
)
suite
=
unittest
.
makeSuite
(
UndoTests
,
'check'
)
unittest
.
main
(
defaultTest
=
'suite'
)
unittest
.
main
(
defaultTest
=
'suite'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment