Add RSVP.configure('onerror')

This function is invoked when an unhandled exception is thrown.

browser/rsvp.js

@@ -38,6 +38,9 @@ define("rsvp/all",
     var Promise = __dependency1__.Promise;
 
     function all(promises) {
+      if(toString.call(promises) !== "[object Array]") {
+        throw new TypeError('You must pass an array to all.');
+      }
       return new Promise(function(resolve, reject) {
         var results = [], remaining = promises.length,
         promise;
@@ -318,7 +321,51 @@ define("rsvp/hash",
     __exports__.hash = hash;
   });
 
+define("rsvp/node",
+  ["rsvp/promise","rsvp/all","exports"],
+  function(__dependency1__, __dependency2__, __exports__) {
+    "use strict";
+    var Promise = __dependency1__.Promise;
+    var all = __dependency2__.all;
+
+    function makeNodeCallbackFor(resolve, reject) {
+      return function (error, value) {
+        if (error) {
+          reject(error);
+        } else if (arguments.length > 2) {
+          resolve(Array.prototype.slice.call(arguments, 1));
+        } else {
+          resolve(value);
+        }
+      };
+    }
+
+    function denodeify(nodeFunc) {
+      return function()  {
+        var nodeArgs = Array.prototype.slice.call(arguments), resolve, reject;
+        var thisArg = this;
+
+        var promise = new Promise(function(nodeResolve, nodeReject) {
+          resolve = nodeResolve;
+          reject = nodeReject;
+        });
+
+        all(nodeArgs).then(function(nodeArgs) {
+          nodeArgs.push(makeNodeCallbackFor(resolve, reject));
 
+          try {
+            nodeFunc.apply(thisArg, nodeArgs);
+          } catch(e) {
+            reject(e);
+          }
+        });
+
+        return promise;
+      };
+    }
+
+    __exports__.denodeify = denodeify;
+  });
 
 define("rsvp/promise",
   ["rsvp/config","rsvp/events","exports"],
@@ -367,6 +414,8 @@ define("rsvp/promise",
         this.trigger('error', { detail: event.detail });
       }, this);
 
+      this.on('error', onerror);
+
       try {
         resolver(resolvePromise, rejectPromise);
       } catch(e) {
@@ -374,6 +423,12 @@ define("rsvp/promise",
       }
     };
 
+    function onerror(event) {
+      if (config.onerror) {
+        config.onerror(event.detail);
+      }
+    }
+
     var invokeCallback = function(type, promise, callback, event) {
       var hasCallback = isFunction(callback),
           value, error, succeeded, failed;
@@ -408,6 +463,8 @@ define("rsvp/promise",
       constructor: Promise,
 
       then: function(done, fail) {
+        this.off('error', onerror);
+
         var thenPromise = new Promise(function() {});
 
         if (this.isFulfilled) {

browser/rsvp/all.amd.js

@@ -5,6 +5,9 @@ define(
     var Promise = __dependency1__.Promise;
 
     function all(promises) {
+      if(toString.call(promises) !== "[object Array]") {
+        throw new TypeError('You must pass an array to all.');
+      }
       return new Promise(function(resolve, reject) {
         var results = [], remaining = promises.length,
         promise;

browser/rsvp/node.amd.js

+define(
+  ["rsvp/promise","rsvp/all","exports"],
+  function(__dependency1__, __dependency2__, __exports__) {
+    "use strict";
+    var Promise = __dependency1__.Promise;
+    var all = __dependency2__.all;
 
+    function makeNodeCallbackFor(resolve, reject) {
+      return function (error, value) {
+        if (error) {
+          reject(error);
+        } else if (arguments.length > 2) {
+          resolve(Array.prototype.slice.call(arguments, 1));
+        } else {
+          resolve(value);
+        }
+      };
+    }
+
+    function denodeify(nodeFunc) {
+      return function()  {
+        var nodeArgs = Array.prototype.slice.call(arguments), resolve, reject;
+        var thisArg = this;
+
+        var promise = new Promise(function(nodeResolve, nodeReject) {
+          resolve = nodeResolve;
+          reject = nodeReject;
+        });
+
+        all(nodeArgs).then(function(nodeArgs) {
+          nodeArgs.push(makeNodeCallbackFor(resolve, reject));
+
+          try {
+            nodeFunc.apply(thisArg, nodeArgs);
+          } catch(e) {
+            reject(e);
+          }
+        });
+
+        return promise;
+      };
+    }
+
+    __exports__.denodeify = denodeify;
+  });

browser/rsvp/promise.amd.js

@@ -45,6 +45,8 @@ define(
         this.trigger('error', { detail: event.detail });
       }, this);
 
+      this.on('error', onerror);
+
       try {
         resolver(resolvePromise, rejectPromise);
       } catch(e) {
@@ -52,6 +54,12 @@ define(
       }
     };
 
+    function onerror(event) {
+      if (config.onerror) {
+        config.onerror(event.detail);
+      }
+    }
+
     var invokeCallback = function(type, promise, callback, event) {
       var hasCallback = isFunction(callback),
           value, error, succeeded, failed;
@@ -86,6 +94,8 @@ define(
       constructor: Promise,
 
       then: function(done, fail) {
+        this.off('error', onerror);
+
         var thenPromise = new Promise(function() {});
 
         if (this.isFulfilled) {

lib/rsvp/promise.js

@@ -41,6 +41,8 @@ var Promise = function(resolver) {
     this.trigger('error', { detail: event.detail });
   }, this);
 
+  this.on('error', onerror);
+
   try {
     resolver(resolvePromise, rejectPromise);
   } catch(e) {
@@ -48,6 +50,12 @@ var Promise = function(resolver) {
   }
 };
 
+function onerror(event) {
+  if (config.onerror) {
+    config.onerror(event.detail);
+  }
+}
+
 var invokeCallback = function(type, promise, callback, event) {
   var hasCallback = isFunction(callback),
       value, error, succeeded, failed;
@@ -82,6 +90,8 @@ Promise.prototype = {
   constructor: Promise,
 
   then: function(done, fail) {
+    this.off('error', onerror);
+
     var thenPromise = new Promise(function() {});
 
     if (this.isFulfilled) {

tests/extension-tests.js

@@ -622,6 +622,44 @@ describe("RSVP extensions", function() {
     });
   });
 
+  describe("RSVP.onerror", function(){
+    var onerror;
+
+    after(function() {
+      RSVP.configure('onerror', null);
+    });
+
+    it("When provided, any unhandled exceptions are sent to it", function(done) {
+      var thrownError = new Error();
+
+      RSVP.configure('onerror', function(error) {
+        assert.equal(error, thrownError, "The thrown error is passed in");
+        done();
+      });
+
+      new RSVP.Promise(function(resolve, reject) {
+        reject(thrownError);
+      }).then(function() {
+        // doesn't get here
+      });
+    });
+
+    it("When provided, handled exceptions are not sent to it", function(done) {
+      var thrownError = new Error();
+
+      RSVP.configure('onerror', function(error) {
+        assert(false, "Should not get here");
+      });
+
+      new RSVP.Promise(function(resolve, reject) {
+        reject(thrownError);
+      }).then(null, function(error) {
+        assert.equal(error, thrownError, "The handler should handle the error");
+        done();
+      });
+    });
+  });
+
   describe("RSVP.resolve", function(){
     specify("it should exist", function(){
       assert(RSVP.resolve);