fixup! Add referred parts' hash strings in __buildout_signature__, that...
fixup! Add referred parts' hash strings in __buildout_signature__, that invokes rebuild of a part when one of its (recursive) dependencies are modified. Parts are installed/updated in this order now.
Showing
-
Owner
Arg this is a diff I analyzed in the past but I don't remember the outcome.
-
Owner
Huh, it looks like my reply disappeared. I asked whether the test was already failing before this MR and if the diff is caused by a change in this MR.
-
Owner
yes, this failures is present in https://www.erp5.com/test_result_module/20200909-BD225A4A/2
---------------------------------------------------------------------- File "/srv/slapgrid/slappart9/srv/testnode/ddv/inst/test0-0/parts/slapos.buildout-repository/src/zc/buildout/buildout.txt", line 2600, in buildout.txt Failed example: print_(system(buildout), end='') Expected: Develop: '/sample-buildout/recipes' Uninstalling d4. Uninstalling d2. Uninstalling d1. Uninstalling debug. Installing debug. recipe recipes:debug x 1 Installing d2. d2: Creating directory data2 Updating d3. Installing d4. d4: Creating directory data2-extra Got: Develop: '/sample-buildout/recipes' Uninstalling d2. Uninstalling d1. Uninstalling debug. Installing debug. recipe recipes:debug x 1 Installing d2. d2: Creating directory data2 Updating d3. Updating d4.
-
Owner
It's not a difference from the changes in !21 (merged) , it was also failing before. Here we are just repairing this test that was already failing.
-
Owner
I found back my comment about the failure and reworded your commit.
-
Owner
Good, I saw the amended commit message. Thanks !
Please register or sign in to comment