SlapPopen: Improve logging and fix stderr and timeouts
Use select
to capture stdout
and/or stderr
in the same current thread (by multiplexing the reads) and respect timeouts.
Use select
to capture stdout
and/or stderr
in the same current thread (by multiplexing the reads) and respect timeouts.
Step 1. Fetch and check out the branch for this merge request
git fetch https://lab.nexedi.com/xavier_thompson/slapos.core.git fix/slappopen_pipes_and_timeout git checkout -b xavier_thompson/slapos.core-fix/slappopen_pipes_and_timeout FETCH_HEAD
Step 2. Review the changes locally
Step 3. Merge the branch and fix any conflicts that come up
git fetch origin git checkout origin/master git merge --no-ff xavier_thompson/slapos.core-fix/slappopen_pipes_and_timeout
Step 4. Push the result of the merge to GitLab
git push origin master
Note that pushing to GitLab requires write access to this repository.
Tip: You can also checkout merge requests locally by following these guidelines.
This will create a new commit in order to revert the existing changes.