Commit f190dc17 authored by Jérome Perrin's avatar Jérome Perrin

component/python3: version up python3.11.8

parent 6bb1b5e7
Pipeline #32631 failed with stage
in 0 seconds
...@@ -78,5 +78,5 @@ md5sum = 8847dc6458d1431d0ae0f55942deeb89 ...@@ -78,5 +78,5 @@ md5sum = 8847dc6458d1431d0ae0f55942deeb89
[python3.11] [python3.11]
<= python3-common <= python3-common
version = 3.11 version = 3.11
package_version = 3.11.5 package_version = 3.11.8
md5sum = 393856f1b7713aa8bba4b642ab9985d3 md5sum = b353b8433e560e1af2b130f56dfbd973
  • This fixed erp5.util test for SlapOS.Eggs.UnitTest-Master.Python3Next https://erp5js.nexedi.net/#/test_result_module/20240207-D6DB8C69/5? cc @tomo

  • Thanks @jerome

    It seems only a few tests are still failing in Python3.11, I'm trying to fix the last slapos.cookbook error : d1ec306a

  • great ! slapos.core has failures like this:

    ======================================================================
    FAIL: test_ConnectionError_only_implements (slapos.tests.test_interface.TestInterface.test_ConnectionError_only_implements)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/srv/slapgrid/slappart62/t/ehi/i/0/parts/slapos.core/slapos/tests/test_interface.py", line 42, in testMethod
        raise AssertionError("Unexpected methods %s" % implemented_method_list)
    AssertionError: Unexpected methods {'add_note'}

    this is because python3.11 added a add_note method on exceptions. The failing test checks that classes do not have more methods than their interfaces - but I don't understand why this would be a problem. I was about to suggest removing this test, but maybe a patch like this would be enough :

    diff --git a/slapos/slap/interface/slap.py b/slapos/slap/interface/slap.py
    index 161bc4655..f4a47e225 100644
    --- a/slapos/slap/interface/slap.py
    +++ b/slapos/slap/interface/slap.py
    @@ -32,7 +32,7 @@ Note: all strings accepted/returned by the slap library are encoded in UTF-8.
     """
     
     
    -class IException(Interface):
    +class IException(Interface, Exception):
       """
       Classes which implement IException are used to report errors.
       """
  • ( if you want to try this patch, please do :) )

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment