golang: Drop support for Go1.9, Go1.10 and Go1.11
These are old Go releases that were stopped being updated in 2018 - mid 2019: https://golang.org/doc/devel/release.html#go1.9 https://golang.org/doc/devel/release.html#go1.10 https://golang.org/doc/devel/release.html#go1.11 and that are not used by any in-tree SR or component. Don't drop Go1.12 and Go1.13 yet: they are too outdated and no longer supported, but those Go releases are still in use by the following slapos software: Go1.12: Caddy, GitLab, Grafana Go1.13: RepMan, Restic The maintainers of those software are advised to upgrade to Go1.14 due to at least recent security fixes in net/http package.
-
Owner/cc @luke, @jerome, @alain.takoudjou
-
Maintainer
Thanks for the heads up for upgrading Caddy, I hope it will be possible for Caddy v1.
-
Owner
Thanks @kirr for gitlab @alain.takoudjou was working on an upgrade, there's already an on going merge request, but this time we only update to 1.13, I guess because that's the version compatible with that version of gitlab. But since we update gitlab one or two version at a time, we need to also version up golang step by step. But that MR seems to have stalled, @alain.takoudjou let's discuss this when you have time next week.
grafana is not so important, we have this software release for "inspiration for slapos monitoring stack" but I'll try to update it when I can find some time, loki (their tool to view logs) was super interesting, I'm curious to see if it's more usable now.
-
Owner
@jerome, thanks for feedback and good luck with upgrading gitlab with @alain.takoudjou. In my experience, there should be close to zero blockers to move go1.12 -> go1.13 -> go1.14 . In other words the upgrade 99% of the time might be as smooth as just changing go version and this should be relatively cheap to try at least on a staging place. If there are problems and you need, please don't hesitate as I would be happy to share my knowledge.
P.S. for go1.15 it is not yet as clear as for go1.14 https://github.com/golang/go/issues/41303
-
Maintainer
-
Owner
@luke, thanks. I suggest to consider waiting a bit with upgrading caddy on production instances untill https://github.com/golang/go/issues/40642 (https://go-review.googlesource.com/c/go/+/256301/) lands into Go1.14. Maybe trying to upgrade staging frontends is ok in the meantime, but for production I'm not sure it would be good to go before.
-
Maintainer
@kirr ok, I'll have this in mind. Anyway the
1.0.164which is going to be picked up in the next cycle is going with this change......but having this in mind, I'll possibly revert the upgrade, and create another WIP merge request waiting for change you mentioned to be picked up by go 1.14.
-
mentioned in merge request !822 (merged)
-
Owner
The crash in Go1.14 has been fixed in Go1.14.10 (see 34f4058d). Regarding issue I was pointing about go1.15:
- the issue is not specific to go1.15 and can happen with go1.14 as well (and likely with go1.13 and go1.12, ... too);
- the issue seems to be the bug in my code, not in go.
With that I believe it should be safe to upgrade Go1.12 -> Go1.14 now (especially given that 1.12 has known unfixed security issues in net/http).
/cc @yusei
