It seems like that is indeed the reason why.
In https://lab.nexedi.com/nexedi/wendelin/-/blob/master/bt5/erp5_wendelin_tutorial_ui_test/PathTemplateItem/test_page_module/test_07_wendelin_HowTo_Create_Notebook_with_Graphs.html, the last thing the test does is checking if the plot_div
element is shown, but it does not check anything beyond that.
From looking at the HTML of both a working graph and a broken one, it also seems that the data points are not represented in any svg
template.
Thanks, @klaus . I understand now.
The problem is when accessing the array from javascript in jio: https://wendelin.nexedi.com/wendelin-HowTo.Create.Notebook.with.Graphs/WebPage_viewAsWeb wendelin.js uses the dtype and shape information it gets from jio to calculate the range request. The jio.get used in this tutorial does not return the dtype and shape if the fields are readonly. This is why they were writable but hidden. Of course this was only a workaround and a real solution must be found. One solution would be to create another hal style for accessing the array information from jio (separate api access from ui), then we do not have the risk to break it when we change the user interface.
@klaus , it is a real surprise how a form field editable attribute can break the tutorial. As I do not know the JS visual part at all can you please share the part of code which breaks?
The reason for my change is that dtype and shape are NOT UI editable (it prevented ERP5 Form from saving on Data Array). So this change is good but anyway I want to investigate the broken tutorial part.
Klaus Wölfel (57785f50) at 22 Mar 21:15
Klaus Wölfel (f9cc4164) at 22 Mar 21:15
Revert "Shjape and dtype are NOT editable but visible in UI."
... and 1 more commit
This reverts commit 111919f5
Reverting now to make Learning Track work again. Of course later it has to be resolved in a different way and UI unit test changed or extended so that it detects the error.
This reverts commit 111919f5
Reverting now to make Learning Track work again. Of course later it has to be resolved in a different way and UI unit test changed or extended so that it detects the error.
Klaus Wölfel (57785f50) at 22 Mar 17:56
Revert "Shjape and dtype are NOT editable but visible in UI."
hi @Tyagov , this commit broke the wendelin tutorial, the part where we load data in the notbeook. I did not find out yet, why the ui test of the tutorial did not detect the breakage. Maybe it only checks if graph is displayed, but not if graph shows correct data.
Ivan Tyagov (7a02e205) at 07 Mar 13:14
Python2 -> Python3 print statement.
Yes thanks done.
This was copied from zodbdgc after they appeared in some manual tests, but then I still used .history
.
Thanks, I thought it does more after tpc_finish
. I should have read _transaction.py/Transaction.commit
before.
To minimize memory usage, you may want to do obj._p_deactivate()
once you got _p_oid & _p_serial.
Why transaction.commit()
?
Why ignoring these exceptions?
Levin Zimmermann (2499d8f6) at 14 Feb 18:04
erp5_wendelin/testWendelin: Drop redundant code
ah thanks I'll also apply 2499d8f6
You call deleteObject only once
Nice, thanks for pointing this out, this makes everything much simpler