From 907a61385e0489017d965865484451bb6f419df5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Perrin?= <jerome@nexedi.com> Date: Mon, 12 Jul 2021 03:11:19 +0200 Subject: [PATCH] graph_editor: support schemas where edges can not be edited When no schema for the edge, don't try to show edge edition dialog. Until now this was crashing --- .../dream_graph_editor/jsplumb/jsplumb.js.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bt5/erp5_graph_editor/SkinTemplateItem/portal_skins/erp5_graph_editor/dream_graph_editor/jsplumb/jsplumb.js.js b/bt5/erp5_graph_editor/SkinTemplateItem/portal_skins/erp5_graph_editor/dream_graph_editor/jsplumb/jsplumb.js.js index 0e32695d60..619f831aa4 100644 --- a/bt5/erp5_graph_editor/SkinTemplateItem/portal_skins/erp5_graph_editor/dream_graph_editor/jsplumb/jsplumb.js.js +++ b/bt5/erp5_graph_editor/SkinTemplateItem/portal_skins/erp5_graph_editor/dream_graph_editor/jsplumb/jsplumb.js.js @@ -505,7 +505,11 @@ var schema; var fieldset_element; var delete_promise; - schema = expandSchema(gadget.props.data.class_definition[edge_data._class], gadget.props.data); + var class_definition = gadget.props.data.class_definition[edge_data._class]; + if (class_definition === undefined) { + return; + } + schema = expandSchema(class_definition, gadget.props.data); // We do not edit source & destination on edge this way. delete schema.properties.source; delete schema.properties.destination; -- 2.30.9