get(..., None) on a dict() is useless as get() returns None if the key cannot be found.

product/ERP5Security/ERP5UserFactory.py

@@ -115,7 +115,7 @@ class ERP5User(PropertiedUser):
         object_roles.remove('Developer')
         product_config = getattr(getConfiguration(), 'product_config', None)
         if product_config:
-          config = product_config.get('erp5', None)
+          config = product_config.get('erp5')
           if config and self.getId() in config.developer_list:
             return 1
 

product/ERP5Type/dynamic/component_package.py

@@ -209,7 +209,7 @@ class ComponentDynamicPackage(ModuleType):
         return None
 
       for version in site.getVersionPriorityList():
-        component = component_version_dict.get(version, None)
+        component = component_version_dict.get(version)
         if component is not None:
           break
       else:

product/ERP5Type/dynamic/portal_type_class.py

@@ -202,7 +202,7 @@ def generatePortalTypeClass(site, portal_type_name):
         pass
 
     if klass is None:
-      type_class_path = document_class_registry.get(type_class, None)
+      type_class_path = document_class_registry.get(type_class)
       if type_class_path is None:
         raise AttributeError('Document class %s has not been registered:'
                              ' cannot import it as base of Portal Type %s'

product/ERP5Type/mixin/component.py

@@ -292,7 +292,7 @@ class ComponentMixin(PropertyRecordableMixin, Base):
     self.dav__init(REQUEST, RESPONSE)
     self.dav__simpleifhandler(REQUEST, RESPONSE, refresh=1)
 
-    text_content = REQUEST.get('BODY', None)
+    text_content = REQUEST.get('BODY')
     if text_content is None:
       RESPONSE.setStatus(304)
     else:

product/ERP5Type/patches/PropertiedUser.py

@@ -116,7 +116,7 @@ def allowed(self, object, object_roles=None ):
       object_roles.remove('Developer')
       product_config = getattr(getConfiguration(), 'product_config', None)
       if product_config:
-        config = product_config.get('erp5', None)
+        config = product_config.get('erp5')
         if config and self.getId() in config.developer_list:
           return 1
 

product/ERP5Type/patches/User.py

@@ -29,7 +29,7 @@ def allowed(self, object, object_roles=None):
       object_roles.remove('Developer')
       product_config = getattr(getConfiguration(), 'product_config', None)
       if product_config:
-        config = product_config.get('erp5', None)
+        config = product_config.get('erp5')
         if config and self.getId() in config.developer_list:
           return 1
 
@@ -50,7 +50,7 @@ def getRoles(self):
   if role_tuple:
     product_config = getattr(getConfiguration(), 'product_config', None)
     if product_config:
-      config = product_config.get('erp5', None)
+      config = product_config.get('erp5')
       if config:
         role_set = set(role_tuple)
         user_id = self.getId()