Error thrown by subCommands.js are improved

src/jio/commands/getCommand.js

@@ -9,14 +9,28 @@ var getCommand = function(spec, my) {
     };
 
     that.validateState = function() {
-        if (!that.getDocId()) {
+        if (typeof that.getDocId() === "string" && that.getDocId() === "") {
             that.error({
-                status:20,statusText:'Document Id Required',
-                error:'document_id_required',
-                message:'No document id.',reason:'no document id'
+                "status": 20,
+                "statusText": "Document Id Required",
+                "error": "document_id_required",
+                "message": "The document id is not provided",
+                "reason": "Document id is undefined"
             });
             return false;
         }
+        if (typeof that.getAttachmentId() === "string") {
+            if (that.getAttachmentId() === "") {
+                that.error({
+                    "status": 23,
+                    "statusText": "Invalid Attachment Id",
+                    "error": "invalid_attachment_id",
+                    "message": "The attachment id must not be an empty string",
+                    "reason": "Attachment id is empty"
+                });
+            }
+            return false;
+        }
         return true;
     };
 

src/jio/commands/postCommand.js

@@ -10,6 +10,21 @@ var postCommand = function(spec, my) {
         return 'post';
     };
 
+    that.validateState = function () {
+        if (typeof that.getAttachmentId() !== "undefined") {
+            that.error({
+                "status": 21,
+                "statusText": "Invalid Document Id",
+                "error": "Invalid Document Id",
+                "message": "The document id contains '/' characters "+
+                    "which are forbidden",
+                "reason": "Document id contains '/' character(s)"
+            });
+            return false;
+        }
+        return true;
+    };
+
     that.executeOn = function(storage) {
         storage.post (that);
     };

src/jio/commands/putAttachmentCommand.js

@@ -11,15 +11,27 @@ var putAttachmentCommand = function(spec, my) {
     that.executeOn = function (storage) {
         storage.putAttachment (that);
     };
+
     that.validateState = function () {
-        if (typeof that.getContent() !== 'string') {
+        if (typeof that.getAttachmentId() === "undefined") {
             that.error({
-                status:22,statusText:'Content Required',
-                error:'content_required',
-                message:'No data to put.',reason:'no data to put'
+                "status": 22,
+                "statusText": "Attachment Id Required",
+                "error": "attachment_id_required",
+                "message": "The attachment id must be set",
+                "reason": "Attachment id not set"
             });
             return false;
         }
+        if (that.getAttachmentId() === "") {
+            that.error({
+                "status": 23,
+                "statusText": "Invalid Attachment Id",
+                "error": "invalid_attachment_id",
+                "message": "The attachment id must not be an empty string",
+                "reason": "Attachment id is empty"
+            });
+        }
         return true;
     };
 

src/jio/commands/putCommand.js

@@ -10,6 +10,31 @@ var putCommand = function(spec, my) {
         return 'put';
     };
 
+    that.validateState = function () {
+        if (typeof that.getDocId() === "string" && that.getDocId() === "") {
+            that.error({
+                "status": 20,
+                "statusText": "Document Id Required",
+                "error": "document_id_required",
+                "message": "The document id is not provided",
+                "reason": "Document id is undefined"
+            });
+            return false;
+        }
+        if (typeof that.getAttachmentId() !== "undefined") {
+            that.error({
+                "status": 21,
+                "statusText": "Invalid Document Id",
+                "error": "invalid_document_id",
+                "message": "The document id contains '/' characters "+
+                    "which are forbidden",
+                "reason": "Document id contains '/' character(s)"
+            });
+            return false;
+        }
+        return true;
+    };
+
     that.executeOn = function(storage) {
         storage.put (that);
     };