From 697605be9329f06607e87cd9e376d2f2bee99761 Mon Sep 17 00:00:00 2001 From: Vincent Pelletier <vincent@nexedi.com> Date: Thu, 1 Mar 2018 17:24:54 +0900 Subject: [PATCH] testVanillaERP5Catalog: Mark as expected failure. This is not a regression, only the test getting better at spotting an incorrect behaviour which pre-existed. --- product/ERP5Catalog/tests/testVanillaERP5Catalog.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/product/ERP5Catalog/tests/testVanillaERP5Catalog.py b/product/ERP5Catalog/tests/testVanillaERP5Catalog.py index 4847ec8c0f..2101655ed6 100644 --- a/product/ERP5Catalog/tests/testVanillaERP5Catalog.py +++ b/product/ERP5Catalog/tests/testVanillaERP5Catalog.py @@ -110,6 +110,14 @@ class TestVanillaERP5Catalog(ERP5TypeTestCase, LogInterceptor): self.assertTrue(path not in path_list) LOG('checkRelativeUrlInSQLPathList not found path:',0,path) + # This test fails because initial business template installation indexes + # installed objects using rules inconsistent with ERP5Site_reindexAll. + # This is not a regression: previously tests did not notice because they were + # not testing result set equality, but post-reindex being a superset of + # pre-reindex (bad), and pre-reindex was necessarily a subset because other + # tests run before were clearing catalog, making this test an exercise in + # futiliy. + @unittest.expectedFailure def test_1_ERP5Site_reindexAll(self): portal = self.getPortal() portal.portal_categories.newContent(portal_type='Base Category', title="GreatTitle1") @@ -124,6 +132,9 @@ class TestVanillaERP5Catalog(ERP5TypeTestCase, LogInterceptor): self.maxDiff = None self.assertItemsEqual(original_path_list, self.getSQLPathList()) + # Note: this test is only working as a sinde-effect of + # test_1_ERP5Site_reindexAll being run first (it produces a "clean" catalog). + # Otherwise, both would fail with the same error. def test_2_ERP5Site_hotReindexAll(self): """ test the hot reindexing of catalog -> catalog2 -- 2.30.9