Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
17f5a34b
Commit
17f5a34b
authored
Feb 10, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Display loading indicator when filtering ref switcher dropdown
parent
4a925837
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
3 deletions
+9
-3
app/assets/javascripts/gl_dropdown.js
app/assets/javascripts/gl_dropdown.js
+2
-0
changelogs/unreleased/27966-branch-ref-switcher-input-filter-broken.yml
...eleased/27966-branch-ref-switcher-input-filter-broken.yml
+4
-0
spec/features/projects/ref_switcher_spec.rb
spec/features/projects/ref_switcher_spec.rb
+3
-3
No files found.
app/assets/javascripts/gl_dropdown.js
View file @
17f5a34b
...
...
@@ -47,9 +47,11 @@
}
// Only filter asynchronously only if option remote is set
if
(
this
.
options
.
remote
)
{
$inputContainer
.
parent
().
addClass
(
'
is-loading
'
);
clearTimeout
(
timeout
);
return
timeout
=
setTimeout
(
function
()
{
return
this
.
options
.
query
(
this
.
input
.
val
(),
function
(
data
)
{
$inputContainer
.
parent
().
removeClass
(
'
is-loading
'
);
return
this
.
options
.
callback
(
data
);
}.
bind
(
this
));
}.
bind
(
this
),
250
);
...
...
changelogs/unreleased/27966-branch-ref-switcher-input-filter-broken.yml
0 → 100644
View file @
17f5a34b
---
title
:
Display loading indicator when filtering ref switcher dropdown
merge_request
:
author
:
spec/features/projects/ref_switcher_spec.rb
View file @
17f5a34b
...
...
@@ -20,10 +20,10 @@ feature 'Ref switcher', feature: true, js: true do
input
.
set
'binary'
wait_for_ajax
input
.
native
.
send_keys
:down
input
.
native
.
send_keys
:down
page
.
within
'.dropdown-content ul'
do
input
.
native
.
send_keys
:enter
end
end
expect
(
page
).
to
have_title
'binary-encoding'
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment