Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
192d003a
Commit
192d003a
authored
Dec 15, 2016
by
Regis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add comment about complex regex in pagination
parent
22ddaa5e
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
0 deletions
+2
-0
app/assets/javascripts/vue_pagination/index.js.es6
app/assets/javascripts/vue_pagination/index.js.es6
+2
-0
No files found.
app/assets/javascripts/vue_pagination/index.js.es6
View file @
192d003a
...
@@ -27,6 +27,8 @@
...
@@ -27,6 +27,8 @@
const { totalPages, nextPage, previousPage } = this.pageInfo;
const { totalPages, nextPage, previousPage } = this.pageInfo;
if (text === SPREAD) return;
if (text === SPREAD) return;
// the regex here is to read if the string coming in will become a valid string
// had issues with parsing using `+` because `typeof NaN === 'number'`
if (/^-?[\d.]+(?:e-?\d+)?$/.test(text)) pagenum = +text;
if (/^-?[\d.]+(?:e-?\d+)?$/.test(text)) pagenum = +text;
if (text === LAST) pagenum = totalPages;
if (text === LAST) pagenum = totalPages;
if (text === NEXT) pagenum = nextPage;
if (text === NEXT) pagenum = nextPage;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment